Jingga/oms-QA
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-QA.git synced 2026-02-09 20:48:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

phpcs+phpstan fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2019-02-07 00:05:31 +01:00
parent d0ec244f5e
commit d1999536c7
4 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Admin/Install/Navigation.php
View File

@ -36,7 +36,7 @@ class Navigation
*
* @since 1.0.0
*/
public static function install(string $path = null, DatabasePool $dbPool = null) : void
public static function install(string $path, DatabasePool $dbPool) : void
{
\Modules\Navigation\Admin\Installer::installExternal($dbPool, ['path' => __DIR__ . '/Navigation.install.json']);
}

1
Controller/ApiController.php
View File

@ -18,7 +18,6 @@ use Modules\QA\Models\QAQuestionMapper;
use phpOMS\Message\RequestAbstract;
use phpOMS\Message\ResponseAbstract;
/**
* Task class.
*

14
Controller/BackendController.php
View File

@ -15,7 +15,9 @@ declare(strict_types=1);
namespace Modules\QA\Controller;
use Modules\QA\Models\QAQuestionMapper;
use phpOMS\Asset\AssetType;
use phpOMS\Contract\RenderableInterface;
use phpOMS\Message\RequestAbstract;
use phpOMS\Message\ResponseAbstract;
@ -52,12 +54,12 @@ final class BackendController extends Controller
* @param ResponseAbstract $response Response
* @param mixed $data Generic data
*
* @return \Serializable
* @return RenderableInterface
*
* @since 1.0.0
* @codeCoverageIgnore
*/
public function viewQADashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable
public function viewQADashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
{
$view = new View($this->app, $request, $response);
$view->setTemplate('/Modules/QA/Theme/Backend/qa-dashboard');
@ -74,12 +76,12 @@ final class BackendController extends Controller
* @param ResponseAbstract $response Response
* @param mixed $data Generic data
*
* @return \Serializable
* @return RenderableInterface
*
* @since 1.0.0
* @codeCoverageIgnore
*/
public function viewQADoc(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable
public function viewQADoc(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
{
$view = new View($this->app, $request, $response);
$view->setTemplate('/Modules/QA/Theme/Backend/qa-question');
@ -95,12 +97,12 @@ final class BackendController extends Controller
* @param ResponseAbstract $response Response
* @param mixed $data Generic data
*
* @return \Serializable
* @return RenderableInterface
*
* @since 1.0.0
* @codeCoverageIgnore
*/
public function viewQAQuestionCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable
public function viewQAQuestionCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
{
$view = new View($this->app, $request, $response);
$view->setTemplate('/Modules/QA/Theme/Backend/qa-question-create');

5
Models/QAQuestionMapper.php
View File

@ -50,11 +50,6 @@ final class QAQuestionMapper extends DataMapperAbstract
*
* @var array<string, array<string, null|string>>
* @since 1.0.0
*/ /**
* Has many relation.
*
* @var array<string, array<string, string>>
* @since 1.0.0
*/
protected static $hasMany = [
'answers' => [