Type and cs fixes

This commit is contained in:
Dennis Eichhorn 2020-03-07 00:23:17 +01:00
parent 2e09552d20
commit aa536763a7
4 changed files with 13 additions and 11 deletions

View File

@ -14,7 +14,10 @@ declare(strict_types=1);
namespace Modules\QA\Controller; namespace Modules\QA\Controller;
use Modules\QA\Models\NullQACategory;
use Modules\QA\Models\NullQAQuestion;
use Modules\QA\Models\QAAnswer; use Modules\QA\Models\QAAnswer;
use Modules\QA\Models\QAAnswerMapper;
use Modules\QA\Models\QAAnswerStatus; use Modules\QA\Models\QAAnswerStatus;
use Modules\QA\Models\QACategory; use Modules\QA\Models\QACategory;
use Modules\QA\Models\QACategoryMapper; use Modules\QA\Models\QACategoryMapper;
@ -86,7 +89,7 @@ final class ApiController extends Controller
$question->setName((string) $request->getData('title')); $question->setName((string) $request->getData('title'));
$question->setQuestion((string) $request->getData('plain')); $question->setQuestion((string) $request->getData('plain'));
$question->setLanguage((string) $request->getData('language')); $question->setLanguage((string) $request->getData('language'));
$question->setCategory((int) $request->getData('category')); $question->setCategory(new NullQACategory((int) $request->getData('category')));
$question->setStatus((int) $request->getData('status')); $question->setStatus((int) $request->getData('status'));
$question->setBadges((array) $request->getData('badges')); $question->setBadges((array) $request->getData('badges'));
@ -161,9 +164,8 @@ final class ApiController extends Controller
$mardkownParser = new Markdown(); $mardkownParser = new Markdown();
$answer = new QAAnswer(); $answer = new QAAnswer();
$answer->setName((string) $request->getData('title'));
$answer->setAnswer((string) $request->getData('plain')); $answer->setAnswer((string) $request->getData('plain'));
$answer->setQuestion((int) $request->getData('question')); $answer->setQuestion(new NullQAQuestion((int) $request->getData('question')));
$answer->setStatus((int) $request->getData('status')); $answer->setStatus((int) $request->getData('status'));
return $answer; return $answer;
@ -236,7 +238,7 @@ final class ApiController extends Controller
$category = new QACategory(); $category = new QACategory();
$category->setName((string) $request->getData('title')); $category->setName((string) $request->getData('title'));
$category->setParent((int) $request->getData('parent')); $category->setParent($request->getData('parent') === null ? null : new NullQACategory((int) $request->getData('parent')));
return $category; return $category;
} }

View File

@ -41,7 +41,7 @@ class QAAnswer implements \JsonSerializable
* Answer. * Answer.
* *
* @var string * @var string
* @var 1.0.0 * @since 1.0.0
*/ */
private $answer = ''; private $answer = '';
@ -49,7 +49,7 @@ class QAAnswer implements \JsonSerializable
* Answer raw. * Answer raw.
* *
* @var string * @var string
* @var 1.0.0 * @since 1.0.0
*/ */
private $answerRaw = ''; private $answerRaw = '';
@ -65,7 +65,7 @@ class QAAnswer implements \JsonSerializable
* Is accepted answer. * Is accepted answer.
* *
* @var bool * @var bool
* @var 1.0.0 * @since 1.0.0
*/ */
private bool $isAccepted = false; private bool $isAccepted = false;
@ -73,7 +73,7 @@ class QAAnswer implements \JsonSerializable
* Created by. * Created by.
* *
* @var Account * @var Account
* @var 1.0.0 * @since 1.0.0
*/ */
private Account $createdBy; private Account $createdBy;
@ -81,7 +81,7 @@ class QAAnswer implements \JsonSerializable
* Created at. * Created at.
* *
* @var \DateTime * @var \DateTime
* @var 1.0.0 * @since 1.0.0
*/ */
private \DateTime $createdAt; private \DateTime $createdAt;

View File

@ -268,7 +268,7 @@ class QAQuestion implements \JsonSerializable
/** /**
* Get the category * Get the category
* *
* @return mixed * @return QACategory
* *
* @since 1.0.0 * @since 1.0.0
*/ */

View File

@ -47,7 +47,7 @@ final class QAQuestionMapper extends DataMapperAbstract
/** /**
* Has many relation. * Has many relation.
* *
* @var array<string, array{mapper:string, table:string, self?:?string, external?:?string}> * @var array<string, array{mapper:string, table:string, self?:?string, external?:?string, column?:string}>
* @since 1.0.0 * @since 1.0.0
*/ */
protected static array $hasMany = [ protected static array $hasMany = [