Jingga/oms-QA
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-QA.git synced 2026-02-15 23:38:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

phpstan and phpcs fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2022-03-29 16:41:17 +02:00
parent fbf3f117fb
commit 4943f88a4c
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Admin/Install/Navigation.install.json
View File

@ -10,7 +10,7 @@
"icon": null, "icon": null,
"order": 50, "order": 50,
"from": "QA", "from": "QA",
"permission": { "permission": 2, "type": null, "element": null }, "permission": { "permission": 2, "category": null, "element": null },
"parent": 1003301001, "parent": 1003301001,
"children": [ "children": [
{ {
@ -24,7 +24,7 @@
"icon": null, "icon": null,
"order": 1, "order": 1,
"from": "QA", "from": "QA",
"permission": { "permission": 2, "type": null, "element": null }, "permission": { "permission": 2, "category": null, "element": null },
"parent": 1006001001, "parent": 1006001001,
"children": [] "children": []
}, },
@ -39,7 +39,7 @@
"icon": null, "icon": null,
"order": 5, "order": 5,
"from": "QA", "from": "QA",
"permission": { "permission": 4, "type": null, "element": null }, "permission": { "permission": 4, "category": null, "element": null },
"parent": 1006001001, "parent": 1006001001,
"children": [] "children": []
}, },
@ -54,7 +54,7 @@
"icon": null, "icon": null,
"order": 10, "order": 10,
"from": "QA", "from": "QA",
"permission": { "permission": 2, "type": null, "element": null }, "permission": { "permission": 2, "category": null, "element": null },
"parent": 1006001001, "parent": 1006001001,
"children": [] "children": []
} }

20
Controller/ApiController.php
View File

@ -334,14 +334,14 @@ final class ApiController extends Controller
{ {
// @todo: check if is allowed to change // @todo: check if is allowed to change
$old = clone QAAnswerMapper::get()->where('id', (int) $request->getData('id'))->execute(); $old = clone QAAnswerMapper::get()->where('id', (int) $request->getData('id'))->execute();
$oldAccepted = QAAnswerMapper::get() $oldAccepted = QAAnswerMapper::get()
->where('question', $old->question->getId()) ->where('question', $old->question->getId())
->where('isAccepted', true) ->where('isAccepted', true)
->execute(); ->execute();
if ($old->getId() !== $oldAccepted->getId()) { if ($old->getId() !== $oldAccepted->getId()) {
$oldUnaccepted = clone $oldAccepted; $oldUnaccepted = clone $oldAccepted;
$oldUnaccepted->isAccepted = !$oldUnaccepted->isAccepted; $oldUnaccepted->isAccepted = !$oldUnaccepted->isAccepted;
$this->updateModel($request->header->account, $oldAccepted, $oldUnaccepted, QAAnswerMapper::class, 'answer', $request->getOrigin()); $this->updateModel($request->header->account, $oldAccepted, $oldUnaccepted, QAAnswerMapper::class, 'answer', $request->getOrigin());
@ -466,10 +466,10 @@ final class ApiController extends Controller
if ($questionVote === false || $questionVote instanceof NullQAQuestionVote || $questionVote === null) { if ($questionVote === false || $questionVote instanceof NullQAQuestionVote || $questionVote === null) {
$question = QAQuestionMapper::get()->where('id', (int) $request->getData('id'))->execute(); $question = QAQuestionMapper::get()->where('id', (int) $request->getData('id'))->execute();
$new = new QAQuestionVote(); $new = new QAQuestionVote();
$new->score = (int) $request->getData('type'); $new->score = (int) $request->getData('type');
$new->question = (int) $request->getData('id'); $new->question = (int) $request->getData('id');
$new->createdBy = new NullAccount($request->header->account); $new->createdBy = new NullAccount($request->header->account);
$new->createdFor = $question->createdBy->getId(); $new->createdFor = $question->createdBy->getId();
$this->createModel($request->header->account, $new, QAQuestionVoteMapper::class, 'qa_question_vote', $request->getOrigin()); $this->createModel($request->header->account, $new, QAQuestionVoteMapper::class, 'qa_question_vote', $request->getOrigin());
@ -539,10 +539,10 @@ final class ApiController extends Controller
if ($answerVote === false || $answerVote instanceof NullQAAnswerVote || $answerVote === null) { if ($answerVote === false || $answerVote instanceof NullQAAnswerVote || $answerVote === null) {
$answer = QAAnswerMapper::get()->where('id', (int) $request->getData('id'))->execute(); $answer = QAAnswerMapper::get()->where('id', (int) $request->getData('id'))->execute();
$new = new QAAnswerVote(); $new = new QAAnswerVote();
$new->score = (int) $request->getData('type'); $new->score = (int) $request->getData('type');
$new->answer = (int) $request->getData('id'); $new->answer = (int) $request->getData('id');
$new->createdBy = new NullAccount($request->header->account); $new->createdBy = new NullAccount($request->header->account);
$new->createdFor = $answer->createdBy->getId(); $new->createdFor = $answer->createdBy->getId();
$this->createModel($request->header->account, $new, QAAnswerVoteMapper::class, 'qa_answer_vote', $request->getOrigin()); $this->createModel($request->header->account, $new, QAAnswerVoteMapper::class, 'qa_answer_vote', $request->getOrigin());