Jingga/oms-QA
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-QA.git synced 2026-02-17 08:18:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix phpstan lvl 9 bugs

Browse Source
This commit is contained in:
Dennis Eichhorn 2022-12-26 20:52:58 +01:00
parent c3e77fde52
commit 45d7273032
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Controller/ApiController.php
View File

@ -161,8 +161,13 @@ final class ApiController extends Controller
$request->setData('language', $tag['language'], true); $request->setData('language', $tag['language'], true);
$internalResponse = new HttpResponse(); $internalResponse = new HttpResponse();
$this->app->moduleManager->get('Tag')->apiTagCreate($request, $internalResponse, $data); $this->app->moduleManager->get('Tag')->apiTagCreate($request, $internalResponse, null);
$question->addTag($internalResponse->get($request->uri->__toString())['response']);
if (!\is_array($data = $internalResponse->get($request->uri->__toString()))) {
continue;
}
$question->addTag($data['response']);
} else { } else {
$question->addTag(new NullTag((int) $tag['id'])); $question->addTag(new NullTag((int) $tag['id']));
} }
@ -334,7 +339,8 @@ final class ApiController extends Controller
// @todo: check if is allowed to change // @todo: check if is allowed to change
/** @var \Modules\QA\Models\QAAnswer $old */ /** @var \Modules\QA\Models\QAAnswer $old */
$old = clone QAAnswerMapper::get()->where('id', (int) $request->getData('id'))->execute(); $old = QAAnswerMapper::get()->where('id', (int) $request->getData('id'))->execute();
$old = clone $old;
/** @var \Modules\QA\Models\QAAnswer $oldAccepted */ /** @var \Modules\QA\Models\QAAnswer $oldAccepted */
$oldAccepted = QAAnswerMapper::get() $oldAccepted = QAAnswerMapper::get()
@ -413,7 +419,7 @@ final class ApiController extends Controller
public function createQAAppFromRequest(RequestAbstract $request) : QAApp public function createQAAppFromRequest(RequestAbstract $request) : QAApp
{ {
$app = new QAApp(); $app = new QAApp();
$app->name = $request->getData('name') ?? ''; $app->name = (string) ($request->getData('name') ?? '');
return $app; return $app;
} }

2
Theme/Backend/qa-dashboard.tpl.php
View File

@ -58,7 +58,7 @@ echo $this->getData('nav')->render(); ?>
<div class="portlet-foot qa-portlet-foot"> <div class="portlet-foot qa-portlet-foot">
<div class="tag-list"> <div class="tag-list">
<?php $tags = $question->getTags(); foreach ($tags as $tag) : ?> <?php $tags = $question->getTags(); foreach ($tags as $tag) : ?>
<span class="tag"><?= $tag->icon !== null ? '<i class="' . $this->printHtml($tag->icon ?? '') . '"></i>' : ''; ?><?= $this->printHtml($tag->getL11n()); ?></span> <span class="tag"><?= !empty($tag->icon) ? '<i class="' . $this->printHtml($tag->icon) . '"></i>' : ''; ?><?= $this->printHtml($tag->getL11n()); ?></span>
<?php endforeach; ?> <?php endforeach; ?>
</div> </div>

2
Theme/Backend/qa-question.tpl.php
View File

@ -70,7 +70,7 @@ echo $this->getData('nav')->render();
<div class="portlet-foot qa-portlet-foot"> <div class="portlet-foot qa-portlet-foot">
<div class="tag-list"> <div class="tag-list">
<?php $tags = $question->getTags(); foreach ($tags as $tag) : ?> <?php $tags = $question->getTags(); foreach ($tags as $tag) : ?>
<span class="tag"><?= $tag->icon !== null ? '<i class="' . $this->printHtml($tag->icon ?? '') . '"></i>' : ''; ?><?= $this->printHtml($tag->getL11n()); ?></span> <span class="tag"><?= !empty($tag->icon) ? '<i class="' . $this->printHtml($tag->icon) . '"></i>' : ''; ?><?= $this->printHtml($tag->getL11n()); ?></span>
<?php endforeach; ?> <?php endforeach; ?>
</div> </div>