From 0a55a6d472c1e48a491e9db0af433c3c267ab6bc Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Tue, 5 Apr 2022 20:04:48 +0200 Subject: [PATCH] static code analysis fixes --- Controller/ApiController.php | 8 ++++---- composer.json | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Controller/ApiController.php b/Controller/ApiController.php index c1a663d..9692662 100755 --- a/Controller/ApiController.php +++ b/Controller/ApiController.php @@ -170,7 +170,7 @@ final class ApiController extends Controller } } - if (!empty($uploadedFiles = $request->getFiles() ?? [])) { + if (!empty($uploadedFiles = $request->getFiles())) { $uploaded = $this->app->moduleManager->get('Media')->uploadFiles( [], [], @@ -185,7 +185,7 @@ final class ApiController extends Controller } } - if (!empty($mediaFiles = $request->getDataJson('media') ?? [])) { + if (!empty($mediaFiles = $request->getDataJson('media'))) { foreach ($mediaFiles as $media) { $question->addMedia(new NullMedia($media)); } @@ -268,7 +268,7 @@ final class ApiController extends Controller $answer->setStatus((int) $request->getData('status')); $answer->createdBy = new Profile(new NullAccount($request->header->account)); - if (!empty($uploadedFiles = $request->getFiles() ?? [])) { + if (!empty($uploadedFiles = $request->getFiles())) { $uploaded = $this->app->moduleManager->get('Media')->uploadFiles( [], [], @@ -283,7 +283,7 @@ final class ApiController extends Controller } } - if (!empty($mediaFiles = $request->getDataJson('media') ?? [])) { + if (!empty($mediaFiles = $request->getDataJson('media'))) { foreach ($mediaFiles as $media) { $answer->addMedia(new NullMedia($media)); } diff --git a/composer.json b/composer.json index b90cb5e..10044a1 100755 --- a/composer.json +++ b/composer.json @@ -12,7 +12,7 @@ "friendsofphp/php-cs-fixer": ">=3.2", "squizlabs/php_codesniffer": ">=3.6", "phpmd/phpmd": ">=2.9", - "phpstan/phpstan": ">=0.12.58", + "phpstan/phpstan": ">=1.5.4", "phan/phan": ">=3.2.6" }, "minimum-stability": "dev",