From 36ccc0dc4f1912f4471bc45689b9ed28b2bc6dd2 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Fri, 19 Apr 2024 02:08:37 +0000 Subject: [PATCH] general fixes --- Controller/BackendController.php | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/Controller/BackendController.php b/Controller/BackendController.php index 715322a..68431b3 100755 --- a/Controller/BackendController.php +++ b/Controller/BackendController.php @@ -153,15 +153,6 @@ final class BackendController extends Controller public function viewPurchaseOrderSuggestion(RequestAbstract $request, ResponseAbstract $response, array $data = []) : RenderableInterface { $view = new View($this->app->l11nManager, $request, $response); - if (!$request->hasData('id')) { - $response->header->status = RequestStatusCode::R_404; - $view->setTemplate('/Web/Backend/Error/404'); - - return $view; - } - - $view->setTemplate('/Modules/Purchase/Theme/Backend/order-suggestion'); - $view->data['nav'] = $this->app->moduleManager->get('Navigation')->createNavigationMid(1002105001, $request, $response); $view->data['suggestion'] = OrderSuggestionMapper::get() ->with('createdBy') @@ -187,6 +178,16 @@ final class BackendController extends Controller ->sort('elements/supplier', OrderType::ASC) ->execute(); + if ($view->data['suggestion']->id === 0) { + $response->header->status = RequestStatusCode::R_404; + $view->setTemplate('/Web/Backend/Error/404'); + + return $view; + } + + $view->setTemplate('/Modules/Purchase/Theme/Backend/order-suggestion'); + $view->data['nav'] = $this->app->moduleManager->get('Navigation')->createNavigationMid(1002105001, $request, $response); + $view->data['suggestion_data'] = $this->app->moduleManager->get('Purchase', 'Api') ->getOrderSuggestionElementData($view->data['suggestion']->elements);