From f818bafece9f70d68688db2df1834703fc3a5787 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Thu, 12 Sep 2019 19:48:00 +0200 Subject: [PATCH] fix phpcs findings --- Admin/Install/Navigation.php | 20 ++++++------- Admin/Installer.php | 18 +++++------ Admin/Status.php | 18 +++++------ Admin/Uninstaller.php | 18 +++++------ Admin/Updater.php | 18 +++++------ Controller/BackendController.php | 30 +++++++++++-------- Controller/Controller.php | 30 +++++++++---------- Models/PermissionState.php | 18 +++++------ Models/ProgressType.php | 18 +++++------ Models/Project.php | 28 ++++++++--------- Models/ProjectMapper.php | 30 +++++++++---------- Models/ProjectResponsibility.php | 18 +++++------ Models/ProjectStatus.php | 18 +++++------ Theme/Backend/Lang/Navigation.en.lang.php | 10 +++---- Theme/Backend/Lang/api.en.lang.php | 10 +++---- Theme/Backend/Lang/en.lang.php | 10 +++---- .../Backend/projectmanagement-create.tpl.php | 10 +++---- Theme/Backend/projectmanagement-list.tpl.php | 10 +++---- .../Backend/projectmanagement-profile.tpl.php | 10 +++---- 19 files changed, 174 insertions(+), 168 deletions(-) diff --git a/Admin/Install/Navigation.php b/Admin/Install/Navigation.php index 39c1c46..6493b41 100644 --- a/Admin/Install/Navigation.php +++ b/Admin/Install/Navigation.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ProjectManagement\Admin\Install - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ProjectManagement\Admin\Install + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\DataStorage\Database\DatabasePool; /** * Navigation class. * - * @package Modules\ProjectManagement\Admin\Install - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ProjectManagement\Admin\Install + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Navigation { @@ -34,7 +34,7 @@ class Navigation * * @return void * - * @since 1.0.0 + * @since 1.0.0 */ public static function install(string $path, DatabasePool $dbPool) : void { diff --git a/Admin/Installer.php b/Admin/Installer.php index 8c07bee..34ff9d2 100644 --- a/Admin/Installer.php +++ b/Admin/Installer.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ProjectManagement\Admin - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ProjectManagement\Admin + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Module\InstallerAbstract; /** * Installer class. * - * @package Modules\ProjectManagement\Admin - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ProjectManagement\Admin + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Installer extends InstallerAbstract { diff --git a/Admin/Status.php b/Admin/Status.php index 1789728..73f9c62 100644 --- a/Admin/Status.php +++ b/Admin/Status.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ProjectManagement\Admin - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ProjectManagement\Admin + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Module\StatusAbstract; /** * Navigation class. * - * @package Modules\ProjectManagement\Admin - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ProjectManagement\Admin + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Status extends StatusAbstract { diff --git a/Admin/Uninstaller.php b/Admin/Uninstaller.php index 0f574cf..6e72890 100644 --- a/Admin/Uninstaller.php +++ b/Admin/Uninstaller.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ProjectManagement\Admin - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ProjectManagement\Admin + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Module\UninstallerAbstract; /** * Uninstaller class. * - * @package Modules\ProjectManagement\Admin - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ProjectManagement\Admin + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Uninstaller extends UninstallerAbstract { diff --git a/Admin/Updater.php b/Admin/Updater.php index 6784fb9..1a2ccce 100644 --- a/Admin/Updater.php +++ b/Admin/Updater.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ProjectManagement\Admin - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ProjectManagement\Admin + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Module\UpdaterAbstract; /** * Updater class. * - * @package Modules\ProjectManagement\Admin - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ProjectManagement\Admin + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Updater extends UpdaterAbstract { diff --git a/Controller/BackendController.php b/Controller/BackendController.php index 0db85d4..b14d8dd 100644 --- a/Controller/BackendController.php +++ b/Controller/BackendController.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ProjectManagement - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ProjectManagement + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -25,21 +25,23 @@ use phpOMS\Views\View; /** * Event Management controller class. * - * @package Modules\ProjectManagement - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ProjectManagement + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ final class BackendController extends Controller { /** + * Routing end-point for application behaviour. + * * @param RequestAbstract $request Request * @param ResponseAbstract $response Response * @param mixed $data Generic data * * @return RenderableInterface * - * @since 1.0.0 + * @since 1.0.0 * @codeCoverageIgnore */ public function viewProjectManagementList(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface @@ -55,13 +57,15 @@ final class BackendController extends Controller } /** + * Routing end-point for application behaviour. + * * @param RequestAbstract $request Request * @param ResponseAbstract $response Response * @param mixed $data Generic data * * @return RenderableInterface * - * @since 1.0.0 + * @since 1.0.0 * @codeCoverageIgnore */ public function viewProjectManagementCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface @@ -74,13 +78,15 @@ final class BackendController extends Controller } /** + * Routing end-point for application behaviour. + * * @param RequestAbstract $request Request * @param ResponseAbstract $response Response * @param mixed $data Generic data * * @return RenderableInterface * - * @since 1.0.0 + * @since 1.0.0 * @codeCoverageIgnore */ public function viewProjectManagementProfile(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface diff --git a/Controller/Controller.php b/Controller/Controller.php index e5837e5..39b6d14 100644 --- a/Controller/Controller.php +++ b/Controller/Controller.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ProjectManagement - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ProjectManagement + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -20,10 +20,10 @@ use phpOMS\Module\WebInterface; /** * Event Management controller class. * - * @package Modules\ProjectManagement - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ProjectManagement + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Controller extends ModuleAbstract implements WebInterface { @@ -31,7 +31,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Module path. * - * @var string + * @var string * @since 1.0.0 */ public const MODULE_PATH = __DIR__ . '/../'; @@ -39,7 +39,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Module version. * - * @var string + * @var string * @since 1.0.0 */ public const MODULE_VERSION = '1.0.0'; @@ -47,7 +47,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Module name. * - * @var string + * @var string * @since 1.0.0 */ public const MODULE_NAME = 'ProjectManagement'; @@ -55,7 +55,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Module id. * - * @var int + * @var int * @since 1.0.0 */ public const MODULE_ID = 1001700000; @@ -63,7 +63,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Providing. * - * @var string[] + * @var string[] * @since 1.0.0 */ protected static array $providing = []; @@ -71,7 +71,7 @@ class Controller extends ModuleAbstract implements WebInterface /** * Dependencies. * - * @var string[] + * @var string[] * @since 1.0.0 */ protected static array $dependencies = []; diff --git a/Models/PermissionState.php b/Models/PermissionState.php index 142f8e5..997b829 100644 --- a/Models/PermissionState.php +++ b/Models/PermissionState.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ProjectManagement - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ProjectManagement + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Stdlib\Base\Enum; /** * Permision state enum. * - * @package Modules\ProjectManagement - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ProjectManagement + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ abstract class PermissionState extends Enum { diff --git a/Models/ProgressType.php b/Models/ProgressType.php index e1e26f9..c7c1135 100644 --- a/Models/ProgressType.php +++ b/Models/ProgressType.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ProjectManagement\Models - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ProjectManagement\Models + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Stdlib\Base\Enum; /** * Task type enum. * - * @package Modules\ProjectManagement\Models - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ProjectManagement\Models + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ abstract class ProgressType extends Enum { diff --git a/Models/Project.php b/Models/Project.php index 8f8b479..c0bc8f2 100644 --- a/Models/Project.php +++ b/Models/Project.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ProjectManagement\Models - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ProjectManagement\Models + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -21,10 +21,10 @@ use phpOMS\Localization\Money; /** * Project class. * - * @package Modules\ProjectManagement\Models - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ProjectManagement\Models + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ class Project { @@ -55,7 +55,7 @@ class Project /** * Created at. * - * @var null|\DateTime + * @var null|\DateTime * @since 1.0.0 */ private ?\DateTime $createdAt = null; @@ -63,7 +63,7 @@ class Project /** * Created by. * - * @var int + * @var int * @since 1.0.0 */ private $createdBy = 0; @@ -235,7 +235,7 @@ class Project /** * @return \DateTime * - * @since 1.0.0 + * @since 1.0.0 */ public function getCreatedAt() : \DateTime { @@ -245,7 +245,7 @@ class Project /** * @return int * - * @since 1.0.0 + * @since 1.0.0 */ public function getCreatedBy() : int { @@ -255,7 +255,7 @@ class Project /** * @param $createdBy Creator * - * @since 1.0.0 + * @since 1.0.0 */ public function setCreatedBy(int $createdBy) : void { diff --git a/Models/ProjectMapper.php b/Models/ProjectMapper.php index 88d168c..0145b71 100644 --- a/Models/ProjectMapper.php +++ b/Models/ProjectMapper.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ProjectManagement\Models - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ProjectManagement\Models + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -22,10 +22,10 @@ use phpOMS\DataStorage\Database\DataMapperAbstract; /** * Mapper class. * - * @package Modules\ProjectManagement\Models - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ProjectManagement\Models + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ final class ProjectMapper extends DataMapperAbstract { @@ -33,7 +33,7 @@ final class ProjectMapper extends DataMapperAbstract /** * Columns. * - * @var array> + * @var array> * @since 1.0.0 */ protected static array $columns = [ @@ -55,7 +55,7 @@ final class ProjectMapper extends DataMapperAbstract /** * Has many relation. * - * @var array> + * @var array> * @since 1.0.0 */ protected static array $hasMany = [ @@ -76,7 +76,7 @@ final class ProjectMapper extends DataMapperAbstract /** * Has one relation. * - * @var array> + * @var array> * @since 1.0.0 */ protected static array $ownsOne = [ @@ -89,7 +89,7 @@ final class ProjectMapper extends DataMapperAbstract /** * Primary table. * - * @var string + * @var string * @since 1.0.0 */ protected static string $table = 'projectmanagement_project'; @@ -97,7 +97,7 @@ final class ProjectMapper extends DataMapperAbstract /** * Created at. * - * @var string + * @var string * @since 1.0.0 */ protected static string $createdAt = 'projectmanagement_project_created_at'; @@ -105,7 +105,7 @@ final class ProjectMapper extends DataMapperAbstract /** * Primary field name. * - * @var string + * @var string * @since 1.0.0 */ protected static string $primaryField = 'projectmanagement_project_id'; diff --git a/Models/ProjectResponsibility.php b/Models/ProjectResponsibility.php index a102b0b..faa41f0 100644 --- a/Models/ProjectResponsibility.php +++ b/Models/ProjectResponsibility.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ProjectManagement\Models - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ProjectManagement\Models + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Stdlib\Base\Enum; /** * Task type enum. * - * @package Modules\ProjectManagement\Models - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ProjectManagement\Models + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ abstract class ProjectResponsibility extends Enum { diff --git a/Models/ProjectStatus.php b/Models/ProjectStatus.php index d2c969d..48b700b 100644 --- a/Models/ProjectStatus.php +++ b/Models/ProjectStatus.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package Modules\ProjectManagement\Models - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package Modules\ProjectManagement\Models + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ declare(strict_types=1); @@ -19,10 +19,10 @@ use phpOMS\Stdlib\Base\Enum; /** * Task type enum. * - * @package Modules\ProjectManagement\Models - * @license OMS License 1.0 - * @link https://orange-management.org - * @since 1.0.0 + * @package Modules\ProjectManagement\Models + * @license OMS License 1.0 + * @link https://orange-management.org + * @since 1.0.0 */ abstract class ProjectStatus extends Enum { diff --git a/Theme/Backend/Lang/Navigation.en.lang.php b/Theme/Backend/Lang/Navigation.en.lang.php index 72963cc..5b9875f 100644 --- a/Theme/Backend/Lang/Navigation.en.lang.php +++ b/Theme/Backend/Lang/Navigation.en.lang.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ return ['Navigation' => [ 'ProjectManagement' => 'Project Management', diff --git a/Theme/Backend/Lang/api.en.lang.php b/Theme/Backend/Lang/api.en.lang.php index 1afe44f..07bb1f6 100644 --- a/Theme/Backend/Lang/api.en.lang.php +++ b/Theme/Backend/Lang/api.en.lang.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ $MODLANG[1] = [ ]; diff --git a/Theme/Backend/Lang/en.lang.php b/Theme/Backend/Lang/en.lang.php index fc73016..b742170 100644 --- a/Theme/Backend/Lang/en.lang.php +++ b/Theme/Backend/Lang/en.lang.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ return ['ProjectManagement' => [ 'Active' => 'Active', diff --git a/Theme/Backend/projectmanagement-create.tpl.php b/Theme/Backend/projectmanagement-create.tpl.php index db78888..e59644f 100644 --- a/Theme/Backend/projectmanagement-create.tpl.php +++ b/Theme/Backend/projectmanagement-create.tpl.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ echo $this->getData('nav')->render(); ?> diff --git a/Theme/Backend/projectmanagement-list.tpl.php b/Theme/Backend/projectmanagement-list.tpl.php index 277f495..7da0c8f 100644 --- a/Theme/Backend/projectmanagement-list.tpl.php +++ b/Theme/Backend/projectmanagement-list.tpl.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ $footerView = new \phpOMS\Views\PaginationView($this->app, $this->request, $this->response); diff --git a/Theme/Backend/projectmanagement-profile.tpl.php b/Theme/Backend/projectmanagement-profile.tpl.php index 596db43..0fa58f7 100644 --- a/Theme/Backend/projectmanagement-profile.tpl.php +++ b/Theme/Backend/projectmanagement-profile.tpl.php @@ -4,11 +4,11 @@ * * PHP Version 7.4 * - * @package TBD - * @copyright Dennis Eichhorn - * @license OMS License 1.0 - * @version 1.0.0 - * @link https://orange-management.org + * @package TBD + * @copyright Dennis Eichhorn + * @license OMS License 1.0 + * @version 1.0.0 + * @link https://orange-management.org */ $project = $this->getData('project');