From 4ea210531a9132c03ca781e915e7f0d1e973bb98 Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nnes.com@googlemail.com>
Date: Fri, 11 Oct 2024 19:17:41 +0000
Subject: [PATCH] bug fixes

---
 Controller/BackendController.php | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/Controller/BackendController.php b/Controller/BackendController.php
index 46136ce..ac381dc 100755
--- a/Controller/BackendController.php
+++ b/Controller/BackendController.php
@@ -94,21 +94,23 @@ final class BackendController extends Controller
         }
 
         // Count tasks per project where tasks are used as progress indication
-        $projectIds = \implode(',', $taskProgress);
+        if (!empty($taskProgress)) {
+            $projectIds = \implode(',', $taskProgress);
 
-        $sql = <<<SQL
-        SELECT projectmanagement_task_relation_dst as id,
-            COUNT(projectmanagement_task_relation_src) as total_tasks,
-            SUM(task.task_status = 1 OR task.task_status = 2) AS open_tasks
-        FROM projectmanagement_task_relation
-        LEFT JOIN task ON projectmanagement_task_relation.projectmanagement_task_relation_src = task.task_id
-        WHERE projectmanagement_task_relation_dst IN ({$projectIds});
-        SQL;
+            $sql = <<<SQL
+            SELECT projectmanagement_task_relation_dst as id,
+                COUNT(projectmanagement_task_relation_src) as total_tasks,
+                SUM(task.task_status = 1 OR task.task_status = 2) AS open_tasks
+            FROM projectmanagement_task_relation
+            LEFT JOIN task ON projectmanagement_task_relation.projectmanagement_task_relation_src = task.task_id
+            WHERE projectmanagement_task_relation_dst IN ({$projectIds});
+            SQL;
 
-        $query   = new Builder($this->app->dbPool->get());
-        $results = $query->raw($sql)->execute()?->fetchAll(\PDO::FETCH_ASSOC) ?? [];
-        foreach ($results as $result) {
-            $view->data['progress'][$result['id']] = (int) (($result['total_tasks'] - $result['open_tasks']) / $result['total_tasks']);
+            $query   = new Builder($this->app->dbPool->get());
+            $results = $query->raw($sql)->execute()?->fetchAll(\PDO::FETCH_ASSOC) ?? [];
+            foreach ($results as $result) {
+                $view->data['progress'][$result['id']] = (int) (($result['total_tasks'] - $result['open_tasks']) / $result['total_tasks']);
+            }
         }
 
         return $view;