From d82537a0c15f2c0ccfc42124420192d1b4fa19fd Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Tue, 24 Nov 2020 17:31:20 +0100 Subject: [PATCH] remove some getter/setter --- Controller/ApiController.php | 41 ++--- Controller/BackendController.php | 2 +- Models/Contact.php | 146 +----------------- Models/Profile.php | 85 +--------- .../AccountGroupSelector/BaseView.php | 14 +- .../AccountGroupSelector/base.tpl.php | 2 +- .../AccountGroupSelector/popup.tpl.php | 4 +- Theme/Backend/profile-list.tpl.php | 8 +- Theme/Backend/profile-single.tpl.php | 34 ++-- tests/Controller/ApiControllerTest.php | 18 +-- tests/Models/ProfileMapperTest.php | 26 ++-- tests/Models/ProfileTest.php | 27 ++-- 12 files changed, 93 insertions(+), 314 deletions(-) diff --git a/Controller/ApiController.php b/Controller/ApiController.php index 2b54263..11a36e6 100755 --- a/Controller/ApiController.php +++ b/Controller/ApiController.php @@ -17,6 +17,7 @@ namespace Modules\Profile\Controller; use Modules\Admin\Models\AccountMapper; use Modules\Admin\Models\Address; use Modules\Admin\Models\AddressMapper; +use Modules\Media\Models\NullMedia; use Modules\Media\Models\PathSettings; use Modules\Profile\Models\ContactElement; use Modules\Profile\Models\ContactElementMapper; @@ -92,7 +93,7 @@ final class ApiController extends Controller return false; } - $this->createModel($request->getHeader()->getAccount(), $profile, ProfileMapper::class, 'profile', $request->getOrigin()); + $this->createModel($request->header->account, $profile, ProfileMapper::class, 'profile', $request->getOrigin()); return true; } @@ -147,30 +148,30 @@ final class ApiController extends Controller if (empty($uploadedFiles)) { $this->fillJsonResponse($request, $response, NotificationLevel::ERROR, 'Profile', 'Invalid profile image', $uploadedFiles); - $response->getHeader()->setStatusCode(RequestStatusCode::R_400); + $response->header->status = RequestStatusCode::R_400; return; } /** @var Profile $profile */ - $profile = ProfileMapper::getFor($request->getHeader()->getAccount(), 'account'); + $profile = ProfileMapper::getFor($request->header->account, 'account'); $old = clone $profile; $uploaded = $this->app->moduleManager->get('Media')->uploadFiles( $request->getData('name') ?? '', $uploadedFiles, - $request->getHeader()->getAccount(), - 'Modules/Media/Files/Accounts/' . $profile->getAccount()->getId() . ' ' . $profile->getAccount()->getName(), - '/Accounts/' . $profile->getAccount()->getId() . ' ' . $profile->getAccount()->getName(), + $request->header->account, + 'Modules/Media/Files/Accounts/' . $profile->account->getId() . ' ' . $profile->account->login, + '/Accounts/' . $profile->account->getId() . ' ' . $profile->account->login, 'profile_image', '', '', PathSettings::FILE_PATH ); - $profile->setImage(\reset($uploaded)); + $profile->image = !empty($uploaded) ? \reset($uploaded) : new NullMedia(); - $this->updateModel($request->getHeader()->getAccount(), $old, $profile, ProfileMapper::class, 'profile', $request->getOrigin()); + $this->updateModel($request->header->account, $old, $profile, ProfileMapper::class, 'profile', $request->getOrigin()); $this->fillJsonResponse($request, $response, NotificationLevel::OK, 'Profile', 'Profile successfully updated', $profile); } @@ -191,7 +192,7 @@ final class ApiController extends Controller { if (!empty($val = $this->validateContactElementCreate($request))) { $response->set('contact_element_create', new FormValidation($val)); - $response->getHeader()->setStatusCode(RequestStatusCode::R_400); + $response->header->status = RequestStatusCode::R_400; return; } @@ -201,8 +202,8 @@ final class ApiController extends Controller $contactElement = $this->createContactElementFromRequest($request); - $this->createModel($request->getHeader()->getAccount(), $contactElement, ContactElementMapper::class, 'profile-contactElement', $request->getOrigin()); - $this->createModelRelation($request->getHeader()->getAccount(), $profile, $contactElement->getId(), ProfileMapper::class, 'contactElements', '', $request->getOrigin()); + $this->createModel($request->header->account, $contactElement, ContactElementMapper::class, 'profile-contactElement', $request->getOrigin()); + $this->createModelRelation($request->header->account, $profile, $contactElement->getId(), ProfileMapper::class, 'contactElements', '', $request->getOrigin()); $this->fillJsonResponse($request, $response, NotificationLevel::OK, 'Contact Element', 'Contact element successfully created', $contactElement); } @@ -265,7 +266,7 @@ final class ApiController extends Controller { if (!empty($val = $this->validateAddressCreate($request))) { $response->set('address_create', new FormValidation($val)); - $response->getHeader()->setStatusCode(RequestStatusCode::R_400); + $response->header->status = RequestStatusCode::R_400; return; } @@ -275,8 +276,8 @@ final class ApiController extends Controller $address = $this->createAddressFromRequest($request); - $this->createModel($request->getHeader()->getAccount(), $address, AddressMapper::class, 'profile-address', $request->getOrigin()); - $this->createModelRelation($request->getHeader()->getAccount(), $profile, $address->getId(), ProfileMapper::class, 'location', '', $request->getOrigin()); + $this->createModel($request->header->account, $address, AddressMapper::class, 'profile-address', $request->getOrigin()); + $this->createModelRelation($request->header->account, $profile, $address->getId(), ProfileMapper::class, 'location', '', $request->getOrigin()); $this->fillJsonResponse($request, $response, NotificationLevel::OK, 'Address', 'Address successfully created', $address); } @@ -317,13 +318,13 @@ final class ApiController extends Controller { /** @var Address $element */ $element = new Address(); - $element->setName((string) ($request->getData('name') ?? '')); - $element->setAddition((string) ($request->getData('addition') ?? '')); - $element->setPostal((string) ($request->getData('postal') ?? '')); - $element->setCity((string) ($request->getData('city') ?? '')); - $element->setAddress((string) ($request->getData('address') ?? '')); + $element->name = (string) ($request->getData('name') ?? ''); + $element->addition = (string) ($request->getData('addition') ?? ''); + $element->postal = (string) ($request->getData('postal') ?? ''); + $element->city = (string) ($request->getData('city') ?? ''); + $element->address = (string) ($request->getData('address') ?? ''); + $element->state = (string) ($request->getData('state') ?? ''); $element->setCountry((string) ($request->getData('country') ?? '')); - $element->setState((string) ($request->getData('state') ?? '')); $element->setType((int) ($request->getData('type') ?? 0)); return $element; diff --git a/Controller/BackendController.php b/Controller/BackendController.php index 079750e..70c23f3 100755 --- a/Controller/BackendController.php +++ b/Controller/BackendController.php @@ -128,7 +128,7 @@ final class BackendController extends Controller $accGrpSelector = new \Modules\Profile\Theme\Backend\Components\AccountGroupSelector\BaseView($this->app->l11nManager, $request, $response); $view->addData('accGrpSelector', $accGrpSelector); - $view->setData('media', MediaMapper::getFor((int) $profile->getAccount()->getId(), 'createdBy')); + $view->setData('media', MediaMapper::getFor((int) $profile->account->getId(), 'createdBy')); return $view; } diff --git a/Models/Contact.php b/Models/Contact.php index 138338f..959bbcd 100644 --- a/Models/Contact.php +++ b/Models/Contact.php @@ -41,7 +41,7 @@ class Contact * @var string * @since 1.0.0 */ - protected string $name1 = ''; + public string $name1 = ''; /** * Name2 @@ -49,7 +49,7 @@ class Contact * @var string * @since 1.0.0 */ - protected string $name2 = ''; + public string $name2 = ''; /** * Name2 @@ -57,7 +57,7 @@ class Contact * @var string * @since 1.0.0 */ - protected string $name3 = ''; + public string $name3 = ''; /** * Description @@ -65,7 +65,7 @@ class Contact * @var string * @since 1.0.0 */ - protected string $description = ''; + public string $description = ''; /** * Company name @@ -73,7 +73,7 @@ class Contact * @var string * @since 1.0.0 */ - protected string $company = ''; + public string $company = ''; /** * Job title @@ -81,7 +81,7 @@ class Contact * @var string * @since 1.0.0 */ - protected string $job = ''; + public string $job = ''; /** * Birthday @@ -89,7 +89,7 @@ class Contact * @var null|\DateTime * @since 1.0.0 */ - protected ?\DateTime $birthday = null; + public ?\DateTime $birthday = null; /** * Contact image @@ -97,7 +97,7 @@ class Contact * @var Media * @since 1.0.0 */ - protected Media $image; + public Media $image; /** * Profile this contact belongs to @@ -128,134 +128,4 @@ class Contact { return $this->id; } - - /** - * Get name1. - * - * @return string - * - * @since 1.0.0 - */ - public function getName1() : string - { - return $this->name1; - } - - /** - * Set name1 - * - * @param string $name Name - * - * @return void - * - * @since 1.0.0 - */ - public function setName1(string $name) : void - { - $this->name1 = $name; - } - - /** - * Get name2. - * - * @return string - * - * @since 1.0.0 - */ - public function getName2() : string - { - return $this->name2; - } - - /** - * Set name2 - * - * @param string $name Name - * - * @return void - * - * @since 1.0.0 - */ - public function setName2(string $name) : void - { - $this->name2 = $name; - } - - /** - * Get name3. - * - * @return string - * - * @since 1.0.0 - */ - public function getName3() : string - { - return $this->name3; - } - - /** - * Set name3 - * - * @param string $name Name - * - * @return void - * - * @since 1.0.0 - */ - public function setName3(string $name) : void - { - $this->name3 = $name; - } - - /** - * Get the contact description - * - * @return string - * - * @since 1.0.0 - */ - public function getDescription() : string - { - return $this->description; - } - - /** - * Set the description - * - * @param string $description Description - * - * @return void - * - * @since 1.0.0 - */ - public function setDescription(string $description) : void - { - $this->description = $description; - } - - /** - * Set the image - * - * @param Media $image Image - * - * @return void - * - * @since 1.0.0 - */ - public function setImage(Media $image) : void - { - $this->image = $image; - } - - /** - * Get the image - * - * @return Media - * - * @since 1.0.0 - */ - public function getImage() : Media - { - return $this->image; - } } diff --git a/Models/Profile.php b/Models/Profile.php index 1aa75fd..b790e0d 100755 --- a/Models/Profile.php +++ b/Models/Profile.php @@ -45,7 +45,7 @@ class Profile implements \JsonSerializable * @var Media * @since 1.0.0 */ - protected Media $image; + public Media $image; /** * Birthday. @@ -53,7 +53,7 @@ class Profile implements \JsonSerializable * @var null|\DateTime * @since 1.0.0 */ - protected ?\DateTime $birthday = null; + public ?\DateTime $birthday = null; /** * Account. @@ -61,7 +61,7 @@ class Profile implements \JsonSerializable * @var Account * @since 1.0.0 */ - protected Account $account; + public Account $account; /** * Location data. @@ -105,7 +105,6 @@ class Profile implements \JsonSerializable public function __construct(Account $account = null) { $this->image = new NullMedia(); - $this->birthday = new \DateTime('now'); $this->account = $account ?? new NullAccount(); } @@ -237,84 +236,6 @@ class Profile implements \JsonSerializable $this->contactElements[] = $contactElement; } - /** - * Get account image. - * - * @return Media - * - * @since 1.0.0 - */ - public function getImage() : Media - { - return $this->image ?? new NullMedia(); - } - - /** - * Set account image. - * - * @param Media $image Profile image - * - * @return void - * - * @since 1.0.0 - */ - public function setImage(Media $image) : void - { - $this->image = $image; - } - - /** - * Set account. - * - * @param Account $account Profile account - * - * @return void - * - * @since 1.0.0 - */ - public function setAccount(Account $account) : void - { - $this->account = $account; - } - - /** - * Get account. - * - * @return Account - * - * @since 1.0.0 - */ - public function getAccount() : Account - { - return $this->account ?? new NullAccount(); - } - - /** - * Set birthday. - * - * @param null|\DateTime $birthday Birthday - * - * @return void - * - * @since 1.0.0 - */ - public function setBirthday(?\DateTime $birthday) : void - { - $this->birthday = $birthday; - } - - /** - * Get birthday. - * - * @return null|\DateTime - * - * @since 1.0.0 - */ - public function getBirthday() : ?\DateTime - { - return $this->birthday; - } - /** * {@inheritdoc} */ diff --git a/Theme/Backend/Components/AccountGroupSelector/BaseView.php b/Theme/Backend/Components/AccountGroupSelector/BaseView.php index c798f50..3230557 100755 --- a/Theme/Backend/Components/AccountGroupSelector/BaseView.php +++ b/Theme/Backend/Components/AccountGroupSelector/BaseView.php @@ -52,7 +52,7 @@ class BaseView extends View * @var string * @since 1.0.0 */ - private string $name = ''; + public string $name = ''; /** * {@inheritdoc} @@ -78,18 +78,6 @@ class BaseView extends View return $this->id; } - /** - * Get name - * - * @return string - * - * @since 1.0.0 - */ - public function getName() : string - { - return $this->name; - } - /** * Is required? * diff --git a/Theme/Backend/Components/AccountGroupSelector/base.tpl.php b/Theme/Backend/Components/AccountGroupSelector/base.tpl.php index a35f361..6126e63 100755 --- a/Theme/Backend/Components/AccountGroupSelector/base.tpl.php +++ b/Theme/Backend/Components/AccountGroupSelector/base.tpl.php @@ -44,7 +44,7 @@