From d02ab9c34f2f20c4ff22eb5bf30cc319d4c3b4ab Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Fri, 31 Jul 2020 18:13:52 +0200
Subject: [PATCH] inspection fixes

---
 Controller/ApiController.php                                | 6 +++---
 .../PositionTagSelector/PositionTagSelectorPopupView.php    | 6 ++++++
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/Controller/ApiController.php b/Controller/ApiController.php
index 458e064..3adeb4c 100755
--- a/Controller/ApiController.php
+++ b/Controller/ApiController.php
@@ -370,7 +370,7 @@ final class ApiController extends Controller
         $parent = (int) $request->getData('parent');
         $position->setParent(!empty($parent) ? new NullPosition($parent) : $position->getParent());
 
-        $department = (int) $request->getData('department', $request->getOrigin());
+        $department = (int) $request->getData('department');
         $position->setDepartment(!empty($department) ? new NullDepartment($department) : $position->getDepartment());
         $position->setStatus((int) ($request->getData('status') ?? $position->getStatus()));
 
@@ -431,7 +431,7 @@ final class ApiController extends Controller
         $parent = (int) $request->getData('parent');
         $position->setParent(!empty($parent) ? new NullPosition($parent) : null);
 
-        $department = (int) $request->getData('department', $request->getOrigin());
+        $department = (int) $request->getData('department');
         $position->setDepartment(!empty($department) ? new NullDepartment($department) : null);
 
         return $position;
@@ -527,7 +527,7 @@ final class ApiController extends Controller
         $department->setParent(!empty($parent) ? new NullDepartment($parent) : $department->getParent());
         $department->setStatus((int) ($request->getData('status') ?? $department->getStatus()));
 
-        $unit = (int) $request->getData('unit', $request->getOrigin());
+        $unit = (int) $request->getData('unit');
         $department->setUnit(!empty($unit) ? new NullUnit($unit) : $department->getUnit());
 
         return $department;
diff --git a/Theme/Backend/Components/PositionTagSelector/PositionTagSelectorPopupView.php b/Theme/Backend/Components/PositionTagSelector/PositionTagSelectorPopupView.php
index 6fcbdc7..9d9f8e6 100755
--- a/Theme/Backend/Components/PositionTagSelector/PositionTagSelectorPopupView.php
+++ b/Theme/Backend/Components/PositionTagSelector/PositionTagSelectorPopupView.php
@@ -30,6 +30,12 @@ use phpOMS\Views\View;
  */
 class PositionTagSelectorPopupView extends View
 {
+    /**
+     * Dom id.
+     *
+     * @var string
+     * @since 1.0.0
+     */
     private string $id = '';
 
     /**