This commit is contained in:
Dennis Eichhorn 2018-02-03 13:09:09 +01:00
parent 3f0ed5638c
commit c50a2e82bc
7 changed files with 13 additions and 17 deletions

View File

@ -19,7 +19,6 @@ use phpOMS\Module\UpdateAbstract;
use phpOMS\System\File\Directory;
use phpOMS\Module\InfoManager;
/**
* Navigation class.
*

View File

@ -359,8 +359,7 @@ class Controller extends ModuleAbstract implements WebInterface
private function validateUnitCreate(RequestAbstract $request) : array
{
$val = [];
if (
($val['name'] = empty($request->getData('name')))
if (($val['name'] = empty($request->getData('name')))
|| ($val['parent'] = (
!empty($request->getData('parent'))
&& !is_numeric($request->getData('parent'))
@ -424,7 +423,7 @@ class Controller extends ModuleAbstract implements WebInterface
return;
}
$unit = UnitMapper::get((int) $request->getData('id'));
$unit = UnitMapper::get((int) $request->getData('id'));
$status = UnitMapper::delete($unit);
$response->set($request->__toString(), $status);
@ -462,8 +461,7 @@ class Controller extends ModuleAbstract implements WebInterface
private function validatePositionCreate(RequestAbstract $request) : array
{
$val = [];
if (
($val['name'] = empty($request->getData('name')))
if (($val['name'] = empty($request->getData('name')))
|| ($val['parent'] = (
!empty($request->getData('parent'))
&& !is_numeric($request->getData('parent'))
@ -504,7 +502,7 @@ class Controller extends ModuleAbstract implements WebInterface
}
$position = PositionMapper::get((int) $request->getData('id'));
$status = PositionMapper::delete($position);
$status = PositionMapper::delete($position);
$response->set($request->__toString(), $status);
}
@ -571,8 +569,7 @@ class Controller extends ModuleAbstract implements WebInterface
private function validateDepartmentCreate(RequestAbstract $request) : array
{
$val = [];
if (
($val['name'] = empty($request->getData('name')))
if (($val['name'] = empty($request->getData('name')))
|| ($val['parent'] = (
!empty($request->getData('parent'))
&& !is_numeric($request->getData('parent'))
@ -639,7 +636,7 @@ class Controller extends ModuleAbstract implements WebInterface
}
$department = DepartmentMapper::get((int) $request->getData('id'));
$status = DepartmentMapper::delete($department);
$status = DepartmentMapper::delete($department);
$response->set($request->__toString(), $status);
}

View File

@ -16,4 +16,4 @@ namespace Modules\Organization\Models;
class NullDepartment extends Department
{
}
}

View File

@ -16,4 +16,4 @@ namespace Modules\Organization\Models;
class NullPosition extends Position
{
}
}

View File

@ -16,4 +16,4 @@ namespace Modules\Organization\Models;
class NullUnit extends Unit
{
}
}

View File

@ -26,7 +26,7 @@ use phpOMS\Stdlib\Base\Enum;
*/
abstract class PermissionState extends Enum
{
/* public */ const UNIT = 1;
/* public */ const UNIT = 1;
/* public */ const DEPARTMENT = 2;
/* public */ const POSITION = 3;
/* public */ const POSITION = 3;
}

View File

@ -26,7 +26,7 @@ use phpOMS\Stdlib\Base\Enum;
*/
abstract class Status extends Enum
{
/* public */ const ACTIVE = 1;
/* public */ const ACTIVE = 1;
/* public */ const INACTIVE = 2;
/* public */ const HIDDEN = 4;
/* public */ const HIDDEN = 4;
}