Test fixes
Some checks failed
Image optimization / general_image_workflow (push) Has been cancelled
CI / general_module_workflow_php (push) Has been cancelled
CI / general_module_workflow_js (push) Has been cancelled

This commit is contained in:
Dennis Eichhorn 2024-05-16 02:14:55 +00:00
parent 0378c59da8
commit b830560d28
8 changed files with 11 additions and 12 deletions

View File

@ -204,7 +204,13 @@ final class ApiController extends Controller
$this->app->moduleManager->get('Admin')->apiGroupCreate($newRequest, $internalResponse, $data);
/** @var \Modules\Admin\Models\Group $group */
$group = $internalResponse->getDataArray($newRequest->uri->__toString())['response'];
$group = $internalResponse->getDataArray($newRequest->uri->__toString())['response'] ?? null;
if ($group === null) {
$response->header->status = RequestStatusCode::R_400;
$this->createInvalidCreateResponse($request, $response, $group);
return;
}
$content = \json_encode([$group->id]);
if ($content === false) {

View File

@ -314,7 +314,7 @@ final class BackendController extends Controller
$view = new View($this->app->l11nManager, $request, $response);
$view->setTemplate('/Modules/Organization/Theme/Backend/department-view');
$view->data['nav'] = $this->app->moduleManager->get('Navigation')->createNavigationMid(1004704001, $request, $response);
$view->data['nav'] = $this->app->moduleManager->get('Navigation')->createNavigationMid(1004704001, $request, $response);
$view->data['unit'] = $this->app->unitId;
$selectorView = new \Modules\Organization\Theme\Backend\Components\DepartmentTagSelector\DepartmentTagSelectorView($this->app->l11nManager, $request, $response);

View File

@ -1,5 +0,0 @@
# Structure
## ER
![ER](Modules/Organization/Docs/Dev/img/er.png)

Binary file not shown.

Before

Width:  |  Height:  |  Size: 77 KiB

View File

@ -14,8 +14,6 @@ declare(strict_types=1);
namespace Modules\Organization\Models;
use Modules\Media\Models\NullMedia;
/**
* Organization null class.
*

View File

@ -20,7 +20,7 @@ use phpOMS\Uri\UriFactory;
* @var \Mouldes\Organization\Models $department;
*/
$department = $this->data['department'] ?? new NullDepartment();
$isNew = $department->id === 0;
$isNew = $department->id === 0;
echo $this->data['nav']->render(); ?>
<div class="row">

View File

@ -12,8 +12,8 @@
*/
declare(strict_types=1);
use Modules\Organization\Models\Status;
use Modules\Organization\Models\NullPosition;
use Modules\Organization\Models\Status;
use phpOMS\Uri\UriFactory;
/**

View File

@ -12,7 +12,7 @@
},
"creator": {
"name": "Jingga",
"website": "jingga.app"
"website": "https://jingga.app"
},
"description": "The business module.",
"directory": "Organization",