From 74c9a094eda6995780379c5e2cd766afa9d76c4e Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Tue, 31 Dec 2019 19:54:45 +0100 Subject: [PATCH] add todos from github --- Controller/ApiController.php | 13 +++++++++++-- Models/UnitMapper.php | 4 ---- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/Controller/ApiController.php b/Controller/ApiController.php index 79535b5..c667d1b 100644 --- a/Controller/ApiController.php +++ b/Controller/ApiController.php @@ -15,15 +15,14 @@ declare(strict_types=1); namespace Modules\Organization\Controller; use Modules\Organization\Models\Department; - use Modules\Organization\Models\DepartmentMapper; use Modules\Organization\Models\Position; use Modules\Organization\Models\PositionMapper; use Modules\Organization\Models\Status; use Modules\Organization\Models\Unit; use Modules\Organization\Models\UnitMapper; -use phpOMS\Message\NotificationLevel; +use phpOMS\Message\NotificationLevel; use phpOMS\Message\RequestAbstract; use phpOMS\Message\ResponseAbstract; use phpOMS\Model\Message\FormValidation; @@ -37,6 +36,16 @@ use phpOMS\Utils\Parser\Markdown\Markdown; * @license OMS License 1.0 * @link https://orange-management.org * @since 1.0.0 + * + * @todo Orange-Management/Modules#135 + * Automatic group generation *optional* + * Whenever a new + * * Unit + * * Department + * * Position + * is created a new group is created and all of the possibilities (this should be a optional setting for the module). + * Group name strucutre: org:position-department-unit or org:unit-department-position + * This should be solvable through hooks. */ final class ApiController extends Controller { diff --git a/Models/UnitMapper.php b/Models/UnitMapper.php index 7a3b899..44647b5 100644 --- a/Models/UnitMapper.php +++ b/Models/UnitMapper.php @@ -48,10 +48,6 @@ final class UnitMapper extends DataMapperAbstract * @since 1.0.0 */ protected static array $belongsTo = [ - 'unit' => [ - 'mapper' => self::class, - 'dest' => 'organization_uni_parent', - ], 'parent' => [ 'mapper' => self::class, 'dest' => 'organization_unit_parent',