Jingga/oms-OnlineResourceWatcher
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-OnlineResourceWatcher.git synced 2026-01-11 16:08:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bug fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2023-12-08 21:52:33 +00:00
parent 7d0aceaf4c
commit ad6a10b563
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Controller/ApiController.php
View File

@ -77,7 +77,7 @@ final class ApiController extends Controller
->execute();
if ($request->hasData('path')) {
// @todo: check if user has permission?
// @todo check if user has permission?
$this->app->moduleManager->get('Media', 'Api')->apiMediaExport($request, $response, ['guard' => __DIR__ . '/../Files']);
return;
}
@ -190,7 +190,7 @@ final class ApiController extends Controller
$resource->owner = new NullAccount($request->header->account);
$resource->path = $request->getDataString('path') ?? '';
// @todo: check if user is part of organization below AND has free resources to add!!!
// @todo check if user is part of organization below AND has free resources to add!!!
$resource->organization = new NullAccount($request->getDataInt('organization') ?? 1);
return $resource;
@ -248,9 +248,9 @@ final class ApiController extends Controller
/*
foreach ($reports as $report) {
// @todo: get templates
// @todo: get users to inform
// @todo: inform users
// @todo get templates
// @todo get users to inform
// @todo inform users
}
*/
}
@ -265,7 +265,7 @@ final class ApiController extends Controller
* @return array
*
* @since 1.0.0
* @todo: implement iterative approach where you can define a "offset" and "limit" to check only a few resources at a time
* @todo implement iterative approach where you can define a "offset" and "limit" to check only a few resources at a time
*/
public function checkResources(RequestAbstract $request, array $resources, mixed $data = null) : array
{
@ -616,7 +616,7 @@ final class ApiController extends Controller
}
}
// @todo: move to informUsers function
// @todo move to informUsers function
$owner = new Inform();
$owner->email = $resource->owner->getEmail();
$resource->inform[] = $owner;
@ -686,7 +686,7 @@ final class ApiController extends Controller
// Directory::delete($basePath . '/temp/' . $resource->id);
// @todo: delete older history depending on plan
// @todo delete older history depending on plan
unset($toCheck[$index]);
}
@ -702,7 +702,7 @@ final class ApiController extends Controller
}
if ($time > $minTime) {
// @todo: create a separate function which is called async minTime - time seconds after
// @todo create a separate function which is called async minTime - time seconds after
// This solution is just a workaround for small lists which would otherwise be forced to wait at least 60 seconds.
if (OperatingSystem::getSystem() === SystemType::LINUX) {
SystemUtils::runProc('pkill', '-9 -f wkhtmltoimage', true);

2
ICAL.txt
View File

@ -1,6 +1,6 @@
# Individual Contributor License Agreement ("CLA") 1.0
Thank you for your interest in Karaka-Management (the "Company"). In order to clarify the intellectual property license granted with Contributions from any person or entity, the Company must provide a Contributor License Agreement ("CLA") on file that has been made available to each Contributor. This license is for your protection as a Contributor as well as the protection of the Company and its users; it does not change your rights to use your own Contributions for any other purpose.
Thank you for your interest in Jingga e. K. (the "Company"). In order to clarify the intellectual property license granted with Contributions from any person or entity, the Company must provide a Contributor License Agreement ("CLA") on file that has been made available to each Contributor. This license is for your protection as a Contributor as well as the protection of the Company and its users; it does not change your rights to use your own Contributions for any other purpose.
By contributing to the Company You accept and agree to the following terms and conditions for Your present and future Contributions submitted to the Company. In return, the Company shall not use Your Contributions in a way that is contrary to the public benefit or inconsistent with its bylaws in effect at the time of the Contribution. Except for the license granted herein to the Company and recipients of software distributed by the Company, You reserve all right, title, and interest in and to Your Contributions.

2
Models/Resource.php
View File

@ -115,7 +115,7 @@ class Resource implements \JsonSerializable
* The owner/creator of the resource can be different
* from the group/organization this resource belongs to.
*
* @todo: consider to use groups instead of organizations?
* @todo consider to use groups instead of organizations?
* groups would be better for internal purposes (e.g. departments) but accounts are better for external purposes (different customers)
*
* @var Account