From f41638aa1d06a2f009c5df1a10c8b9d06719f128 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Mon, 27 Sep 2021 23:14:01 +0200 Subject: [PATCH] impl. todos or move to Project.md --- CONTRIBUTING.md | 9 +-------- Models/NewsArticleMapper.php | 5 ----- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b9dc7a5..cab9f5e 100755 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -12,14 +12,7 @@ If you have a good idea for improvement feel free to create a new issue with all ### Issues -Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the code and have the following structure: - -```php -/** - * @todo Orange-Management/Orange-Management#ISSUE_NUMBER [d:difficulty] - * Description for the issue - */ -``` +Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the `Project.md` file in the `Docs` repository. The issue information can be used to provide additional information such as priority, difficulty and type. For your first issue try to find a issue marked `[d:first]` or `[d:beginner]`. diff --git a/Models/NewsArticleMapper.php b/Models/NewsArticleMapper.php index b845fab..f295b7b 100755 --- a/Models/NewsArticleMapper.php +++ b/Models/NewsArticleMapper.php @@ -27,11 +27,6 @@ use phpOMS\DataStorage\Database\DataMapperAbstract; * @license OMS License 1.0 * @link https://orange-management.org * @since 1.0.0 - * - * @todo Orange-Management/oms-News#??? - * Too complicated select. - * I think the default getAll etc. is too complicated and has too many joins which are not really required. - * Check and fix! */ final class NewsArticleMapper extends DataMapperAbstract {