add todos from github

This commit is contained in:
Dennis Eichhorn 2019-12-31 19:54:45 +01:00
parent 626d90d610
commit c7a8dc5ded
3 changed files with 10 additions and 15 deletions

View File

@ -18,8 +18,8 @@ use Modules\News\Models\NewsArticle;
use Modules\News\Models\NewsArticleMapper; use Modules\News\Models\NewsArticleMapper;
use Modules\News\Models\NewsStatus; use Modules\News\Models\NewsStatus;
use Modules\News\Models\NewsType; use Modules\News\Models\NewsType;
use phpOMS\Account\Account;
use phpOMS\Account\Account;
use phpOMS\Localization\ISO639x1Enum; use phpOMS\Localization\ISO639x1Enum;
use phpOMS\Message\NotificationLevel; use phpOMS\Message\NotificationLevel;
use phpOMS\Message\RequestAbstract; use phpOMS\Message\RequestAbstract;
@ -221,6 +221,8 @@ final class ApiController extends Controller
* *
* @return array * @return array
* *
* @api
*
* @since 1.0.0 * @since 1.0.0
*/ */
public function getHeadlineListR(int $limit = 50, int $offset = 0, string $orderBy = 'news_created', string $ordered = 'ASC', Account $account = null) public function getHeadlineListR(int $limit = 50, int $offset = 0, string $orderBy = 'news_created', string $ordered = 'ASC', Account $account = null)

View File

@ -14,6 +14,7 @@ declare(strict_types=1);
namespace Modules\News\Controller; namespace Modules\News\Controller;
use Modules\Dashboard\Models\DashboardElementInterface;
use Modules\News\Models\NewsArticleMapper; use Modules\News\Models\NewsArticleMapper;
use Modules\News\Models\PermissionState; use Modules\News\Models\PermissionState;
@ -32,7 +33,7 @@ use phpOMS\Views\View;
* @link https://orange-management.org * @link https://orange-management.org
* @since 1.0.0 * @since 1.0.0
*/ */
final class BackendController extends Controller final class BackendController extends Controller implements DashboardElementInterface
{ {
/** /**
* Routing end-point for application behaviour. * Routing end-point for application behaviour.
@ -58,17 +59,9 @@ final class BackendController extends Controller
return $view; return $view;
} }
/** /**
* Routing end-point for application behaviour. * {@inheritdoc}
*
* @param RequestAbstract $request Request
* @param ResponseAbstract $response Response
* @param mixed $data Generic data
*
* @return RenderableInterface
*
* @since 1.0.0
* @codeCoverageIgnore
*/ */
public function viewDashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface public function viewDashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
{ {

View File

@ -89,9 +89,9 @@ echo $this->getData('nav')->render(); ?>
<div class="inner"> <div class="inner">
<table class="layout wf-100"> <table class="layout wf-100">
<tr><td><label for="permission"><?= $this->getHtml('Accounts/Groups'); ?></label> <tr><td><label for="permission"><?= $this->getHtml('Accounts/Groups'); ?></label>
<!-- @todo: add form this belongs to --> <!-- @todo add form this belongs to -->
<!-- @todo: make auto save on change for already created news article --> <!-- @todo make auto save on change for already created news article -->
<!-- @todo: add default values (some can be removed/overwritten and some not?) --> <!-- @todo add default values (some can be removed/overwritten and some not?) -->
<tr><td><?= $this->getData('accGrpSelector')->render('iReceiver', 'receiver', false); ?> <tr><td><?= $this->getData('accGrpSelector')->render('iReceiver', 'receiver', false); ?>
</table> </table>
</div> </div>