Jingga/oms-News
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-News.git synced 2026-02-17 17:08:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

impl. tests and fix validation status code

Browse Source
This commit is contained in:
Dennis Eichhorn 2020-10-06 21:51:41 +02:00
parent 9cfbd09ea2
commit b6759e618b
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Controller/ApiController.php
View File

@ -29,6 +29,7 @@ use phpOMS\Message\ResponseAbstract;
use phpOMS\Model\Message\FormValidation; use phpOMS\Model\Message\FormValidation;
use phpOMS\Module\NullModule; use phpOMS\Module\NullModule;
use phpOMS\Utils\Parser\Markdown\Markdown; use phpOMS\Utils\Parser\Markdown\Markdown;
use phpOMS\Message\Http\RequestStatusCode;
/** /**
* News controller class. * News controller class.
@ -135,6 +136,7 @@ final class ApiController extends Controller
{ {
if (!empty($val = $this->validateNewsCreate($request))) { if (!empty($val = $this->validateNewsCreate($request))) {
$response->set('news_create', new FormValidation($val)); $response->set('news_create', new FormValidation($val));
$response->getHeader()->setStatusCode(RequestStatusCode::R_400);
return; return;
} }

5
tests/Controller/Api/ApiControllerNewsArticleTrait.php
View File

@ -14,8 +14,10 @@ declare(strict_types=1);
namespace Modules\News\tests\Controller\Api; namespace Modules\News\tests\Controller\Api;
use Modules\News\Models\NewsArticleMapper;
use Modules\News\Models\NewsStatus; use Modules\News\Models\NewsStatus;
use Modules\News\Models\NewsType; use Modules\News\Models\NewsType;
use Modules\News\Models\NullNewsArticle;
use phpOMS\Message\Http\HttpRequest; use phpOMS\Message\Http\HttpRequest;
use phpOMS\Message\Http\HttpResponse; use phpOMS\Message\Http\HttpResponse;
use phpOMS\Uri\HttpUri; use phpOMS\Uri\HttpUri;
@ -99,6 +101,7 @@ trait ApiControllerNewsArticleTrait
$request->setData('id', 1); $request->setData('id', 1);
$this->module->apiNewsDelete($request, $response); $this->module->apiNewsDelete($request, $response);
self::assertGreaterThan(0, $response->get('')['response']->getId()); self::assertEquals(1, $response->get('')['response']->getId());
self::assertInstanceOf(NullNewsArticle::class, NewsArticleMapper::get(1));
} }
} }