make type hints easier to read

This commit is contained in:
Dennis Eichhorn 2020-06-08 22:43:28 +02:00
parent dd5b1da5a9
commit 827547d342
6 changed files with 46 additions and 39 deletions

View File

@ -23,6 +23,7 @@ return ['News' => [
'Groups' => 'Gruppen', 'Groups' => 'Gruppen',
'Headline' => 'Headline', 'Headline' => 'Headline',
'Headlines' => 'Headlines', 'Headlines' => 'Headlines',
'Langauge' => 'Sprache',
'Link' => 'Link', 'Link' => 'Link',
'News' => 'News', 'News' => 'News',
'Plain' => 'Plain', 'Plain' => 'Plain',

View File

@ -23,6 +23,7 @@ return ['News' => [
'Groups' => 'Groups', 'Groups' => 'Groups',
'Headline' => 'Headline', 'Headline' => 'Headline',
'Headlines' => 'Headlines', 'Headlines' => 'Headlines',
'Language' => 'Language',
'Link' => 'Link', 'Link' => 'Link',
'News' => 'News', 'News' => 'News',
'Plain' => 'Plain', 'Plain' => 'Plain',

View File

@ -15,15 +15,13 @@ declare(strict_types=1);
use Modules\News\Models\NewsType; use Modules\News\Models\NewsType;
use phpOMS\Uri\UriFactory; use phpOMS\Uri\UriFactory;
/** @var \phpOMS\Views\View $this */
/** @var \Modules\News\Models\NewsArticle[] $newsList */ /** @var \Modules\News\Models\NewsArticle[] $newsList */
$articles = $this->getData('news') ?? []; $articles = $this->getData('news') ?? [];
$previous = empty($newsList) ? '{/prefix}news/archive' : '{/prefix}news/archive?{?}&id=' . \reset($newsList)->getId() . '&ptype=-'; $previous = empty($newsList) ? '{/prefix}news/archive' : '{/prefix}news/archive?{?}&id=' . \reset($newsList)->getId() . '&ptype=-';
$next = empty($newsList) ? '{/prefix}news/archive' : '{/prefix}news/archive?{?}&id=' . \end($newsList)->getId() . '&ptype=+'; $next = empty($newsList) ? '{/prefix}news/archive' : '{/prefix}news/archive?{?}&id=' . \end($newsList)->getId() . '&ptype=+';
/**
* @var \phpOMS\Views\View $this
*/
echo $this->getData('nav')->render(); ?> echo $this->getData('nav')->render(); ?>
<div class="row"> <div class="row">
@ -44,7 +42,7 @@ echo $this->getData('nav')->render(); ?>
elseif ($news->getType() === NewsType::HEADLINE) { $color = 'purple'; } elseif ($news->getType() === NewsType::HEADLINE) { $color = 'purple'; }
elseif ($news->getType() === NewsType::LINK) { $color = 'yellow'; } elseif ($news->getType() === NewsType::LINK) { $color = 'yellow'; }
?> ?>
<tr data-href="<?= $url; ?>"> <tr tabindex="0" data-href="<?= $url; ?>">
<td><span class="tag <?= $this->printHtml($color); ?>"><?= $this->getHtml('TYPE' . $news->getType()) ?></span></a> <td><span class="tag <?= $this->printHtml($color); ?>"><?= $this->getHtml('TYPE' . $news->getType()) ?></span></a>
<td><a href="<?= $url; ?>"><?= $this->printHtml($news->getTitle()); ?></a> <td><a href="<?= $url; ?>"><?= $this->printHtml($news->getTitle()); ?></a>
<td><a href="<?= $url; ?>"><?= $this->printHtml($news->getCreatedBy()->getName1()); ?></a> <td><a href="<?= $url; ?>"><?= $this->printHtml($news->getCreatedBy()->getName1()); ?></a>

View File

@ -19,6 +19,8 @@ use phpOMS\Uri\UriFactory;
/** @var \Modules\News\Models\NewsArticle $news */ /** @var \Modules\News\Models\NewsArticle $news */
$news = $this->getData('news') ?? new NullNewsArticle(); $news = $this->getData('news') ?? new NullNewsArticle();
$isNewArticle = $news instanceof NullNewsArticle;
$languages = \phpOMS\Localization\ISO639Enum::getConstants();
/** @var \phpOMS\Views\View $this */ /** @var \phpOMS\Views\View $this */
echo $this->getData('nav')->render(); ?> echo $this->getData('nav')->render(); ?>
@ -39,39 +41,46 @@ echo $this->getData('nav')->render(); ?>
</section> </section>
<div class="box wf-100"> <div class="box wf-100">
<?= $this->getData('editor')->getData('text')->render('iNews', 'plain', 'docForm'); ?> <?= $this->getData('editor')->getData('text')->render('iNews', 'plain', 'docForm', $news->getPlain(), $news->getContent()); ?>
</div> </div>
</div> </div>
</div> </div>
<div class="col-xs-12 col-md-3"> <div class="col-xs-12 col-md-3">
<section class="portlet"> <section class="portlet">
<form id="docForm" method="PUT" action="<?= UriFactory::build('{/api}news?csrf={$CSRF}'); ?>"> <form id="docForm" method="<?= $isNewArticle ? 'PUT' : 'POST'; ?>" action="<?= UriFactory::build('{/api}news?' . ($isNewArticle ? '' : 'id={?id}&') . 'csrf={$CSRF}'); ?>">
<div class="portlet-head"><?= $this->getHtml('Status'); ?></div> <div class="portlet-head"><?= $this->getHtml('Status'); ?></div>
<div class="portlet-body"> <div class="portlet-body">
<table class="layout wf-100"> <table class="layout wf-100">
<tr><td colspan="2"><select name="status" id="iStatus"> <tr><td>
<select name="status" id="iStatus">
<option value="<?= $this->printHtml(NewsStatus::DRAFT); ?>"<?= $news->getStatus() === NewsStatus::DRAFT ? ' selected' : ''; ?>><?= $this->getHtml('Draft'); ?> <option value="<?= $this->printHtml(NewsStatus::DRAFT); ?>"<?= $news->getStatus() === NewsStatus::DRAFT ? ' selected' : ''; ?>><?= $this->getHtml('Draft'); ?>
<option value="<?= $this->printHtml(NewsStatus::VISIBLE); ?>"<?= $news->getStatus() === NewsStatus::VISIBLE ? ' selected' : ''; ?>><?= $this->getHtml('Visible'); ?> <option value="<?= $this->printHtml(NewsStatus::VISIBLE); ?>"<?= $news->getStatus() === NewsStatus::VISIBLE ? ' selected' : ''; ?>><?= $this->getHtml('Visible'); ?>
<tr> </select>
<td colspan="2"> <tr><td>
<label for="iPublish"><?= $this->getHtml('Publish'); ?></label> <label for="iPublish"><?= $this->getHtml('Publish'); ?></label>
<tr> <tr><td>
<td colspan="2">
<input type="datetime-local" name="publish" id="iPublish" value="<?= $this->printHtml($news->getPublish()->format('Y-m-d\TH:i:s')); ?>"> <input type="datetime-local" name="publish" id="iPublish" value="<?= $this->printHtml($news->getPublish()->format('Y-m-d\TH:i:s')); ?>">
<tr><td><label for="iLanguages"><?= $this->getHtml('Language'); ?></label>
<tr><td>
<select id="iLanguages" name="lang">
<?php foreach ($languages as $code => $language) : $code = \strtolower(\substr($code, 1)); ?>
<option value="<?= $this->printHtml($code); ?>"<?= $this->printHtml($code === $news->getLanguage() ? ' selected' : ''); ?>><?= $this->printHtml($language); ?>
<?php endforeach; ?>
</select>
</table> </table>
</div> </div>
<div class="portlet-foot"> <div class="portlet-foot">
<table class="layout wf-100"> <table class="layout wf-100">
<tr> <tr>
<td> <td>
<?php if ($news instanceof NullNewsArticle) : ?> <?php if ($isNewArticle) : ?>
<a href="<?= UriFactory::build('/news/dashboard'); ?>" class="button"><?= $this->getHtml('Delete', '0', '0'); ?></a> <a href="<?= UriFactory::build('/news/dashboard'); ?>" class="button"><?= $this->getHtml('Delete', '0', '0'); ?></a>
<?php else : ?> <?php else : ?>
<input type="submit" name="deleteButton" id="iDeleteButton" value="<?= $this->getHtml('Delete', '0', '0'); ?>"> <input type="submit" name="deleteButton" id="iDeleteButton" value="<?= $this->getHtml('Delete', '0', '0'); ?>">
<?php endif; ?> <?php endif; ?>
<td class="rightText"> <td class="rightText">
<input type="submit" formaction="<?= UriFactory::build('{/api}news&csrf={$CSRF}'); ?>" name="saveButton" id="iSaveButton" value="<?= $this->getHtml('Save', '0', '0'); ?>"> <input type="submit" name="saveButton" id="iSaveButton" value="<?= $this->getHtml('Save', '0', '0'); ?>">
</table> </table>
</div> </div>
</form> </form>

View File

@ -14,10 +14,8 @@ declare(strict_types=1);
use \phpOMS\Uri\UriFactory; use \phpOMS\Uri\UriFactory;
/** /** @var \phpOMS\Views\View $this */
* @var \phpOMS\Views\View $this /** @var \Modules\News\Models\NewsArticle[] $newsList */
* @var \Modules\News\Models\NewsArticle[] $newsList
*/
$newsList = $this->getData('news'); $newsList = $this->getData('news');
$previous = empty($newsList) ? '{/prefix}news/dashboard' : '{/prefix}news/dashboard?{?}&id=' . \reset($newsList)->getId() . '&ptype=-'; $previous = empty($newsList) ? '{/prefix}news/dashboard' : '{/prefix}news/dashboard?{?}&id=' . \reset($newsList)->getId() . '&ptype=-';

View File

@ -1,4 +1,5 @@
<?php <?php
/** /**
* Orange Management * Orange Management
* *
@ -12,20 +13,18 @@
*/ */
declare(strict_types=1); declare(strict_types=1);
use phpOMS\Uri\UriFactory;
/** /** @var \Modules\News\Models\NewsArticle $news */
* @var \Modules\News\Models\NewsArticle $news
*/
$news = $this->getData('news'); $news = $this->getData('news');
/** /** @var bool $editable */
* @var bool $editable
*/
$editable = $this->getData('editable'); $editable = $this->getData('editable');
/** /** @var \Modules\Tag\Models\Tag[] $tag */
* @var \phpOMS\Views\View $this $tags = $news->getTags();
*/
/** @var \phpOMS\Views\View $this */
echo $this->getData('nav')->render(); ?> echo $this->getData('nav')->render(); ?>
<div class="row"> <div class="row">
<div class="col-xs-12"> <div class="col-xs-12">
@ -34,21 +33,22 @@ echo $this->getData('nav')->render(); ?>
<h1><?= $this->printHtml($news->getTitle()); ?></h1> <h1><?= $this->printHtml($news->getTitle()); ?></h1>
<?= $news->getContent(); ?> <?= $news->getContent(); ?>
</article> </article>
<?php if ($editable || !empty($tags)) : ?>
<div class="portlet-foot"> <div class="portlet-foot">
<div class="overflowfix"> <div class="row">
<?php $tags = $news->getTags(); foreach ($tags as $tag) : ?> <div class="col-xs-6 overflowfix">
<?php foreach ($tags as $tag) : ?>
<span class="tag" style="background: <?= $this->printHtml($tag->getColor()); ?>"><?= $this->printHtml($tag->getTitle()); ?></span> <span class="tag" style="background: <?= $this->printHtml($tag->getColor()); ?>"><?= $this->printHtml($tag->getTitle()); ?></span>
<?php endforeach; ?> <?php endforeach; ?>
</div> </div>
<?php if ($editable) : ?>
<div class="col-xs-6 rightText">
<a tabindex="0" class="button" href="<?= UriFactory::build('{/prefix}news/edit?id=' . $news->getId()); ?>">Edit</a>
</div> </div>
<?php endif; ?>
</div>
</div>
<?php endif; ?>
</section> </section>
</div> </div>
</div> </div>
<?php if ($editable) : ?>
<div class="row">
<div class="box">
<a tabindex="0" class="button" href="<?= \phpOMS\Uri\UriFactory::build('{/prefix}news/edit?id=' . $news->getId()); ?>">Edit</a>
</div>
</div>
<?php endif; ?>