From 156d4c4e03c81eed6669c2fbe07f747fe16354cd Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Tue, 5 Apr 2022 20:04:48 +0200
Subject: [PATCH] static code analysis fixes

---
 Controller/ApiController.php | 8 ++++----
 composer.json                | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Controller/ApiController.php b/Controller/ApiController.php
index 8e87774..b3b3b96 100755
--- a/Controller/ApiController.php
+++ b/Controller/ApiController.php
@@ -151,8 +151,8 @@ final class ApiController extends Controller
         $newsArticle = $this->createNewsArticleFromRequest($request);
         $this->createModel($request->header->account, $newsArticle, NewsArticleMapper::class, 'news', $request->getOrigin());
 
-        if (!empty($request->getFiles() ?? [])
-            || !empty($request->getDataJson('media') ?? [])
+        if (!empty($request->getFiles())
+            || !empty($request->getDataJson('media'))
         ) {
             $this->createNewsMedia($newsArticle, $request);
         }
@@ -175,7 +175,7 @@ final class ApiController extends Controller
         $path    = $this->createNewsDir($news);
         $account = AccountMapper::get()->where('id', $request->header->account)->execute();
 
-        if (!empty($uploadedFiles = $request->getFiles() ?? [])) {
+        if (!empty($uploadedFiles = $request->getFiles())) {
             $uploaded = $this->app->moduleManager->get('Media')->uploadFiles(
                 [],
                 [],
@@ -217,7 +217,7 @@ final class ApiController extends Controller
             }
         }
 
-        if (!empty($mediaFiles = $request->getDataJson('media') ?? [])) {
+        if (!empty($mediaFiles = $request->getDataJson('media'))) {
             $collection = null;
 
             foreach ($mediaFiles as $media) {
diff --git a/composer.json b/composer.json
index b90cb5e..10044a1 100755
--- a/composer.json
+++ b/composer.json
@@ -12,7 +12,7 @@
         "friendsofphp/php-cs-fixer": ">=3.2",
         "squizlabs/php_codesniffer": ">=3.6",
         "phpmd/phpmd": ">=2.9",
-        "phpstan/phpstan": ">=0.12.58",
+        "phpstan/phpstan": ">=1.5.4",
         "phan/phan": ">=3.2.6"
     },
     "minimum-stability": "dev",