From 7b4d6928cf60ee7fd78807e7bcabf001f0216a8f Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Wed, 26 Jul 2023 09:18:05 +0000 Subject: [PATCH] fix default respone generation --- Controller/ApiController.php | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Controller/ApiController.php b/Controller/ApiController.php index d744301..a195341 100755 --- a/Controller/ApiController.php +++ b/Controller/ApiController.php @@ -17,10 +17,8 @@ namespace Modules\Navigation\Controller; use Modules\Navigation\Models\NavElement; use Modules\Navigation\Models\NavElementMapper; use phpOMS\Message\Http\RequestStatusCode; -use phpOMS\Message\NotificationLevel; use phpOMS\Message\RequestAbstract; use phpOMS\Message\ResponseAbstract; -use phpOMS\Model\Message\FormValidation; /** * Api controller for the tasks module. @@ -48,16 +46,15 @@ final class ApiController extends Controller public function apiNavElementCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void { if (!empty($val = $this->validateNavElementCreate($request))) { - $response->data['nav_element_create'] = new FormValidation($val); - $response->header->status = RequestStatusCode::R_400; + $response->header->status = RequestStatusCode::R_400; + $this->createInvalidCreateResponse($request, $response, $val); return; } $navElement = $this->createNavElementFromRequest($request); $this->createModel($request->header->account, $navElement, NavElementMapper::class, 'nav_element', $request->getOrigin()); - - $this->fillJsonResponse($request, $response, NotificationLevel::OK, 'Navigation Element', 'Element successfully created', $navElement); + $this->createStandardCreateResponse($request, $response, $navElement); } /**