From 3f418c69e8657f2b34b58a45fc0d3fea0e355088 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Mon, 27 Sep 2021 23:14:01 +0200 Subject: [PATCH] impl. todos or move to Project.md --- CONTRIBUTING.md | 9 +-------- Theme/Backend/side.tpl.php | 10 ++-------- 2 files changed, 3 insertions(+), 16 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b9dc7a5..cab9f5e 100755 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -12,14 +12,7 @@ If you have a good idea for improvement feel free to create a new issue with all ### Issues -Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the code and have the following structure: - -```php -/** - * @todo Orange-Management/Orange-Management#ISSUE_NUMBER [d:difficulty] - * Description for the issue - */ -``` +Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the `Project.md` file in the `Docs` repository. The issue information can be used to provide additional information such as priority, difficulty and type. For your first issue try to find a issue marked `[d:first]` or `[d:beginner]`. diff --git a/Theme/Backend/side.tpl.php b/Theme/Backend/side.tpl.php index 2922e46..d89d66a 100755 --- a/Theme/Backend/side.tpl.php +++ b/Theme/Backend/side.tpl.php @@ -34,15 +34,9 @@ if (isset($this->nav[NavigationType::SIDE])) : ?> nav[NavigationType::SIDE][LinkType::LINK])) : foreach ($this->nav[NavigationType::SIDE][LinkType::LINK] as $key2 => $link) : if ($link['nav_parent'] === $key) : - $uri = \phpOMS\Uri\UriFactory::build($link['nav_uri']); - $parentUri = \explode('/', $uri); - \array_pop($parentUri); - $miniParent = \ltrim(\implode('/', $parentUri), '/') . '/'; - // todo: very simpleminded solution. doesn't work for root path /en/backend etc. e.g. dashboard - // this also fails for urls which are not structured like a tree + $uri = \phpOMS\Uri\UriFactory::build($link['nav_uri']); ?> - 2 && \stripos($uriPath, $miniParent) !== false) ? ' class="active"' : ''; ?>> - getHtml($link['nav_name'], 'Navigation'); ?> +
  • getHtml($link['nav_name'], 'Navigation'); ?>