Jingga/oms-Media
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Media.git synced 2026-02-17 01:38:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix file_exists replacement

Browse Source
This commit is contained in:
Dennis Eichhorn 2020-10-08 17:52:52 +02:00
parent b6e6aabacd
commit 2755594d3c
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Admin/Installer.php
View File

@ -52,9 +52,13 @@ final class Installer extends InstallerAbstract
return; // @codeCoverageIgnore return; // @codeCoverageIgnore
} }
if (!\is_file($data['path'] ?? '')) {
throw new PathException($data['path'] ?? '');
}
$mediaFile = \file_get_contents($data['path'] ?? ''); $mediaFile = \file_get_contents($data['path'] ?? '');
if ($mediaFile === false) { if ($mediaFile === false) {
throw new PathException($data['path'] ?? ''); throw new PathException($data['path'] ?? ''); // @codeCoverageIgnore
} }
$mediaData = \json_decode($mediaFile, true); $mediaData = \json_decode($mediaFile, true);

2
tests/Admin/AdminTest.php
View File

@ -36,7 +36,7 @@ class AdminTest extends \PHPUnit\Framework\TestCase
public function testInvalidMediaInstallJsonFile() : void public function testInvalidMediaInstallJsonFile() : void
{ {
$this->expectException(\PathException::class); $this->expectException(\Exception::class);
Installer::installExternal($GLOBALS['dbpool'], ['path' => 'invalidJson.json']); Installer::installExternal($GLOBALS['dbpool'], ['path' => 'invalidJson.json']);
} }