Jingga/oms-Labeling
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Labeling.git synced 2026-02-12 07:38:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bug fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2023-12-08 21:52:33 +00:00
parent be9633258d
commit 82aacb62f0
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Controller/ApiController.php
View File

@ -114,7 +114,7 @@ final class ApiController extends Controller
__DIR__ . '/../../../Modules/Media/Files' . $path __DIR__ . '/../../../Modules/Media/Files' . $path
); );
// @todo: I think we need to add the uploaded files to the collection. // @todo I think we need to add the uploaded files to the collection.
// The frontend should work without it because of some "smart" corrections (virtualPath), but it is not correct. // The frontend should work without it because of some "smart" corrections (virtualPath), but it is not correct.
// In the db there should be a relationship defined, no? // In the db there should be a relationship defined, no?
// If that is the case, maybe we also need to adjust the api. Either the uploadFiles should create the collection (if specified) // If that is the case, maybe we also need to adjust the api. Either the uploadFiles should create the collection (if specified)

2
Models/Label.php
View File

@ -65,7 +65,7 @@ class Label
foreach ($this->elements as $element) { foreach ($this->elements as $element) {
$color = 0; $color = 0;
// @todo: replace int type with enum // @todo replace int type with enum
if ($element instanceof Shape) { if ($element instanceof Shape) {
if ($element->type === ShapeType::LINE) { if ($element->type === ShapeType::LINE) {
if ($element->borderThickness === 1) { if ($element->borderThickness === 1) {