Jingga/oms-Knowledgebase
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Knowledgebase.git synced 2026-02-12 08:18:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cs fixes, bug fixes, code coverage

Browse Source
This commit is contained in:
Dennis Eichhorn 2021-11-16 00:05:43 +01:00
parent 3185b8417e
commit a1e9ca2c92
12 changed files with 38 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CONTRIBUTING.md
View File

@ -12,9 +12,7 @@ If you have a good idea for improvement feel free to create a new issue with all
### Issues ### Issues
Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the `Project.md` file in the `Docs` repository. Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the code marked with `@todo` or in the [PROJECT.md](https://github.com/Orange-Management/Docs/blob/master/Project/PROJECT.md) file.
The issue information can be used to provide additional information such as priority, difficulty and type. For your first issue try to find a issue marked `[d:first]` or `[d:beginner]`.
### Code Style ### Code Style

1
Models/WikiDoc.php
View File

@ -18,7 +18,6 @@ use Modules\Media\Models\Media;
use Modules\Tag\Models\Tag; use Modules\Tag\Models\Tag;
use phpOMS\Localization\ISO639x1Enum; use phpOMS\Localization\ISO639x1Enum;
/** /**
* Wiki document class. * Wiki document class.
* *

1
tests/Models/WikiAppMapperTest.php
View File

@ -16,7 +16,6 @@ namespace Modules\Knowledgebase\tests\Models;
use Modules\Knowledgebase\Models\WikiApp; use Modules\Knowledgebase\Models\WikiApp;
use Modules\Knowledgebase\Models\WikiAppMapper; use Modules\Knowledgebase\Models\WikiAppMapper;
use phpOMS\Utils\RnG\Text;
/** /**
* @testdox Modules\tests\Knowledgebase\Models\WikiAppMapperTest: Wiki application mapper * @testdox Modules\tests\Knowledgebase\Models\WikiAppMapperTest: Wiki application mapper

3
tests/Models/WikiCategoryMapperTest.php
View File

@ -14,10 +14,10 @@ declare(strict_types=1);
namespace Modules\Knowledgebase\tests\Models; namespace Modules\Knowledgebase\tests\Models;
use Modules\Knowledgebase\Models\NullWikiApp;
use Modules\Knowledgebase\Models\NullWikiCategory; use Modules\Knowledgebase\Models\NullWikiCategory;
use Modules\Knowledgebase\Models\WikiCategory; use Modules\Knowledgebase\Models\WikiCategory;
use Modules\Knowledgebase\Models\WikiCategoryMapper; use Modules\Knowledgebase\Models\WikiCategoryMapper;
use phpOMS\Utils\RnG\Text;
/** /**
* @testdox Modules\tests\Knowledgebase\Models\WikiCategoryMapperTest: Wiki category mapper * @testdox Modules\tests\Knowledgebase\Models\WikiCategoryMapperTest: Wiki category mapper
@ -62,6 +62,7 @@ final class WikiCategoryMapperTest extends \PHPUnit\Framework\TestCase
*/ */
public function testChildCR() : void public function testChildCR() : void
{ {
$this->category->app = new NullWikiApp(1);
$this->category->setL11n('Test Category2'); $this->category->setL11n('Test Category2');
$this->category->parent = new NullWikiCategory(1); $this->category->parent = new NullWikiCategory(1);

1
tests/Models/WikiDocMapperTest.php
View File

@ -18,7 +18,6 @@ use Modules\Knowledgebase\Models\NullWikiCategory;
use Modules\Knowledgebase\Models\WikiDoc; use Modules\Knowledgebase\Models\WikiDoc;
use Modules\Knowledgebase\Models\WikiDocMapper; use Modules\Knowledgebase\Models\WikiDocMapper;
use Modules\Knowledgebase\Models\WikiStatus; use Modules\Knowledgebase\Models\WikiStatus;
use phpOMS\Utils\RnG\Text;
/** /**
* @testdox Modules\tests\Knowledgebase\Models\WikiDocMapperTest: Wiki document mapper * @testdox Modules\tests\Knowledgebase\Models\WikiDocMapperTest: Wiki document mapper

2
tests/Models/WikiDocTest.php
View File

@ -18,8 +18,8 @@ use Modules\Knowledgebase\Models\NullWikiApp;
use Modules\Knowledgebase\Models\NullWikiCategory; use Modules\Knowledgebase\Models\NullWikiCategory;
use Modules\Knowledgebase\Models\WikiDoc; use Modules\Knowledgebase\Models\WikiDoc;
use Modules\Knowledgebase\Models\WikiStatus; use Modules\Knowledgebase\Models\WikiStatus;
use Modules\Tag\Models\NullTag;
use Modules\Media\Models\Media; use Modules\Media\Models\Media;
use Modules\Tag\Models\NullTag;
use phpOMS\Localization\ISO639x1Enum; use phpOMS\Localization\ISO639x1Enum;
/** /**