Jingga/oms-Kanban
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Kanban.git synced 2026-02-17 12:48:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

autofixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2020-11-24 18:44:22 +01:00
parent 11bd0bed0d
commit c817a6733a
6 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Controller/ApiController.php
View File

@ -21,6 +21,8 @@ use Modules\Kanban\Models\CardType;
use Modules\Kanban\Models\KanbanBoard; use Modules\Kanban\Models\KanbanBoard;
use Modules\Kanban\Models\KanbanBoardMapper; use Modules\Kanban\Models\KanbanBoardMapper;
use Modules\Kanban\Models\KanbanCard; use Modules\Kanban\Models\KanbanCard;
use Modules\Kanban\Models\KanbanCardComment;
use Modules\Kanban\Models\KanbanCardCommentMapper;
use Modules\Kanban\Models\KanbanCardMapper; use Modules\Kanban\Models\KanbanCardMapper;
use Modules\Kanban\Models\KanbanColumn; use Modules\Kanban\Models\KanbanColumn;
use Modules\Kanban\Models\KanbanColumnMapper; use Modules\Kanban\Models\KanbanColumnMapper;
@ -29,8 +31,6 @@ use phpOMS\Message\NotificationLevel;
use phpOMS\Message\RequestAbstract; use phpOMS\Message\RequestAbstract;
use phpOMS\Message\ResponseAbstract; use phpOMS\Message\ResponseAbstract;
use phpOMS\Model\Message\FormValidation; use phpOMS\Model\Message\FormValidation;
use Modules\Kanban\Models\KanbanCardComment;
use Modules\Kanban\Models\KanbanCardCommentMapper;
/** /**
* Kanban controller class. * Kanban controller class.
@ -84,8 +84,8 @@ final class ApiController extends Controller
*/ */
public function createKanbanCardFromRequest(RequestAbstract $request) : KanbanCard public function createKanbanCardFromRequest(RequestAbstract $request) : KanbanCard
{ {
$card = new KanbanCard(); $card = new KanbanCard();
$card->name = (string) ($request->getData('title')); $card->name = (string) ($request->getData('title'));
$card->description = (string) ($request->getData('plain') ?? ''); $card->description = (string) ($request->getData('plain') ?? '');
$card->setColumn((int) $request->getData('column')); $card->setColumn((int) $request->getData('column'));
$card->setOrder((int) ($request->getData('order') ?? 1)); $card->setOrder((int) ($request->getData('order') ?? 1));
@ -164,7 +164,7 @@ final class ApiController extends Controller
*/ */
public function createKanbanCardCommentFromRequest(RequestAbstract $request) : KanbanCardComment public function createKanbanCardCommentFromRequest(RequestAbstract $request) : KanbanCardComment
{ {
$comment = new KanbanCardComment(); $comment = new KanbanCardComment();
$comment->description = (string) ($request->getData('plain') ?? ''); $comment->description = (string) ($request->getData('plain') ?? '');
$comment->setCard((int) $request->getData('card')); $comment->setCard((int) $request->getData('card'));
$comment->createdBy = new NullAccount($request->header->account); $comment->createdBy = new NullAccount($request->header->account);
@ -231,8 +231,8 @@ final class ApiController extends Controller
*/ */
public function createKanbanBoardFromRequest(RequestAbstract $request) : KanbanBoard public function createKanbanBoardFromRequest(RequestAbstract $request) : KanbanBoard
{ {
$board = new KanbanBoard(); $board = new KanbanBoard();
$board->name = (string) $request->getData('title'); $board->name = (string) $request->getData('title');
$board->description = (string) ($request->getData('plain') ?? ''); $board->description = (string) ($request->getData('plain') ?? '');
$board->setOrder((int) ($request->getData('order') ?? 1)); $board->setOrder((int) ($request->getData('order') ?? 1));
$board->setStatus((int) ($request->getData('status') ?? BoardStatus::ACTIVE)); $board->setStatus((int) ($request->getData('status') ?? BoardStatus::ACTIVE));
@ -303,7 +303,7 @@ final class ApiController extends Controller
*/ */
public function createKanbanColumnFromRequest(RequestAbstract $request) : KanbanColumn public function createKanbanColumnFromRequest(RequestAbstract $request) : KanbanColumn
{ {
$column = new KanbanColumn(); $column = new KanbanColumn();
$column->name = (string) $request->getData('title'); $column->name = (string) $request->getData('title');
$column->setBoard((int) $request->getData('board')); $column->setBoard((int) $request->getData('board'));
$column->setOrder((int) ($request->getData('order') ?? 1)); $column->setOrder((int) ($request->getData('order') ?? 1));

8
tests/Models/1KanbanBoardMapperTest.php
View File

@ -32,9 +32,9 @@ class KanbanBoardMapperTest extends \PHPUnit\Framework\TestCase
{ {
$board = new KanbanBoard(); $board = new KanbanBoard();
$board->name = 'Test Board 0'; $board->name = 'Test Board 0';
$board->description = 'This is some description'; $board->description = 'This is some description';
$board->createdBy = new NullAccount(1); $board->createdBy = new NullAccount(1);
$id = KanbanBoardMapper::create($board); $id = KanbanBoardMapper::create($board);
self::assertGreaterThan(0, $board->getId()); self::assertGreaterThan(0, $board->getId());
@ -60,9 +60,9 @@ class KanbanBoardMapperTest extends \PHPUnit\Framework\TestCase
$text = new Text(); $text = new Text();
$board = new KanbanBoard(); $board = new KanbanBoard();
$board->name = $text->generateText(\mt_rand(3, 7)); $board->name = $text->generateText(\mt_rand(3, 7));
$board->description = $text->generateText(\mt_rand(20, 70)); $board->description = $text->generateText(\mt_rand(20, 70));
$board->createdBy = new NullAccount(1); $board->createdBy = new NullAccount(1);
$id = KanbanBoardMapper::create($board); $id = KanbanBoardMapper::create($board);
} }

4
tests/Models/4KanbanCardMapperTest.php
View File

@ -34,7 +34,7 @@ class KanbanCardMapperTest extends \PHPUnit\Framework\TestCase
{ {
$card = new KanbanCard(); $card = new KanbanCard();
$card->name = 'Some Card name'; $card->name = 'Some Card name';
$card->description = 'This is some card description'; $card->description = 'This is some card description';
$card->setStatus(CardStatus::ACTIVE); $card->setStatus(CardStatus::ACTIVE);
$card->setType(CardType::TEXT); $card->setType(CardType::TEXT);
@ -93,7 +93,7 @@ class KanbanCardMapperTest extends \PHPUnit\Framework\TestCase
$text = new Text(); $text = new Text();
$card = new KanbanCard(); $card = new KanbanCard();
$card->name = $text->generateText(\mt_rand(3, 7)); $card->name = $text->generateText(\mt_rand(3, 7));
$card->description = $text->generateText(\mt_rand(20, 100)); $card->description = $text->generateText(\mt_rand(20, 100));
$card->setStatus(CardStatus::ACTIVE); $card->setStatus(CardStatus::ACTIVE);
$card->setType(CardType::TEXT); $card->setType(CardType::TEXT);

2
tests/Models/KanbanBoardTest.php
View File

@ -48,7 +48,7 @@ class KanbanBoardTest extends \PHPUnit\Framework\TestCase
{ {
$board = new KanbanBoard(); $board = new KanbanBoard();
$board->name = 'Name'; $board->name = 'Name';
$board->description = 'Description'; $board->description = 'Description';
$board->setStatus(BoardStatus::ARCHIVED); $board->setStatus(BoardStatus::ARCHIVED);
$board->createdBy = new NullAccount(1); $board->createdBy = new NullAccount(1);

2
tests/Models/KanbanCardCommentTest.php
View File

@ -48,7 +48,7 @@ class KanbanCardCommentTest extends \PHPUnit\Framework\TestCase
$comment->setCard(2); $comment->setCard(2);
$comment->description = 'Description'; $comment->description = 'Description';
$comment->createdBy = new NullAccount(1); $comment->createdBy = new NullAccount(1);
$comment->addMedia(3); $comment->addMedia(3);
self::assertEquals(2, $comment->getCard()); self::assertEquals(2, $comment->getCard());

2
tests/Models/KanbanCardTest.php
View File

@ -55,7 +55,7 @@ class KanbanCardTest extends \PHPUnit\Framework\TestCase
$card = new KanbanCard(); $card = new KanbanCard();
$card->setStatus(CardStatus::ARCHIVED); $card->setStatus(CardStatus::ARCHIVED);
$card->setType(CardType::TASK); $card->setType(CardType::TASK);
$card->name = 'Name'; $card->name = 'Name';
$card->description = 'Description'; $card->description = 'Description';
$card->setColumn(1); $card->setColumn(1);
$card->setOrder(2); $card->setOrder(2);