mirror of
https://github.com/Karaka-Management/oms-Kanban.git
synced 2026-02-18 13:18:41 +00:00
cs fixes, bug fixes, code coverage
This commit is contained in:
parent
833503241f
commit
b345f1131f
|
|
@ -12,9 +12,7 @@ If you have a good idea for improvement feel free to create a new issue with all
|
||||||
|
|
||||||
### Issues
|
### Issues
|
||||||
|
|
||||||
Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the `Project.md` file in the `Docs` repository.
|
Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the code marked with `@todo` or in the [PROJECT.md](https://github.com/Orange-Management/Docs/blob/master/Project/PROJECT.md) file.
|
||||||
|
|
||||||
The issue information can be used to provide additional information such as priority, difficulty and type. For your first issue try to find a issue marked `[d:first]` or `[d:beginner]`.
|
|
||||||
|
|
||||||
### Code Style
|
### Code Style
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -16,8 +16,8 @@ namespace Modules\Kanban\Models;
|
||||||
|
|
||||||
use Modules\Admin\Models\Account;
|
use Modules\Admin\Models\Account;
|
||||||
use Modules\Admin\Models\NullAccount;
|
use Modules\Admin\Models\NullAccount;
|
||||||
use Modules\Tag\Models\Tag;
|
|
||||||
use Modules\Tag\Models\NullTag;
|
use Modules\Tag\Models\NullTag;
|
||||||
|
use Modules\Tag\Models\Tag;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Kanban board class.
|
* Kanban board class.
|
||||||
|
|
|
||||||
|
|
@ -17,8 +17,8 @@ namespace Modules\Kanban\Models;
|
||||||
use Modules\Admin\Models\Account;
|
use Modules\Admin\Models\Account;
|
||||||
use Modules\Admin\Models\NullAccount;
|
use Modules\Admin\Models\NullAccount;
|
||||||
use Modules\Media\Models\Media;
|
use Modules\Media\Models\Media;
|
||||||
use Modules\Tag\Models\Tag;
|
|
||||||
use Modules\Tag\Models\NullTag;
|
use Modules\Tag\Models\NullTag;
|
||||||
|
use Modules\Tag\Models\Tag;
|
||||||
use Modules\Tasks\Models\Task;
|
use Modules\Tasks\Models\Task;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
|
||||||
|
|
@ -24,13 +24,13 @@ use phpOMS\Dispatcher\Dispatcher;
|
||||||
use phpOMS\Event\EventManager;
|
use phpOMS\Event\EventManager;
|
||||||
use phpOMS\Message\Http\HttpRequest;
|
use phpOMS\Message\Http\HttpRequest;
|
||||||
use phpOMS\Message\Http\HttpResponse;
|
use phpOMS\Message\Http\HttpResponse;
|
||||||
|
use phpOMS\Message\Http\RequestStatusCode;
|
||||||
|
use phpOMS\Module\ModuleAbstract;
|
||||||
use phpOMS\Module\ModuleManager;
|
use phpOMS\Module\ModuleManager;
|
||||||
use phpOMS\Router\WebRouter;
|
use phpOMS\Router\WebRouter;
|
||||||
|
use phpOMS\System\MimeType;
|
||||||
use phpOMS\Uri\HttpUri;
|
use phpOMS\Uri\HttpUri;
|
||||||
use phpOMS\Utils\TestUtils;
|
use phpOMS\Utils\TestUtils;
|
||||||
use phpOMS\Module\ModuleAbstract;
|
|
||||||
use phpOMS\System\MimeType;
|
|
||||||
use phpOMS\Message\Http\RequestStatusCode;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @internal
|
* @internal
|
||||||
|
|
|
||||||
1
tests/Models/1KanbanBoardMapperTest.php → tests/Models/KanbanBoardMapperTest.php
Executable file → Normal file
1
tests/Models/1KanbanBoardMapperTest.php → tests/Models/KanbanBoardMapperTest.php
Executable file → Normal file
|
|
@ -17,7 +17,6 @@ namespace Modules\Kanban\tests\Models;
|
||||||
use Modules\Admin\Models\NullAccount;
|
use Modules\Admin\Models\NullAccount;
|
||||||
use Modules\Kanban\Models\KanbanBoard;
|
use Modules\Kanban\Models\KanbanBoard;
|
||||||
use Modules\Kanban\Models\KanbanBoardMapper;
|
use Modules\Kanban\Models\KanbanBoardMapper;
|
||||||
use phpOMS\Utils\RnG\Text;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @internal
|
* @internal
|
||||||
|
|
@ -14,7 +14,6 @@ declare(strict_types=1);
|
||||||
|
|
||||||
namespace Modules\Kanban\tests\Models;
|
namespace Modules\Kanban\tests\Models;
|
||||||
|
|
||||||
use Modules\Admin\Models\NullAccount;
|
|
||||||
use Modules\Kanban\Models\BoardStatus;
|
use Modules\Kanban\Models\BoardStatus;
|
||||||
use Modules\Kanban\Models\KanbanBoard;
|
use Modules\Kanban\Models\KanbanBoard;
|
||||||
use Modules\Tag\Models\Tag;
|
use Modules\Tag\Models\Tag;
|
||||||
|
|
|
||||||
2
tests/Models/5KanbanCardCommentMapperTest.php → tests/Models/KanbanCardCommentMapperTest.php
Executable file → Normal file
2
tests/Models/5KanbanCardCommentMapperTest.php → tests/Models/KanbanCardCommentMapperTest.php
Executable file → Normal file
|
|
@ -17,7 +17,6 @@ namespace Modules\Kanban\tests\Models;
|
||||||
use Modules\Admin\Models\NullAccount;
|
use Modules\Admin\Models\NullAccount;
|
||||||
use Modules\Kanban\Models\KanbanCardComment;
|
use Modules\Kanban\Models\KanbanCardComment;
|
||||||
use Modules\Kanban\Models\KanbanCardCommentMapper;
|
use Modules\Kanban\Models\KanbanCardCommentMapper;
|
||||||
use phpOMS\Utils\RnG\Text;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @internal
|
* @internal
|
||||||
|
|
@ -25,6 +24,7 @@ use phpOMS\Utils\RnG\Text;
|
||||||
final class KanbanCardCommentMapperTest extends \PHPUnit\Framework\TestCase
|
final class KanbanCardCommentMapperTest extends \PHPUnit\Framework\TestCase
|
||||||
{
|
{
|
||||||
/**
|
/**
|
||||||
|
* @depends Modules\Kanban\tests\Models\KanbanCardMapperTest::testCRUD
|
||||||
* @covers Modules\Kanban\Models\KanbanCardCommentMapper
|
* @covers Modules\Kanban\Models\KanbanCardCommentMapper
|
||||||
* @group module
|
* @group module
|
||||||
*/
|
*/
|
||||||
|
|
@ -14,7 +14,6 @@ declare(strict_types=1);
|
||||||
|
|
||||||
namespace Modules\Kanban\tests\Models;
|
namespace Modules\Kanban\tests\Models;
|
||||||
|
|
||||||
use Modules\Admin\Models\NullAccount;
|
|
||||||
use Modules\Kanban\Models\KanbanCardComment;
|
use Modules\Kanban\Models\KanbanCardComment;
|
||||||
use Modules\Media\Models\NullMedia;
|
use Modules\Media\Models\NullMedia;
|
||||||
|
|
||||||
|
|
|
||||||
3
tests/Models/4KanbanCardMapperTest.php → tests/Models/KanbanCardMapperTest.php
Executable file → Normal file
3
tests/Models/4KanbanCardMapperTest.php → tests/Models/KanbanCardMapperTest.php
Executable file → Normal file
|
|
@ -19,9 +19,7 @@ use Modules\Kanban\Models\CardStatus;
|
||||||
use Modules\Kanban\Models\CardType;
|
use Modules\Kanban\Models\CardType;
|
||||||
use Modules\Kanban\Models\KanbanCard;
|
use Modules\Kanban\Models\KanbanCard;
|
||||||
use Modules\Kanban\Models\KanbanCardMapper;
|
use Modules\Kanban\Models\KanbanCardMapper;
|
||||||
use Modules\Tag\Models\NullTag;
|
|
||||||
use Modules\Tag\Models\Tag;
|
use Modules\Tag\Models\Tag;
|
||||||
use phpOMS\Utils\RnG\Text;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @internal
|
* @internal
|
||||||
|
|
@ -29,6 +27,7 @@ use phpOMS\Utils\RnG\Text;
|
||||||
final class KanbanCardMapperTest extends \PHPUnit\Framework\TestCase
|
final class KanbanCardMapperTest extends \PHPUnit\Framework\TestCase
|
||||||
{
|
{
|
||||||
/**
|
/**
|
||||||
|
* @depends Modules\Kanban\tests\Models\KanbanCardMapperTest::testCRUD
|
||||||
* @covers Modules\Kanban\Models\KanbanCardMapper
|
* @covers Modules\Kanban\Models\KanbanCardMapper
|
||||||
* @group module
|
* @group module
|
||||||
*/
|
*/
|
||||||
|
|
@ -14,13 +14,12 @@ declare(strict_types=1);
|
||||||
|
|
||||||
namespace Modules\Kanban\tests\Models;
|
namespace Modules\Kanban\tests\Models;
|
||||||
|
|
||||||
use Modules\Admin\Models\NullAccount;
|
|
||||||
use Modules\Kanban\Models\CardStatus;
|
use Modules\Kanban\Models\CardStatus;
|
||||||
use Modules\Kanban\Models\CardType;
|
use Modules\Kanban\Models\CardType;
|
||||||
use Modules\Kanban\Models\KanbanCard;
|
use Modules\Kanban\Models\KanbanCard;
|
||||||
use Modules\Media\Models\NullMedia;
|
use Modules\Media\Models\NullMedia;
|
||||||
use Modules\Tasks\Models\Task;
|
|
||||||
use Modules\Tag\Models\Tag;
|
use Modules\Tag\Models\Tag;
|
||||||
|
use Modules\Tasks\Models\Task;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @internal
|
* @internal
|
||||||
|
|
|
||||||
2
tests/Models/3KanbanColumnMapperTest.php → tests/Models/KanbanColumnMapperTest.php
Executable file → Normal file
2
tests/Models/3KanbanColumnMapperTest.php → tests/Models/KanbanColumnMapperTest.php
Executable file → Normal file
|
|
@ -16,7 +16,6 @@ namespace Modules\Kanban\tests\Models;
|
||||||
|
|
||||||
use Modules\Kanban\Models\KanbanColumn;
|
use Modules\Kanban\Models\KanbanColumn;
|
||||||
use Modules\Kanban\Models\KanbanColumnMapper;
|
use Modules\Kanban\Models\KanbanColumnMapper;
|
||||||
use phpOMS\Utils\RnG\Text;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @internal
|
* @internal
|
||||||
|
|
@ -24,6 +23,7 @@ use phpOMS\Utils\RnG\Text;
|
||||||
final class KanbanColumnMapperTest extends \PHPUnit\Framework\TestCase
|
final class KanbanColumnMapperTest extends \PHPUnit\Framework\TestCase
|
||||||
{
|
{
|
||||||
/**
|
/**
|
||||||
|
* @depends Modules\Kanban\tests\Models\KanbanBoardMapperTest::testCRUD
|
||||||
* @covers Modules\Kanban\Models\KanbanColumnMapper
|
* @covers Modules\Kanban\Models\KanbanColumnMapper
|
||||||
* @group module
|
* @group module
|
||||||
*/
|
*/
|
||||||
Loading…
Reference in New Issue
Block a user