Test fixes
Some checks failed
Image optimization / general_image_workflow (push) Has been cancelled
CI / general_module_workflow_php (push) Has been cancelled
CI / general_module_workflow_js (push) Has been cancelled

This commit is contained in:
Dennis Eichhorn 2024-05-16 02:14:54 +00:00
parent bdaf777637
commit 903964d70e
8 changed files with 21 additions and 21 deletions

View File

@ -107,9 +107,11 @@ final class ApiController extends Controller
$accounts[] = $card->createdBy->id; $accounts[] = $card->createdBy->id;
} }
foreach ($card->commentList->comments as $element) { if ($card->commentList !== null) {
if ($element->createdBy->id !== $comment->createdBy->id) { foreach ($card->commentList->comments as $element) {
$accounts[] = $element->createdBy->id; if ($element->createdBy->id !== $comment->createdBy->id) {
$accounts[] = $element->createdBy->id;
}
} }
} }
@ -456,7 +458,14 @@ final class ApiController extends Controller
public function apiCommentCreate(RequestAbstract $request, ResponseAbstract $response, array $data = []) : void public function apiCommentCreate(RequestAbstract $request, ResponseAbstract $response, array $data = []) : void
{ {
$this->app->moduleManager->get('Comment', 'Api')->apiCommentCreate($request, $response, $data); $this->app->moduleManager->get('Comment', 'Api')->apiCommentCreate($request, $response, $data);
$comment = $response->getDataArray($request->uri->__toString())['response']; $comment = $response->getDataArray($request->uri->__toString())['response'] ?? null;
if ($comment === null) {
$response->header->status = RequestStatusCode::R_400;
$this->createInvalidCreateResponse($request, $response, $comment);
return;
}
$this->createCommentNotifications($comment, $request); $this->createCommentNotifications($comment, $request);
} }

View File

@ -1,5 +0,0 @@
# Structure
## ER
![ER](Modules/Kanban/Docs/Dev/img/er.png)

Binary file not shown.

Before

Width:  |  Height:  |  Size: 184 KiB

View File

@ -19,7 +19,3 @@ Other modules that work great with this one together are:
* [Tasks](Tasks) * [Tasks](Tasks)
* [ProjectManagement](ProjectManagement) * [ProjectManagement](ProjectManagement)
* [EventManagement](EventManagement) * [EventManagement](EventManagement)
# Dependencies
* [Editor](Editor)

View File

@ -20,8 +20,8 @@ return ['Kanban' => [
'Back' => 'Zurück', 'Back' => 'Zurück',
'Date' => 'Datum', 'Date' => 'Datum',
'Description' => 'Beschreibung', 'Description' => 'Beschreibung',
'Columns' => 'Spalten', 'Columns' => 'Spalten',
'Column' => 'Spalte', 'Column' => 'Spalte',
'Order' => 'Order', 'Order' => 'Order',
'Board' => 'Board', 'Board' => 'Board',
'Name' => 'Name', 'Name' => 'Name',

View File

@ -21,8 +21,8 @@ return ['Kanban' => [
'Date' => 'Date', 'Date' => 'Date',
'Description' => 'Description', 'Description' => 'Description',
'Order' => 'Order', 'Order' => 'Order',
'Columns' => 'Columns', 'Columns' => 'Columns',
'Column' => 'Column', 'Column' => 'Column',
'Board' => 'Board', 'Board' => 'Board',
'Name' => 'Name', 'Name' => 'Name',
'Status' => 'Status', 'Status' => 'Status',

View File

@ -16,7 +16,7 @@ use Modules\Comments\Models\CommentListStatus;
use phpOMS\Uri\UriFactory; use phpOMS\Uri\UriFactory;
/** @var \Modules\Kanban\Models\KanbanCard $card */ /** @var \Modules\Kanban\Models\KanbanCard $card */
$card = $this->data['card']; $card = $this->data['card'];
$isNew = $card->id === 0; $isNew = $card->id === 0;
$editPossible = $card->createdBy->id === $this->request->header->account; $editPossible = $card->createdBy->id === $this->request->header->account;

View File

@ -12,7 +12,7 @@
}, },
"creator": { "creator": {
"name": "Jingga", "name": "Jingga",
"website": "jingga.app" "website": "https://jingga.app"
}, },
"description": "Kanban module.", "description": "Kanban module.",
"directory": "Kanban", "directory": "Kanban",