mirror of
https://github.com/Karaka-Management/oms-Kanban.git
synced 2026-01-11 11:28:42 +00:00
Test fixes
This commit is contained in:
parent
bdaf777637
commit
903964d70e
|
|
@ -107,9 +107,11 @@ final class ApiController extends Controller
|
|||
$accounts[] = $card->createdBy->id;
|
||||
}
|
||||
|
||||
foreach ($card->commentList->comments as $element) {
|
||||
if ($element->createdBy->id !== $comment->createdBy->id) {
|
||||
$accounts[] = $element->createdBy->id;
|
||||
if ($card->commentList !== null) {
|
||||
foreach ($card->commentList->comments as $element) {
|
||||
if ($element->createdBy->id !== $comment->createdBy->id) {
|
||||
$accounts[] = $element->createdBy->id;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -456,7 +458,14 @@ final class ApiController extends Controller
|
|||
public function apiCommentCreate(RequestAbstract $request, ResponseAbstract $response, array $data = []) : void
|
||||
{
|
||||
$this->app->moduleManager->get('Comment', 'Api')->apiCommentCreate($request, $response, $data);
|
||||
$comment = $response->getDataArray($request->uri->__toString())['response'];
|
||||
$comment = $response->getDataArray($request->uri->__toString())['response'] ?? null;
|
||||
|
||||
if ($comment === null) {
|
||||
$response->header->status = RequestStatusCode::R_400;
|
||||
$this->createInvalidCreateResponse($request, $response, $comment);
|
||||
|
||||
return;
|
||||
}
|
||||
|
||||
$this->createCommentNotifications($comment, $request);
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,5 +0,0 @@
|
|||
# Structure
|
||||
|
||||
## ER
|
||||
|
||||

|
||||
Binary file not shown.
|
Before Width: | Height: | Size: 184 KiB |
|
|
@ -4,11 +4,11 @@ The **Kanban** module allows users to create kanban boards to manage projects, e
|
|||
|
||||
## Target Group
|
||||
|
||||
The target groups for this module is everyone who would like to manage projects and events in a kanban style.
|
||||
The target groups for this module is everyone who would like to manage projects and events in a kanban style.
|
||||
|
||||
# Setup
|
||||
|
||||
The module can be installed through the integrated module downloader and installer or by uploading the module into the `Modules/` directory and executing the installation through the module installer.
|
||||
The module can be installed through the integrated module downloader and installer or by uploading the module into the `Modules/` directory and executing the installation through the module installer.
|
||||
|
||||
The module is depending on the **Editor** module which provides most of the writing features and the **Tasks** module for generating the tasks.
|
||||
|
||||
|
|
@ -19,7 +19,3 @@ Other modules that work great with this one together are:
|
|||
* [Tasks](Tasks)
|
||||
* [ProjectManagement](ProjectManagement)
|
||||
* [EventManagement](EventManagement)
|
||||
|
||||
# Dependencies
|
||||
|
||||
* [Editor](Editor)
|
||||
|
|
|
|||
|
|
@ -20,8 +20,8 @@ return ['Kanban' => [
|
|||
'Back' => 'Zurück',
|
||||
'Date' => 'Datum',
|
||||
'Description' => 'Beschreibung',
|
||||
'Columns' => 'Spalten',
|
||||
'Column' => 'Spalte',
|
||||
'Columns' => 'Spalten',
|
||||
'Column' => 'Spalte',
|
||||
'Order' => 'Order',
|
||||
'Board' => 'Board',
|
||||
'Name' => 'Name',
|
||||
|
|
|
|||
|
|
@ -21,8 +21,8 @@ return ['Kanban' => [
|
|||
'Date' => 'Date',
|
||||
'Description' => 'Description',
|
||||
'Order' => 'Order',
|
||||
'Columns' => 'Columns',
|
||||
'Column' => 'Column',
|
||||
'Columns' => 'Columns',
|
||||
'Column' => 'Column',
|
||||
'Board' => 'Board',
|
||||
'Name' => 'Name',
|
||||
'Status' => 'Status',
|
||||
|
|
|
|||
|
|
@ -16,7 +16,7 @@ use Modules\Comments\Models\CommentListStatus;
|
|||
use phpOMS\Uri\UriFactory;
|
||||
|
||||
/** @var \Modules\Kanban\Models\KanbanCard $card */
|
||||
$card = $this->data['card'];
|
||||
$card = $this->data['card'];
|
||||
$isNew = $card->id === 0;
|
||||
|
||||
$editPossible = $card->createdBy->id === $this->request->header->account;
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user