From 5912df63b954f776f38b5ecaf83eebe96f3730f7 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Thu, 10 Sep 2020 20:18:47 +0200 Subject: [PATCH] implement immutable datetime --- Models/KanbanBoard.php | 6 +++--- Models/KanbanBoardMapper.php | 2 +- Models/KanbanCard.php | 6 +++--- Models/KanbanCardComment.php | 6 +++--- Models/KanbanCardCommentMapper.php | 2 +- Models/KanbanCardMapper.php | 2 +- tests/Models/KanbanBoardTest.php | 2 +- tests/Models/KanbanCardCommentTest.php | 2 +- tests/Models/KanbanCardTest.php | 2 +- 9 files changed, 15 insertions(+), 15 deletions(-) diff --git a/Models/KanbanBoard.php b/Models/KanbanBoard.php index 94c79b4..5b1c462 100755 --- a/Models/KanbanBoard.php +++ b/Models/KanbanBoard.php @@ -57,7 +57,7 @@ class KanbanBoard implements \JsonSerializable private Account $createdBy; - private \DateTime $createdAt; + private \DateTimeImmutable $createdAt; private array $columns = []; @@ -68,7 +68,7 @@ class KanbanBoard implements \JsonSerializable */ public function __construct() { - $this->createdAt = new \DateTime('now'); + $this->createdAt = new \DateTimeImmutable('now'); $this->createdBy = new NullAccount(); } @@ -221,7 +221,7 @@ class KanbanBoard implements \JsonSerializable * * @since 1.0.0 */ - public function getCreatedAt() : \DateTime + public function getCreatedAt() : \DateTimeInterface { return $this->createdAt; } diff --git a/Models/KanbanBoardMapper.php b/Models/KanbanBoardMapper.php index 033bda2..0efe9ba 100755 --- a/Models/KanbanBoardMapper.php +++ b/Models/KanbanBoardMapper.php @@ -40,7 +40,7 @@ final class KanbanBoardMapper extends DataMapperAbstract 'kanban_board_status' => ['name' => 'kanban_board_status', 'type' => 'int', 'internal' => 'status'], 'kanban_board_order' => ['name' => 'kanban_board_order', 'type' => 'int', 'internal' => 'order'], 'kanban_board_created_by' => ['name' => 'kanban_board_created_by', 'type' => 'int', 'internal' => 'createdBy', 'readonly' => true], - 'kanban_board_created_at' => ['name' => 'kanban_board_created_at', 'type' => 'DateTime', 'internal' => 'createdAt', 'readonly' => true], + 'kanban_board_created_at' => ['name' => 'kanban_board_created_at', 'type' => 'DateTimeImmutable', 'internal' => 'createdAt', 'readonly' => true], ]; /** diff --git a/Models/KanbanCard.php b/Models/KanbanCard.php index 13b5927..e5bd2e1 100755 --- a/Models/KanbanCard.php +++ b/Models/KanbanCard.php @@ -64,7 +64,7 @@ class KanbanCard implements \JsonSerializable private Account $createdBy; - private \DateTime $createdAt; + private \DateTimeImmutable $createdAt; private array $comments = []; @@ -79,7 +79,7 @@ class KanbanCard implements \JsonSerializable */ public function __construct() { - $this->createdAt = new \DateTime('now'); + $this->createdAt = new \DateTimeImmutable('now'); $this->createdBy = new NullAccount(); } @@ -310,7 +310,7 @@ class KanbanCard implements \JsonSerializable * * @since 1.0.0 */ - public function getCreatedAt() : \DateTime + public function getCreatedAt() : \DateTimeInterface { return $this->createdAt; } diff --git a/Models/KanbanCardComment.php b/Models/KanbanCardComment.php index a35fe2d..6e20e0d 100755 --- a/Models/KanbanCardComment.php +++ b/Models/KanbanCardComment.php @@ -47,7 +47,7 @@ class KanbanCardComment implements \JsonSerializable private Account $createdBy; - private \DateTime $createdAt; + private \DateTimeImmutable $createdAt; private array $media = []; @@ -58,7 +58,7 @@ class KanbanCardComment implements \JsonSerializable */ public function __construct() { - $this->createdAt = new \DateTime('now'); + $this->createdAt = new \DateTimeImmutable('now'); $this->createdBy = new NullAccount(); } @@ -159,7 +159,7 @@ class KanbanCardComment implements \JsonSerializable * * @since 1.0.0 */ - public function getCreatedAt() : \DateTime + public function getCreatedAt() : \DateTimeInterface { return $this->createdAt; } diff --git a/Models/KanbanCardCommentMapper.php b/Models/KanbanCardCommentMapper.php index 13b62ae..76dc375 100755 --- a/Models/KanbanCardCommentMapper.php +++ b/Models/KanbanCardCommentMapper.php @@ -38,7 +38,7 @@ final class KanbanCardCommentMapper extends DataMapperAbstract 'kanban_card_comment_id' => ['name' => 'kanban_card_comment_id', 'type' => 'int', 'internal' => 'id'], 'kanban_card_comment_description' => ['name' => 'kanban_card_comment_description', 'type' => 'string', 'internal' => 'description'], 'kanban_card_comment_card' => ['name' => 'kanban_card_comment_card', 'type' => 'int', 'internal' => 'card'], - 'kanban_card_comment_created_at' => ['name' => 'kanban_card_comment_created_at', 'type' => 'DateTime', 'internal' => 'createdAt', 'readonly' => true], + 'kanban_card_comment_created_at' => ['name' => 'kanban_card_comment_created_at', 'type' => 'DateTimeImmutable', 'internal' => 'createdAt', 'readonly' => true], 'kanban_card_comment_created_by' => ['name' => 'kanban_card_comment_created_by', 'type' => 'int', 'internal' => 'createdBy', 'readonly' => true], ]; diff --git a/Models/KanbanCardMapper.php b/Models/KanbanCardMapper.php index b10c9eb..fa0987a 100755 --- a/Models/KanbanCardMapper.php +++ b/Models/KanbanCardMapper.php @@ -43,7 +43,7 @@ final class KanbanCardMapper extends DataMapperAbstract 'kanban_card_order' => ['name' => 'kanban_card_order', 'type' => 'int', 'internal' => 'order'], 'kanban_card_ref' => ['name' => 'kanban_card_ref', 'type' => 'int', 'internal' => 'ref'], 'kanban_card_column' => ['name' => 'kanban_card_column', 'type' => 'int', 'internal' => 'column'], - 'kanban_card_created_at' => ['name' => 'kanban_card_created_at', 'type' => 'DateTime', 'internal' => 'createdAt', 'readonly' => true], + 'kanban_card_created_at' => ['name' => 'kanban_card_created_at', 'type' => 'DateTimeImmutable', 'internal' => 'createdAt', 'readonly' => true], 'kanban_card_created_by' => ['name' => 'kanban_card_created_by', 'type' => 'int', 'internal' => 'createdBy', 'readonly' => true], ]; diff --git a/tests/Models/KanbanBoardTest.php b/tests/Models/KanbanBoardTest.php index 2836b29..8e10391 100755 --- a/tests/Models/KanbanBoardTest.php +++ b/tests/Models/KanbanBoardTest.php @@ -32,7 +32,7 @@ class KanbanBoardTest extends \PHPUnit\Framework\TestCase self::assertEquals('', $board->getName()); self::assertEquals('', $board->getDescription()); self::assertEquals(0, $board->getCreatedBy()->getId()); - self::assertInstanceOf('\DateTime', $board->getCreatedAt()); + self::assertInstanceOf('\DateTimeImmutable', $board->getCreatedAt()); self::assertEquals([], $board->getColumns()); } diff --git a/tests/Models/KanbanCardCommentTest.php b/tests/Models/KanbanCardCommentTest.php index 0cf9f46..a16ba49 100755 --- a/tests/Models/KanbanCardCommentTest.php +++ b/tests/Models/KanbanCardCommentTest.php @@ -30,7 +30,7 @@ class KanbanCardCommentTest extends \PHPUnit\Framework\TestCase self::assertEquals(0, $comment->getCard()); self::assertEquals('', $comment->getDescription()); self::assertEquals(0, $comment->getCreatedBy()->getId()); - self::assertInstanceOf('\DateTime', $comment->getCreatedAt()); + self::assertInstanceOf('\DateTimeImmutable', $comment->getCreatedAt()); self::assertEquals([], $comment->getMedia()); } diff --git a/tests/Models/KanbanCardTest.php b/tests/Models/KanbanCardTest.php index 1e57c7c..7d9844c 100755 --- a/tests/Models/KanbanCardTest.php +++ b/tests/Models/KanbanCardTest.php @@ -36,7 +36,7 @@ class KanbanCardTest extends \PHPUnit\Framework\TestCase self::assertEquals(0, $card->getColumn()); self::assertEquals(0, $card->getOrder()); self::assertEquals(0, $card->getCreatedBy()->getId()); - self::assertInstanceOf('\DateTime', $card->getCreatedAt()); + self::assertInstanceOf('\DateTimeImmutable', $card->getCreatedAt()); self::assertEquals([], $card->getComments()); self::assertEquals([], $card->getLabels()); self::assertEquals([], $card->getMedia());