phpcs+phpstan fixes

This commit is contained in:
Dennis Eichhorn 2019-02-07 00:05:31 +01:00
parent c2560ee7b9
commit 537ef6e10e
9 changed files with 12 additions and 33 deletions

View File

@ -36,7 +36,7 @@ class Navigation
*
* @since 1.0.0
*/
public static function install(string $path = null, DatabasePool $dbPool = null) : void
public static function install(string $path, DatabasePool $dbPool) : void
{
\Modules\Navigation\Admin\Installer::installExternal($dbPool, ['path' => __DIR__ . '/Navigation.install.json']);
}

View File

@ -18,8 +18,10 @@ use Modules\Kanban\Models\KanbanBoardMapper;
use Modules\Kanban\Models\KanbanCardMapper;
use Modules\Kanban\Models\PermissionState;
use phpOMS\Account\PermissionType;
use phpOMS\Asset\AssetType;
use phpOMS\Contract\RenderableInterface;
use phpOMS\Message\Http\RequestStatusCode;
use phpOMS\Message\RequestAbstract;
use phpOMS\Message\ResponseAbstract;
@ -48,7 +50,7 @@ final class BackendController extends Controller
*/
public function setupStyles(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
{
/** @var Head $head */
/** @var \phpOMS\Model\Html\Head $head */
$head = $response->get('Content')->getData('head');
$head->addAsset(AssetType::CSS, '/Modules/Kanban/Theme/Backend/css/styles.css');
}
@ -58,12 +60,12 @@ final class BackendController extends Controller
* @param ResponseAbstract $response Response
* @param mixed $data Generic data
*
* @return \Serializable
* @return RenderableInterface
*
* @since 1.0.0
* @codeCoverageIgnore
*/
public function viewKanbanDashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable
public function viewKanbanDashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
{
$view = new View($this->app, $request, $response);
@ -81,12 +83,12 @@ final class BackendController extends Controller
* @param ResponseAbstract $response Response
* @param mixed $data Generic data
*
* @return \Serializable
* @return RenderableInterface
*
* @since 1.0.0
* @codeCoverageIgnore
*/
public function viewKanbanBoard(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable
public function viewKanbanBoard(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
{
$view = new View($this->app, $request, $response);
@ -115,12 +117,12 @@ final class BackendController extends Controller
* @param ResponseAbstract $response Response
* @param mixed $data Generic data
*
* @return \Serializable
* @return RenderableInterface
*
* @since 1.0.0
* @codeCoverageIgnore
*/
public function viewKanbanBoardCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable
public function viewKanbanBoardCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
{
$view = new View($this->app, $request, $response);
@ -145,12 +147,12 @@ final class BackendController extends Controller
* @param ResponseAbstract $response Response
* @param mixed $data Generic data
*
* @return \Serializable
* @return RenderableInterface
*
* @since 1.0.0
* @codeCoverageIgnore
*/
public function viewKanbanCard(RequestAbstract $request, ResponseAbstract $response, $data = null) : \Serializable
public function viewKanbanCard(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
{
$view = new View($this->app, $request, $response);

View File

@ -14,7 +14,6 @@ declare(strict_types=1);
namespace Modules\Kanban\Controller;
use phpOMS\Module\ModuleAbstract;
use phpOMS\Module\WebInterface;

View File

@ -49,11 +49,6 @@ final class KanbanBoardMapper extends DataMapperAbstract
*
* @var array<string, array<string, null|string>>
* @since 1.0.0
*/ /**
* Has many relation.
*
* @var array<string, array<string, string>>
* @since 1.0.0
*/
protected static $hasMany = [
'columns' => [

View File

@ -14,7 +14,6 @@ declare(strict_types=1);
namespace Modules\Kanban\Models;
/**
* Task class.
*

View File

@ -14,7 +14,6 @@ declare(strict_types=1);
namespace Modules\Kanban\Models;
/**
* Task class.
*

View File

@ -47,11 +47,6 @@ final class KanbanCardCommentMapper extends DataMapperAbstract
*
* @var array<string, array<string, null|string>>
* @since 1.0.0
*/ /**
* Has many relation.
*
* @var array<string, array<string, string>>
* @since 1.0.0
*/
protected static $hasMany = [
'media' => [

View File

@ -66,11 +66,6 @@ final class KanbanCardMapper extends DataMapperAbstract
*
* @var array<string, array<string, null|string>>
* @since 1.0.0
*/ /**
* Has many relation.
*
* @var array<string, array<string, string>>
* @since 1.0.0
*/
protected static $hasMany = [
'media' => [

View File

@ -45,11 +45,6 @@ final class KanbanColumnMapper extends DataMapperAbstract
*
* @var array<string, array<string, null|string>>
* @since 1.0.0
*/ /**
* Has many relation.
*
* @var array<string, array<string, string>>
* @since 1.0.0
*/
protected static $hasMany = [
'cards' => [