Jingga/oms-Kanban
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Kanban.git synced 2026-01-11 11:28:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

make order public member

Browse Source
This commit is contained in:
Dennis Eichhorn 2021-08-29 12:50:40 +02:00
parent c6713866ba
commit 276c1bf407
7 changed files with 14 additions and 66 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Controller/ApiController.php
View File

@ -90,8 +90,8 @@ final class ApiController extends Controller
$card->description = Markdown::parse((string) ($request->getData('plain') ?? ''));
$card->style = (string) ($request->getData('style') ?? '');
$card->setColumn((int) $request->getData('column'));
$card->setOrder((int) ($request->getData('order') ?? 1));
$card->setRef((int) ($request->getData('ref') ?? 0));
$card->order = (int) ($request->getData('order') ?? 1);
$card->ref = (int) ($request->getData('ref') ?? 0);
$card->setStatus((int) ($request->getData('status') ?? CardStatus::ACTIVE));
$card->setType((int) ($request->getData('type') ?? CardType::TEXT));
$card->createdBy = new NullAccount($request->header->account);
@ -289,7 +289,7 @@ final class ApiController extends Controller
$board->name = (string) $request->getData('title');
$board->description = Markdown::parse((string) ($request->getData('plain') ?? ''));
$board->descriptionRaw = (string) ($request->getData('plain') ?? '');
$board->setOrder((int) ($request->getData('order') ?? 1));
$board->order = (int) ($request->getData('order') ?? 1);
$board->setStatus((int) ($request->getData('status') ?? BoardStatus::ACTIVE));
$board->createdBy = new NullAccount($request->header->account);
@ -374,7 +374,7 @@ final class ApiController extends Controller
$board->name = $request->getData('title') ?? $board->name;
$board->description = Markdown::parse((string) ($request->getData('plain') ?? $board->descriptionRaw));
$board->descriptionRaw = (string) ($request->getData('plain') ?? $board->descriptionRaw);
$board->setOrder((int) ($request->getData('order') ?? $board->order));
$board->order = (int) ($request->getData('order') ?? $board->order);
$board->setStatus((int) ($request->getData('status') ?? $board->getStatus()));
$board->style = (string) ($request->getData('style') ?? $board->style);
@ -422,7 +422,7 @@ final class ApiController extends Controller
$column = new KanbanColumn();
$column->name = (string) $request->getData('title');
$column->setBoard((int) $request->getData('board'));
$column->setOrder((int) ($request->getData('order') ?? 1));
$column->order = (int) ($request->getData('order') ?? 1);
return $column;
}

28
Models/KanbanCard.php
View File

@ -126,7 +126,7 @@ class KanbanCard implements \JsonSerializable
* @var int
* @since 1.0.0
*/
private int $ref = 0;
public int $ref = 0;
/**
* Created by.
@ -261,32 +261,6 @@ class KanbanCard implements \JsonSerializable
$this->type = $type;
}
/**
* Get the reference if the card references another object (e.g. task, calendar etc.)
*
* @return int
*
* @since 1.0.0
*/
public function getRef() : int
{
return $this->ref;
}
/**
* Set the reference
*
* @param int $ref Reference
*
* @return void
*
* @since 1.0.0
*/
public function setRef(int $ref) : void
{
$this->ref = $ref;
}
/**
* Count the amount of comments in a card
*

28
Models/KanbanColumn.php
View File

@ -46,7 +46,7 @@ class KanbanColumn implements \JsonSerializable
* @var int
* @since 1.0.0
*/
private int $order = 0;
public int $order = 0;
/**
* Board.
@ -76,32 +76,6 @@ class KanbanColumn implements \JsonSerializable
return $this->id;
}
/**
* Get the order
*
* @return int
*
* @since 1.0.0
*/
public function getOrder() : int
{
return $this->order;
}
/**
* Set the order
*
* @param int $order Order
*
* @return void
*
* @since 1.0.0
*/
public function setOrder(int $order) : void
{
$this->order = $order;
}
/**
* Get the board this column belongs to
*

4
tests/Models/3KanbanColumnMapperTest.php
View File

@ -33,7 +33,7 @@ class KanbanColumnMapperTest extends \PHPUnit\Framework\TestCase
$column->name = 'Some Column';
$column->setBoard(1);
$column->setOrder(1);
$column->order = 1;
$id = KanbanColumnMapper::create($column);
self::assertGreaterThan(0, $column->getId());
@ -58,7 +58,7 @@ class KanbanColumnMapperTest extends \PHPUnit\Framework\TestCase
$column->name = $text->generateText(\mt_rand(3, 7));
$column->setBoard(1);
$column->setOrder($i + 1);
$column->order = $i + 1;
$id = KanbanColumnMapper::create($column);
}

6
tests/Models/4KanbanCardMapperTest.php
View File

@ -40,7 +40,7 @@ class KanbanCardMapperTest extends \PHPUnit\Framework\TestCase
$card->description = 'This is some card description';
$card->setStatus(CardStatus::ACTIVE);
$card->setType(CardType::TEXT);
$card->setOrder(1);
$card->order = 1;
$card->setColumn(1);
$card->createdBy = new NullAccount(1);
$card->addTag(new Tag());
@ -73,7 +73,7 @@ class KanbanCardMapperTest extends \PHPUnit\Framework\TestCase
$card->setStatus(CardStatus::ACTIVE);
$card->setType(CardType::TASK);
$card->setRef(1);
$card->setOrder(1);
$card->order = 1;
$card->setColumn(1);
$card->createdBy = new NullAccount(1);
$card->addTag(new Tag());
@ -99,7 +99,7 @@ class KanbanCardMapperTest extends \PHPUnit\Framework\TestCase
$card->description = $text->generateText(\mt_rand(20, 100));
$card->setStatus(CardStatus::ACTIVE);
$card->setType(CardType::TEXT);
$card->setOrder(\mt_rand(1, 10));
$card->order = \mt_rand(1, 10);
$card->setColumn(\mt_rand(1, 4));
$card->createdBy = new NullAccount(1);
$card->addTag(new NullTag(1));

2
tests/Models/KanbanCardTest.php
View File

@ -59,7 +59,7 @@ class KanbanCardTest extends \PHPUnit\Framework\TestCase
$card->name = 'Name';
$card->description = 'Description';
$card->setColumn(1);
$card->setOrder(2);
$card->order = 2;
$card->createdBy = new NullAccount(1);
$card->addComment(5);
$card->addMedia($m = new NullMedia(7));

2
tests/Models/KanbanColumnTest.php
View File

@ -46,7 +46,7 @@ class KanbanColumnTest extends \PHPUnit\Framework\TestCase
$column = new KanbanColumn();
$column->name = 'Name';
$column->setOrder(2);
$column->order = 2;
$column->setBoard(3);
$column->addCard(new KanbanCard());