rename module constants and fix some unit test bugs

This commit is contained in:
Dennis Eichhorn 2021-09-28 18:28:42 +02:00
parent 3472123d75
commit 267a892eb4
4 changed files with 14 additions and 14 deletions

View File

@ -23,7 +23,7 @@ return [
'dest' => '\Modules\Kanban\Controller\BackendController:setupStyles',
'verb' => RouteVerb::GET,
'permission' => [
'module' => BackendController::MODULE_NAME,
'module' => BackendController::NAME,
'type' => PermissionType::READ,
'state' => PermissionState::KANBAN,
],
@ -34,7 +34,7 @@ return [
'dest' => '\Modules\Kanban\Controller\BackendController:viewKanbanDashboard',
'verb' => RouteVerb::GET,
'permission' => [
'module' => BackendController::MODULE_NAME,
'module' => BackendController::NAME,
'type' => PermissionType::READ,
'state' => PermissionState::KANBAN,
],
@ -45,7 +45,7 @@ return [
'dest' => '\Modules\Kanban\Controller\BackendController:viewKanbanArchive',
'verb' => RouteVerb::GET,
'permission' => [
'module' => BackendController::MODULE_NAME,
'module' => BackendController::NAME,
'type' => PermissionType::READ,
'state' => PermissionState::KANBAN,
],
@ -56,7 +56,7 @@ return [
'dest' => '\Modules\Kanban\Controller\BackendController:viewKanbanBoard',
'verb' => RouteVerb::GET,
'permission' => [
'module' => BackendController::MODULE_NAME,
'module' => BackendController::NAME,
'type' => PermissionType::READ,
'state' => PermissionState::BOARD,
],
@ -67,7 +67,7 @@ return [
'dest' => '\Modules\Kanban\Controller\BackendController:viewKanbanCard',
'verb' => RouteVerb::GET,
'permission' => [
'module' => BackendController::MODULE_NAME,
'module' => BackendController::NAME,
'type' => PermissionType::READ,
'state' => PermissionState::CARD,
],
@ -78,7 +78,7 @@ return [
'dest' => '\Modules\Kanban\Controller\BackendController:viewKanbanBoardCreate',
'verb' => RouteVerb::GET,
'permission' => [
'module' => BackendController::MODULE_NAME,
'module' => BackendController::NAME,
'type' => PermissionType::CREATE,
'state' => PermissionState::KANBAN,
],

View File

@ -104,7 +104,7 @@ final class BackendController extends Controller
if ($board->createdBy->getId() !== $accountId
&& !$this->app->accountManager->get($accountId)->hasPermission(
PermissionType::READ, $this->app->orgId, $this->app->appName, self::MODULE_NAME, PermissionState::BOARD, $board->getId())
PermissionType::READ, $this->app->orgId, $this->app->appName, self::NAME, PermissionState::BOARD, $board->getId())
) {
$view->setTemplate('/Web/Backend/Error/403_inline');
$response->header->status = RequestStatusCode::R_403;
@ -165,7 +165,7 @@ final class BackendController extends Controller
$accountId = $request->header->account;
if (!$this->app->accountManager->get($accountId)->hasPermission(
PermissionType::CREATE, $this->app->orgId, $this->app->appName, self::MODULE_NAME, PermissionState::BOARD)
PermissionType::CREATE, $this->app->orgId, $this->app->appName, self::NAME, PermissionState::BOARD)
) {
$view->setTemplate('/Web/Backend/Error/403_inline');
$response->header->status = RequestStatusCode::R_403;
@ -199,7 +199,7 @@ final class BackendController extends Controller
if ($card->createdBy->getId() !== $accountId
&& !$this->app->accountManager->get($accountId)->hasPermission(
PermissionType::READ, $this->app->orgId, $this->app->appName, self::MODULE_NAME, PermissionState::CARD, $card->getId())
PermissionType::READ, $this->app->orgId, $this->app->appName, self::NAME, PermissionState::CARD, $card->getId())
) {
$view->setTemplate('/Web/Backend/Error/403_inline');
$response->header->status = RequestStatusCode::R_403;

View File

@ -32,7 +32,7 @@ class Controller extends ModuleAbstract
* @var string
* @since 1.0.0
*/
public const MODULE_PATH = __DIR__ . '/../';
public const PATH = __DIR__ . '/../';
/**
* Module version.
@ -40,7 +40,7 @@ class Controller extends ModuleAbstract
* @var string
* @since 1.0.0
*/
public const MODULE_VERSION = '1.0.0';
public const VERSION = '1.0.0';
/**
* Module name.
@ -48,7 +48,7 @@ class Controller extends ModuleAbstract
* @var string
* @since 1.0.0
*/
public const MODULE_NAME = 'Kanban';
public const NAME = 'Kanban';
/**
* Module id.
@ -56,7 +56,7 @@ class Controller extends ModuleAbstract
* @var int
* @since 1.0.0
*/
public const MODULE_ID = 1005800000;
public const ID = 1005800000;
/**
* Providing.

View File

@ -19,7 +19,7 @@ namespace Modules\Kanban\tests\Admin;
*/
class AdminTest extends \PHPUnit\Framework\TestCase
{
protected const MODULE_NAME = 'Kanban';
protected const NAME = 'Kanban';
protected const URI_LOAD = 'http://127.0.0.1/en/backend/kanban';