Jingga/oms-ItemManagement
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-ItemManagement.git synced 2026-01-11 11:48:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bug fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2023-12-08 21:52:33 +00:00
parent 6446a78c9d
commit e106dd436b
7 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Controller/ApiAttributeController.php
View File

@ -377,7 +377,7 @@ final class ApiAttributeController extends Controller
* *
* @api * @api
* *
* @todo: implement * @todo Implement API function
* *
* @since 1.0.0 * @since 1.0.0
*/ */
@ -448,7 +448,7 @@ final class ApiAttributeController extends Controller
*/ */
public function apiItemAttributeValueDelete(RequestAbstract $request, ResponseAbstract $response, array $data = []) : void public function apiItemAttributeValueDelete(RequestAbstract $request, ResponseAbstract $response, array $data = []) : void
{ {
// @todo: I don't think values can be deleted? Only Attributes // @todo I don't think values can be deleted? Only Attributes
// However, It should be possible to remove UNUSED default values // However, It should be possible to remove UNUSED default values
// either here or other function? // either here or other function?
// if (!empty($val = $this->validateAttributeValueDelete($request))) { // if (!empty($val = $this->validateAttributeValueDelete($request))) {

2
Controller/ApiController.php
View File

@ -97,7 +97,7 @@ final class ApiController extends Controller
); );
/* /*
@todo: BIG TODO. @todo BIG TODO.
This is the query I want to be used internally: This is the query I want to be used internally:
select itemmgmt_item.itemmgmt_item_no, itemmgmt_item_l11n.itemmgmt_item_l11n_description select itemmgmt_item.itemmgmt_item_no, itemmgmt_item_l11n.itemmgmt_item_l11n_description

4
Controller/BackendController.php
View File

@ -391,7 +391,7 @@ final class BackendController extends Controller
// Get item profile image // Get item profile image
// It might not be part of the 5 newest item files from above // It might not be part of the 5 newest item files from above
// @todo: It would be nice to have something like this as a default method in the model e.g. // @todo It would be nice to have something like this as a default method in the model e.g.
// ItemManagement::getRelations()->with('types')->where(...); // ItemManagement::getRelations()->with('types')->where(...);
// This should return the relations and NOT the model itself // This should return the relations and NOT the model itself
$query = new Builder($this->app->dbPool->get()); $query = new Builder($this->app->dbPool->get());
@ -417,7 +417,7 @@ final class BackendController extends Controller
$view->data['itemImage'] = $itemImage; $view->data['itemImage'] = $itemImage;
// @todo: this one should already be loaded in the backend application no????????? // @todo this one should already be loaded in the backend application no?????????
/** @var \Model\Setting $settings */ /** @var \Model\Setting $settings */
$settings = $this->app->appSettings->get(null, [ $settings = $this->app->appSettings->get(null, [
SettingsEnum::DEFAULT_LOCALIZATION, SettingsEnum::DEFAULT_LOCALIZATION,

2
ICAL.txt
View File

@ -1,6 +1,6 @@
# Individual Contributor License Agreement ("CLA") 1.0 # Individual Contributor License Agreement ("CLA") 1.0
Thank you for your interest in Karaka-Management (the "Company"). In order to clarify the intellectual property license granted with Contributions from any person or entity, the Company must provide a Contributor License Agreement ("CLA") on file that has been made available to each Contributor. This license is for your protection as a Contributor as well as the protection of the Company and its users; it does not change your rights to use your own Contributions for any other purpose. Thank you for your interest in Jingga e. K. (the "Company"). In order to clarify the intellectual property license granted with Contributions from any person or entity, the Company must provide a Contributor License Agreement ("CLA") on file that has been made available to each Contributor. This license is for your protection as a Contributor as well as the protection of the Company and its users; it does not change your rights to use your own Contributions for any other purpose.
By contributing to the Company You accept and agree to the following terms and conditions for Your present and future Contributions submitted to the Company. In return, the Company shall not use Your Contributions in a way that is contrary to the public benefit or inconsistent with its bylaws in effect at the time of the Contribution. Except for the license granted herein to the Company and recipients of software distributed by the Company, You reserve all right, title, and interest in and to Your Contributions. By contributing to the Company You accept and agree to the following terms and conditions for Your present and future Contributions submitted to the Company. In return, the Company shall not use Your Contributions in a way that is contrary to the public benefit or inconsistent with its bylaws in effect at the time of the Contribution. Except for the license granted herein to the Company and recipients of software distributed by the Company, You reserve all right, title, and interest in and to Your Contributions.

2
Models/ItemMapper.php
View File

@ -109,7 +109,7 @@ final class ItemMapper extends DataMapperFactory
* *
* @return array * @return array
* *
* @todo: experimental (not 100% working) * @todo experimental (not 100% working)
* *
* @since 1.0.0 * @since 1.0.0
*/ */

4
Theme/Backend/item-profile.tpl.php
View File

@ -520,7 +520,7 @@ echo $this->data['nav']->render();
<div class="form-group"> <div class="form-group">
<label for="iGeneralPrice"><?= $this->getHtml('Price'); ?></label> <label for="iGeneralPrice"><?= $this->getHtml('Price'); ?></label>
<input id="iGeneralPrice" name="generalprice" type="number" step="0.0001" value="<?= $this->printHtml('0.00'); ?>"> <input id="iGeneralPrice" name="generalprice" type="number" step="0.0001" value="<?= $this->printHtml('0.00'); ?>">
<!-- todo: maybe add promotion key/password here for online shop to provide special prices for certain customer groups --> <!-- @todo maybe add promotion key/password here for online shop to provide special prices for certain customer groups -->
</div> </div>
<div class="form-group"> <div class="form-group">
@ -683,7 +683,7 @@ echo $this->data['nav']->render();
<div class="form-group"> <div class="form-group">
<label for="iGeneralPrice"><?= $this->getHtml('Price'); ?></label> <label for="iGeneralPrice"><?= $this->getHtml('Price'); ?></label>
<input id="iGeneralPrice" name="generalprice" type="number" step="0.0001" value="<?= $this->printHtml('0.00'); ?>"> <input id="iGeneralPrice" name="generalprice" type="number" step="0.0001" value="<?= $this->printHtml('0.00'); ?>">
<!-- todo: maybe add promotion key/password here for online shop to provide special prices for certain customer groups --> <!-- @todo maybe add promotion key/password here for online shop to provide special prices for certain customer groups -->
</div> </div>
<div class="form-group"> <div class="form-group">

4
Theme/Backend/sales-item-profile.tpl.php
View File

@ -595,7 +595,7 @@ echo $this->data['nav']->render();
<td><label for="iGeneralPrice"><?= $this->getHtml('Price'); ?></label> <td><label for="iGeneralPrice"><?= $this->getHtml('Price'); ?></label>
<tr> <tr>
<td><input id="iGeneralPrice" name="generalprice" type="number" step="0.0001" value="<?= $this->printHtml('0.00'); ?>"> <td><input id="iGeneralPrice" name="generalprice" type="number" step="0.0001" value="<?= $this->printHtml('0.00'); ?>">
<!-- todo: maybe add promotion key/password here for online shop to provide special prices for certain customer groups --> <!-- @todo maybe add promotion key/password here for online shop to provide special prices for certain customer groups -->
<tr> <tr>
<td><label for="iDiscount"><?= $this->getHtml('Discount'); ?></label> <td><label for="iDiscount"><?= $this->getHtml('Discount'); ?></label>
<tr> <tr>
@ -715,7 +715,7 @@ echo $this->data['nav']->render();
<td><label for="iGeneralPrice"><?= $this->getHtml('Price'); ?></label> <td><label for="iGeneralPrice"><?= $this->getHtml('Price'); ?></label>
<tr> <tr>
<td><input id="iGeneralPrice" name="generalprice" type="number" step="0.0001" value="<?= $this->printHtml('0.00'); ?>"> <td><input id="iGeneralPrice" name="generalprice" type="number" step="0.0001" value="<?= $this->printHtml('0.00'); ?>">
<!-- todo: maybe add promotion key/password here for online shop to provide special prices for certain customer groups --> <!-- @todo maybe add promotion key/password here for online shop to provide special prices for certain customer groups -->
<tr> <tr>
<td><label for="iDiscount"><?= $this->getHtml('Discount'); ?></label> <td><label for="iDiscount"><?= $this->getHtml('Discount'); ?></label>
<tr> <tr>