Jingga/oms-ItemManagement
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-ItemManagement.git synced 2026-02-18 13:18:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cs fixes, bug fixes, code coverage

Browse Source
This commit is contained in:
Dennis Eichhorn 2021-11-16 00:05:43 +01:00
parent 00866ece42
commit 478cdffe28
13 changed files with 37 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Controller/ApiController.php
View File

@ -33,13 +33,13 @@ use Modules\ItemManagement\Models\NullItemAttributeType;
use Modules\ItemManagement\Models\NullItemAttributeValue;
use Modules\ItemManagement\Models\NullItemL11nType;
use Modules\Media\Models\PathSettings;
use phpOMS\Localization\ISO639x1Enum;
use phpOMS\Localization\Money;
use phpOMS\Message\Http\RequestStatusCode;
use phpOMS\Message\NotificationLevel;
use phpOMS\Message\RequestAbstract;
use phpOMS\Message\ResponseAbstract;
use phpOMS\Model\Message\FormValidation;
use phpOMS\Localization\ISO639x1Enum;
/**
* ItemManagement class.

1
Models/ItemAttribute.php
View File

@ -88,6 +88,7 @@ class ItemAttribute implements \JsonSerializable, ArrayableInterface
{
return [
'id' => $this->id,
'item' => $this->item,
'type' => $this->type,
'value' => $this->value,
];

1
tests/Controller/Api/ApiControllerItemTrait.php
View File

@ -14,7 +14,6 @@ declare(strict_types=1);
namespace Modules\ItemManagement\tests\Controller\Api;
use phpOMS\Localization\ISO3166TwoEnum;
use phpOMS\Message\Http\HttpRequest;
use phpOMS\Message\Http\HttpResponse;
use phpOMS\Message\Http\RequestStatusCode;

5
tests/Controller/ApiControllerTest.php
View File

@ -25,14 +25,9 @@ use phpOMS\Application\ApplicationAbstract;
use phpOMS\DataStorage\Session\HttpSession;
use phpOMS\Dispatcher\Dispatcher;
use phpOMS\Event\EventManager;
use phpOMS\Message\Http\HttpRequest;
use phpOMS\Message\Http\HttpResponse;
use phpOMS\Message\Http\RequestStatusCode;
use phpOMS\Module\ModuleAbstract;
use phpOMS\Module\ModuleManager;
use phpOMS\Router\WebRouter;
use phpOMS\System\MimeType;
use phpOMS\Uri\HttpUri;
use phpOMS\Utils\TestUtils;
/**

1
tests/Models/ItemAttributeTest.php
View File

@ -51,6 +51,7 @@ final class ItemAttributeTest extends \PHPUnit\Framework\TestCase
self::assertEquals(
[
'id',
'item',
'type',
'value',
],

4
tests/Models/ItemAttributeValueTest.php
View File

@ -15,8 +15,8 @@ declare(strict_types=1);
namespace Modules\ItemManagement\tests\Models;
use Modules\ItemManagement\Models\ItemAttributeValue;
use phpOMS\Localization\ISO639x1Enum;
use phpOMS\Localization\ISO3166TwoEnum;
use phpOMS\Localization\ISO639x1Enum;
/**
* @internal
@ -41,7 +41,7 @@ final class ItemAttributeValueTest extends \PHPUnit\Framework\TestCase
{
self::assertEquals(0, $this->attr->getId());
self::assertEquals(0, $this->attr->type);
self::assertEquals(null, $this->attr->getValue());
self::assertNull($this->attr->getValue());
self::assertFalse($this->attr->isDefault);
}

3
tests/Models/ItemTest.php
View File

@ -14,13 +14,12 @@ declare(strict_types=1);
namespace Modules\ItemManagement\tests\Models;
use Modules\Editor\Models\EditorDoc;
use Modules\ItemManagement\Models\Item;
use Modules\ItemManagement\Models\ItemAttribute;
use Modules\ItemManagement\Models\ItemL11n;
use Modules\ItemManagement\Models\ItemStatus;
use Modules\Editor\Models\EditorDoc;
use Modules\Media\Models\Media;
use Modules\Profile\Models\ContactElement;
/**
* @internal