cs fixes, bug fixes, code coverage

Controller/ApiController.php

@@ -33,13 +33,13 @@ use Modules\ItemManagement\Models\NullItemAttributeType;
 use Modules\ItemManagement\Models\NullItemAttributeValue;
 use Modules\ItemManagement\Models\NullItemL11nType;
 use Modules\Media\Models\PathSettings;
+use phpOMS\Localization\ISO639x1Enum;
 use phpOMS\Localization\Money;
 use phpOMS\Message\Http\RequestStatusCode;
 use phpOMS\Message\NotificationLevel;
 use phpOMS\Message\RequestAbstract;
 use phpOMS\Message\ResponseAbstract;
 use phpOMS\Model\Message\FormValidation;
-use phpOMS\Localization\ISO639x1Enum;
 
 /**
  * ItemManagement class.

Models/ItemAttribute.php

@@ -88,6 +88,7 @@ class ItemAttribute implements \JsonSerializable, ArrayableInterface
     {
         return [
             'id'    => $this->id,
+            'item'  => $this->item,
             'type'  => $this->type,
             'value' => $this->value,
         ];

tests/Controller/Api/ApiControllerItemTrait.php

@@ -14,7 +14,6 @@ declare(strict_types=1);
 
 namespace Modules\ItemManagement\tests\Controller\Api;
 
-use phpOMS\Localization\ISO3166TwoEnum;
 use phpOMS\Message\Http\HttpRequest;
 use phpOMS\Message\Http\HttpResponse;
 use phpOMS\Message\Http\RequestStatusCode;

tests/Controller/ApiControllerTest.php

@@ -25,14 +25,9 @@ use phpOMS\Application\ApplicationAbstract;
 use phpOMS\DataStorage\Session\HttpSession;
 use phpOMS\Dispatcher\Dispatcher;
 use phpOMS\Event\EventManager;
-use phpOMS\Message\Http\HttpRequest;
-use phpOMS\Message\Http\HttpResponse;
-use phpOMS\Message\Http\RequestStatusCode;
 use phpOMS\Module\ModuleAbstract;
 use phpOMS\Module\ModuleManager;
 use phpOMS\Router\WebRouter;
-use phpOMS\System\MimeType;
-use phpOMS\Uri\HttpUri;
 use phpOMS\Utils\TestUtils;
 
 /**

tests/Models/ItemAttributeTest.php

@@ -51,6 +51,7 @@ final class ItemAttributeTest extends \PHPUnit\Framework\TestCase
         self::assertEquals(
             [
                 'id',
+                'item',
                 'type',
                 'value',
             ],

tests/Models/ItemAttributeValueTest.php

@@ -15,8 +15,8 @@ declare(strict_types=1);
 namespace Modules\ItemManagement\tests\Models;
 
 use Modules\ItemManagement\Models\ItemAttributeValue;
-use phpOMS\Localization\ISO639x1Enum;
 use phpOMS\Localization\ISO3166TwoEnum;
+use phpOMS\Localization\ISO639x1Enum;
 
 /**
  * @internal
@@ -41,7 +41,7 @@ final class ItemAttributeValueTest extends \PHPUnit\Framework\TestCase
     {
         self::assertEquals(0, $this->attr->getId());
         self::assertEquals(0, $this->attr->type);
-        self::assertEquals(null, $this->attr->getValue());
+        self::assertNull($this->attr->getValue());
         self::assertFalse($this->attr->isDefault);
     }
 

tests/Models/ItemTest.php

@@ -14,13 +14,12 @@ declare(strict_types=1);
 
 namespace Modules\ItemManagement\tests\Models;
 
+use Modules\Editor\Models\EditorDoc;
 use Modules\ItemManagement\Models\Item;
 use Modules\ItemManagement\Models\ItemAttribute;
 use Modules\ItemManagement\Models\ItemL11n;
 use Modules\ItemManagement\Models\ItemStatus;
-use Modules\Editor\Models\EditorDoc;
 use Modules\Media\Models\Media;
-use Modules\Profile\Models\ContactElement;
 
 /**
  * @internal