code fixes

This commit is contained in:
Dennis Eichhorn 2024-03-15 20:24:38 +00:00
parent dc08ab1343
commit b2538e7e14
4 changed files with 20 additions and 4 deletions

View File

@ -24,12 +24,14 @@ use Modules\InvestmentManagement\Models\InvestmentMapper;
use Modules\InvestmentManagement\Models\InvestmentObject;
use Modules\InvestmentManagement\Models\InvestmentObjectMapper;
use Modules\InvestmentManagement\Models\InvestmentStatus;
use Modules\ItemManagement\Models\NullItem;
use Modules\Media\Models\CollectionMapper;
use Modules\Media\Models\MediaMapper;
use Modules\Media\Models\NullMedia;
use Modules\Media\Models\PathSettings;
use Modules\Media\Models\Reference;
use Modules\Media\Models\ReferenceMapper;
use Modules\SupplierManagement\Models\NullSupplier;
use phpOMS\Localization\BaseStringL11n;
use phpOMS\Localization\BaseStringL11nType;
use phpOMS\Localization\ISO639x1Enum;
@ -478,9 +480,9 @@ final class ApiController extends Controller
$investment->link = $request->getDataString('link') ?? '';
$investment->investment = (int) $request->getData('investment');
$investment->parent = $request->getDataInt('parent');
$investment->supplier = $request->getDataInt('supplier');
$investment->supplier = $request->hasData('supplier') ? new NullSupplier((int) $request->getData('supplier')) : null;
$investment->supplierName = $request->getDataString('suppliername') ?? '';
$investment->item = $request->getDataInt('item');
$investment->item = $request->hasData('item') ? new NullItem((int) $request->getData('item')) : null;
// @todo reconsider the following lines. This seems rather complicated.
if ($request->hasData('amount')) {
@ -586,7 +588,6 @@ final class ApiController extends Controller
pathSettings: PathSettings::FILE_PATH
);
foreach ($uploaded as $media) {
$this->createModelRelation(
$request->header->account,

View File

@ -53,6 +53,13 @@ class AmountGroup
$this->type = new BaseStringL11nType();
}
/**
* Get sum of group
*
* @return FloatInt
*
* @since 1.0.0
*/
public function sum() : FloatInt
{
$sum = new FloatInt();

View File

@ -57,6 +57,15 @@ class InvestmentObject
public ?Item $item = null;
/**
* Get amount group by type name
*
* @param string $type Type name
*
* @return AmountGroup
*
* @since 1.0.0
*/
public function getAmountByTypeName(string $type) : AmountGroup
{
foreach ($this->amountGroups as $group) {

View File

@ -12,7 +12,6 @@
*/
declare(strict_types=1);
use Modules\InvestmentManagement\Models\InvestmentStatus;
use phpOMS\Uri\UriFactory;
/** @var \phpOMS\Views\View $this */