From a2e17e82ddacca1d8e3cd82a11283e9257c311fb Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Thu, 21 Apr 2022 23:52:00 +0200 Subject: [PATCH] doc fixes --- CONTRIBUTING.md | 2 +- Controller/ApiController.php | 12 ++++++------ Controller/BackendController.php | 8 ++++---- Controller/TimerecordingController.php | 2 +- Models/SessionElementMapper.php | 2 +- Models/SessionMapper.php | 2 +- 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e9b4371..4bbb819 100755 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -16,7 +16,7 @@ Generally, the development philosophy is result orientated. This means that anyo Developers are encouraged to pick open tasks with high priorities according to their own skill level. Senior developers may directly assign tasks to developers based on their importance. New developers may find it easier to start with a task that has a low priority as they often also have a lower difficulty. -Open tasks can be found in the project overview: [PROJECT.md](../Project/PROJECT.md) +Open tasks can be found in the project overview: [PROJECT.md](https://github.com/Karaka-Management/Organization-Guide/blob/master/Project/PROJECT.md) Tasks currently in development are prefixed in the priority column with an asterisk `*` and a name tag in the task description of the developer who is working on the task. diff --git a/Controller/ApiController.php b/Controller/ApiController.php index 91c4db7..548e7d2 100755 --- a/Controller/ApiController.php +++ b/Controller/ApiController.php @@ -54,7 +54,7 @@ final class ApiController extends Controller * * @since 1.0.0 */ - public function apiSessionCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void + public function apiSessionCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void { if ($request->getData('account') !== null && !$this->app->accountManager->get($request->header->account)->hasPermission( PermissionType::CREATE, $this->app->orgId, $this->app->appName, self::NAME, PermissionCategory::SESSION_FOREIGN @@ -136,7 +136,7 @@ final class ApiController extends Controller * * @since 1.0.0 */ - public function apiSessionElementCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void + public function apiSessionElementCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void { if ((int) ($request->getData('status') ?? -1) === ClockingStatus::START) { $this->apiSessionCreate($request, $response); @@ -250,7 +250,7 @@ final class ApiController extends Controller * * @since 1.0.0 */ - public function apiSessionUpdate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void + public function apiSessionUpdate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void { } @@ -267,7 +267,7 @@ final class ApiController extends Controller * * @since 1.0.0 */ - public function apiSessionElementUpdate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void + public function apiSessionElementUpdate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void { } @@ -284,7 +284,7 @@ final class ApiController extends Controller * * @since 1.0.0 */ - public function apiSessionDelete(RequestAbstract $request, ResponseAbstract $response, $data = null) : void + public function apiSessionDelete(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void { } @@ -301,7 +301,7 @@ final class ApiController extends Controller * * @since 1.0.0 */ - public function apiSessionElementDelete(RequestAbstract $request, ResponseAbstract $response, $data = null) : void + public function apiSessionElementDelete(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void { } } diff --git a/Controller/BackendController.php b/Controller/BackendController.php index f3ca13f..487abab 100755 --- a/Controller/BackendController.php +++ b/Controller/BackendController.php @@ -39,7 +39,7 @@ final class BackendController extends Controller implements DashboardElementInte /** * {@inheritdoc} */ - public function viewDashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface + public function viewDashboard(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : RenderableInterface { $view = new View($this->app->l11nManager, $request, $response); $view->setTemplate('/Modules/HumanResourceTimeRecording/Theme/Backend/dashboard'); @@ -63,7 +63,7 @@ final class BackendController extends Controller implements DashboardElementInte * @since 1.0.0 * @codeCoverageIgnore */ - public function viewPrivateDashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface + public function viewPrivateDashboard(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : RenderableInterface { $view = new View($this->app->l11nManager, $request, $response); $view->setTemplate('/Modules/HumanResourceTimeRecording/Theme/Backend/private-dashboard'); @@ -108,7 +108,7 @@ final class BackendController extends Controller implements DashboardElementInte * @since 1.0.0 * @codeCoverageIgnore */ - public function viewPrivateSession(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface + public function viewPrivateSession(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : RenderableInterface { $view = new View($this->app->l11nManager, $request, $response); $view->setTemplate('/Modules/HumanResourceTimeRecording/Theme/Backend/private-session'); @@ -143,7 +143,7 @@ final class BackendController extends Controller implements DashboardElementInte * @since 1.0.0 * @codeCoverageIgnore */ - public function viewHRStats(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface + public function viewHRStats(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : RenderableInterface { $view = new View($this->app->l11nManager, $request, $response); $view->setTemplate('/Modules/HumanResourceTimeRecording/Theme/Backend/hr-stats'); diff --git a/Controller/TimerecordingController.php b/Controller/TimerecordingController.php index f83dc44..e0c68d4 100755 --- a/Controller/TimerecordingController.php +++ b/Controller/TimerecordingController.php @@ -43,7 +43,7 @@ final class TimerecordingController extends Controller * @since 1.0.0 * @codeCoverageIgnore */ - public function viewDashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface + public function viewDashboard(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : RenderableInterface { $view = new View($this->app->l11nManager, $request, $response); $view->setTemplate('/Modules/HumanResourceTimeRecording/Theme/Timeterminal/overview'); diff --git a/Models/SessionElementMapper.php b/Models/SessionElementMapper.php index 8756f9d..9310cbd 100755 --- a/Models/SessionElementMapper.php +++ b/Models/SessionElementMapper.php @@ -42,7 +42,7 @@ final class SessionElementMapper extends DataMapperFactory /** * Belongs to. * - * @var array + * @var array * @since 1.0.0 */ public const BELONGS_TO = [ diff --git a/Models/SessionMapper.php b/Models/SessionMapper.php index 9982a18..3b15a37 100755 --- a/Models/SessionMapper.php +++ b/Models/SessionMapper.php @@ -62,7 +62,7 @@ final class SessionMapper extends DataMapperFactory /** * Belongs to. * - * @var array + * @var array * @since 1.0.0 */ public const BELONGS_TO = [