Jingga/oms-HumanResourceTimeRecording
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-HumanResourceTimeRecording.git synced 2026-02-13 19:28:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cleanup todos

Browse Source
This commit is contained in:
Dennis Eichhorn 2019-12-31 23:36:34 +01:00
parent 893259c22b
commit 8ad64451a7
1 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
Controller/ApiController.php
View File

@ -272,14 +272,16 @@ final class ApiController extends Controller
* *
* @return void * @return void
* *
* @todo Orange-Management/Modules#194
* Allow session update
* Employee can only change start/end if vacation
*
* @api * @api
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function apiSessionUpdate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void public function apiSessionUpdate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
{ {
// todo: allow to change employee and type.
// employee can only change start/end if vacation
} }
/** /**
@ -291,15 +293,17 @@ final class ApiController extends Controller
* *
* @return void * @return void
* *
* @todo Orange-Management/Modules#195
* Allow session element update
* Employee can only change start/end if vacation.
* This also has to update the session since the data is not 100% normalized.
*
* @api * @api
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function apiSessionElementUpdate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void public function apiSessionElementUpdate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
{ {
// todo: allow to change session, status, and datetime
// employee can only change start/end if vacation
// any change in start end will also change the session because it's not 100% normalized!
} }
/** /**
@ -311,13 +315,16 @@ final class ApiController extends Controller
* *
* @return void * @return void
* *
* @todo Orange-Management/Modules#196
* Implement session delete
* Employee can only delete vacations (maybe)
*
* @api * @api
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function apiSessionDelete(RequestAbstract $request, ResponseAbstract $response, $data = null) : void public function apiSessionDelete(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
{ {
// employee can only delete if vacation
} }
/** /**
@ -329,12 +336,15 @@ final class ApiController extends Controller
* *
* @return void * @return void
* *
* @todo Orange-Management/Modules#196
* Implement session delete
* Employee can only delete vacations (maybe)
*
* @api * @api
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function apiSessionElementDelete(RequestAbstract $request, ResponseAbstract $response, $data = null) : void public function apiSessionElementDelete(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
{ {
// employee can only delete if vacation
} }
} }