diff --git a/Controller/ApiController.php b/Controller/ApiController.php index d3e1e35..d16e9e7 100755 --- a/Controller/ApiController.php +++ b/Controller/ApiController.php @@ -146,15 +146,11 @@ final class ApiController extends Controller return; } - if ($request->hasData('account') && ((int) $request->getData('account')) !== $request->header->account - ) { - if (!$this->app->accountManager->get($request->header->account)->hasPermission( - PermissionType::CREATE, $this->app->unitId, $this->app->appId, self::NAME, PermissionCategory::SESSION_ELEMENT_FOREIGN - )) { - $response->header->status = RequestStatusCode::R_403; - - return; - } + if ($request->hasData('account') && ((int) $request->getData('account')) !== $request->header->account && !$this->app->accountManager->get($request->header->account)->hasPermission( + PermissionType::CREATE, $this->app->unitId, $this->app->appId, self::NAME, PermissionCategory::SESSION_ELEMENT_FOREIGN + )) { + $response->header->status = RequestStatusCode::R_403; + return; } $element = $this->createSessionElementFromRequest($request); diff --git a/Models/Session.php b/Models/Session.php index 29dcb00..f2c7a10 100755 --- a/Models/Session.php +++ b/Models/Session.php @@ -209,7 +209,7 @@ class Session implements \JsonSerializable */ public function getStatus() : int { - if (\count($this->sessionElements) === 0) { + if (empty($this->sessionElements)) { return ClockingStatus::START; } diff --git a/tests/Bootstrap.php b/tests/Bootstrap.php index b904f0c..44438e2 100755 --- a/tests/Bootstrap.php +++ b/tests/Bootstrap.php @@ -381,7 +381,7 @@ function phpServe() : void // Execute the command and store the process ID $output = []; - echo \sprintf('Starting server...') . \PHP_EOL; + echo 'Starting server...' . \PHP_EOL; echo \sprintf(' Current directory: %s', \getcwd()) . \PHP_EOL; echo \sprintf(' %s', $command); \exec($command, $output); @@ -406,7 +406,7 @@ function phpServe() : void // Kill the web server when the process ends \register_shutdown_function(function() use ($killCommand, $pid) : void { - echo \PHP_EOL . \sprintf('Stopping server...') . \PHP_EOL; + echo \PHP_EOL . 'Stopping server...' . \PHP_EOL; echo \sprintf(' %s - Killing process with ID %d', \date('r'), $pid) . \PHP_EOL; \exec($killCommand . $pid); });