cs fixes, bug fixes, code coverage

CONTRIBUTING.md

@@ -12,9 +12,7 @@ If you have a good idea for improvement feel free to create a new issue with all
 
 ### Issues
 
-Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the `Project.md` file in the `Docs` repository.
+Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the code marked with `@todo` or in the [PROJECT.md](https://github.com/Orange-Management/Docs/blob/master/Project/PROJECT.md) file.
-
-The issue information can be used to provide additional information such as priority, difficulty and type. For your first issue try to find a issue marked `[d:first]` or `[d:beginner]`.
 
 ### Code Style
 

Models/EmployeeHistory.php

@@ -16,9 +16,6 @@ namespace Modules\HumanResourceManagement\Models;
 
 use Modules\Media\Models\Media;
 use Modules\Organization\Models\Department;
-use Modules\Organization\Models\NullDepartment;
-use Modules\Organization\Models\NullPosition;
-use Modules\Organization\Models\NullUnit;
 use Modules\Organization\Models\Position;
 use Modules\Organization\Models\Unit;
 use phpOMS\Contract\ArrayableInterface;

tests/Controller/ApiControllerTest.php

@@ -16,6 +16,11 @@ namespace Modules\HumanResourceManagement\tests\Controller;
 
 use Model\CoreSettings;
 use Modules\Admin\Models\AccountPermission;
+use Modules\Organization\Models\Department;
+use Modules\Organization\Models\DepartmentMapper;
+use Modules\Organization\Models\NullUnit;
+use Modules\Organization\Models\Position;
+use Modules\Organization\Models\PositionMapper;
 use phpOMS\Account\Account;
 use phpOMS\Account\AccountManager;
 use phpOMS\Account\PermissionType;
@@ -23,6 +28,7 @@ use phpOMS\Application\ApplicationAbstract;
 use phpOMS\DataStorage\Session\HttpSession;
 use phpOMS\Dispatcher\Dispatcher;
 use phpOMS\Event\EventManager;
+use phpOMS\Localization\ISO3166TwoEnum;
 use phpOMS\Message\Http\HttpRequest;
 use phpOMS\Message\Http\HttpResponse;
 use phpOMS\Message\Http\RequestStatusCode;
@@ -30,16 +36,8 @@ use phpOMS\Module\ModuleAbstract;
 use phpOMS\Module\ModuleManager;
 use phpOMS\Router\WebRouter;
 use phpOMS\Uri\HttpUri;
-use phpOMS\Utils\TestUtils;
 use phpOMS\Utils\RnG\DateTime;
-use phpOMS\Localization\ISO3166TwoEnum;
+use phpOMS\Utils\TestUtils;
-use Modules\Organization\Models\Department;
-use Modules\Organization\Models\DepartmentMapper;
-use Modules\Organization\Models\NullDepartment;
-use Modules\Organization\Models\NullUnit;
-use Modules\Organization\Models\NullPosition;
-use Modules\Organization\Models\Position;
-use Modules\Organization\Models\PositionMapper;
 
 /**
  * @testdox Modules\HumanResourceManagement\tests\Controller\ApiControllerTest: HumanResourceManagement api controller

tests/Models/EmployeeEducationHistoryTest.php

@@ -30,6 +30,7 @@ final class EmployeeEducationHistoryTest extends \PHPUnit\Framework\TestCase
     {
         $this->history = new EmployeeEducationHistory();
     }
+
     /**
      * @covers Modules\HumanResourceManagement\Models\EmployeeEducationHistory
      * @group module

tests/Models/EmployeeTest.php

@@ -14,12 +14,10 @@ declare(strict_types=1);
 
 namespace Modules\HumanResourceManagement\tests\Models;
 
-use Modules\Profile\Models\Profile;
-use Modules\Profile\Models\NullProfile;
 use Modules\HumanResourceManagement\Models\Employee;
+use Modules\HumanResourceManagement\Models\EmployeeEducationHistory;
 use Modules\HumanResourceManagement\Models\EmployeeHistory;
 use Modules\HumanResourceManagement\Models\EmployeeWorkHistory;
-use Modules\HumanResourceManagement\Models\EmployeeEducationHistory;
 
 /**
  * @internal

tests/Models/EmployeeWorkHistoryTest.php

@@ -30,6 +30,7 @@ final class EmployeeWorkHistoryTest extends \PHPUnit\Framework\TestCase
     {
         $this->history = new EmployeeWorkHistory();
     }
+
     /**
      * @covers Modules\HumanResourceManagement\Models\EmployeeWorkHistory
      * @group module

tests/Models/EmplyeeHistoryTest.php

@@ -30,6 +30,7 @@ final class EmployeeHistoryTest extends \PHPUnit\Framework\TestCase
     {
         $this->history = new EmployeeHistory();
     }
+
     /**
      * @covers Modules\HumanResourceManagement\Models\EmployeeHistory
      * @group module