Jingga/oms-HumanResourceManagement
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-HumanResourceManagement.git synced 2026-02-12 02:48:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

add todos from github

Browse Source
This commit is contained in:
Dennis Eichhorn 2019-12-31 19:54:45 +01:00
parent 757dc81e2d
commit 40258fc10b
3 changed files with 9 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Controller/ApiController.php
View File

@ -259,8 +259,7 @@ final class ApiController extends Controller
*/ */
private function createEmployeeHistoryFromRequest(RequestAbstract $request) : EmployeeHistory private function createEmployeeHistoryFromRequest(RequestAbstract $request) : EmployeeHistory
{ {
$history = new EmployeeHistory(); $history = new EmployeeHistory((int) ($request->getData('employee') ?? 0));
$history->setEmployee((int) ($request->getData('employee') ?? 0));
$history->setUnit((int) ($request->getData('unit') ?? 0)); $history->setUnit((int) ($request->getData('unit') ?? 0));
$history->setDepartment((int) ($request->getData('department') ?? 0)); $history->setDepartment((int) ($request->getData('department') ?? 0));
$history->setPosition((int) ($request->getData('position') ?? 0)); $history->setPosition((int) ($request->getData('position') ?? 0));

6
Models/Employee.php
View File

@ -62,7 +62,8 @@ class Employee implements ArrayableInterface, \JsonSerializable
/** /**
* Employee education history. * Employee education history.
* *
* @todo: implement! * @todo Orange-Management/Modules#187
* Implement the education history for an employee. This can be done similarly to the company history.
* *
* @var array * @var array
* @since 1.0.0 * @since 1.0.0
@ -72,6 +73,9 @@ class Employee implements ArrayableInterface, \JsonSerializable
/** /**
* Employee external work history. * Employee external work history.
* *
* @todo Orange-Management/Modules#188
* Implement the work history (at other companies) for an employee. This can be done similarly to the company history.
*
* @var array * @var array
* @since 1.0.0 * @since 1.0.0
*/ */

21
Models/EmployeeHistory.php
View File

@ -94,9 +94,10 @@ class EmployeeHistory implements ArrayableInterface, \JsonSerializable
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function __construct() public function __construct($employee = 0)
{ {
$this->start = new \DateTime('now'); $this->employee = $employee;
$this->start = new \DateTime('now');
} }
/** /**
@ -123,22 +124,6 @@ class EmployeeHistory implements ArrayableInterface, \JsonSerializable
return empty($this->employee) ? new NullEmployee() : $this->employee; return empty($this->employee) ? new NullEmployee() : $this->employee;
} }
/**
* Set the employee
*
* @param int|Employee $employee Employee
*
* @return void
*
* @todo maybe only do this in the constructor
*
* @since 1.0.0
*/
public function setEmployee($employee) : void
{
$this->employee = $employee;
}
/** /**
* Get the position * Get the position
* *