Jingga/oms-FleetManagement
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-FleetManagement.git synced 2026-02-16 05:18:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge branch 'develop' of https://github.com/Karaka-Management/oms-FleetManagement into develop

Browse Source
This commit is contained in:
Dennis Eichhorn 2023-09-24 20:30:13 +00:00
commit a78e4c2974
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Controller/ApiDriverAttributeController.php
View File

@ -447,7 +447,6 @@ final class ApiDriverAttributeController extends Controller
*/ */
public function apiDriverAttributeValueDelete(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void public function apiDriverAttributeValueDelete(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{ {
return;
// @todo: I don't think values can be deleted? Only Attributes // @todo: I don't think values can be deleted? Only Attributes
// However, It should be possible to remove UNUSED default values // However, It should be possible to remove UNUSED default values
// either here or other function? // either here or other function?

1
Controller/ApiVehicleAttributeController.php
View File

@ -447,7 +447,6 @@ final class ApiVehicleAttributeController extends Controller
*/ */
public function apiVehicleAttributeValueDelete(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void public function apiVehicleAttributeValueDelete(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{ {
return;
// @todo: I don't think values can be deleted? Only Attributes // @todo: I don't think values can be deleted? Only Attributes
// However, It should be possible to remove UNUSED default values // However, It should be possible to remove UNUSED default values
// either here or other function? // either here or other function?

3
tests/Controller/ApiControllerTest.php
View File

@ -43,6 +43,7 @@ final class ApiControllerTest extends \PHPUnit\Framework\TestCase
* @var \Modules\FleetManagement\Controller\ApiController * @var \Modules\FleetManagement\Controller\ApiController
*/ */
protected ModuleAbstract $module; protected ModuleAbstract $module;
protected ModuleAbstract $attrModule; protected ModuleAbstract $attrModule;
/** /**
@ -69,7 +70,7 @@ final class ApiControllerTest extends \PHPUnit\Framework\TestCase
$account = new Account(); $account = new Account();
TestUtils::setMember($account, 'id', 1); TestUtils::setMember($account, 'id', 1);
$permission = new AccountPermission(); $permission = new AccountPermission();
$permission->unit = 1; $permission->unit = 1;
$permission->app = 2; $permission->app = 2;
$permission->setPermission( $permission->setPermission(