From 383a588f26a97bd40f1fecb53c7d426e4ef5b5e3 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Tue, 31 Dec 2019 19:54:45 +0100 Subject: [PATCH] add todos from github --- Controller/BackendController.php | 6 ++++++ Models/EventMapper.php | 10 +++++----- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/Controller/BackendController.php b/Controller/BackendController.php index eef712e..4894db9 100644 --- a/Controller/BackendController.php +++ b/Controller/BackendController.php @@ -30,6 +30,12 @@ use phpOMS\Views\View; * @license OMS License 1.0 * @link https://orange-management.org * @since 1.0.0 + * + * @todo Orange-Management/Modules#102 + * Goal definition + * While costs are universal the goal for promotions, events etc. is not. + * In some cases it could be sales in others it could be response rate etc. + * Implement a way to define goals and allow manual+system side evaluation. */ final class BackendController extends Controller { diff --git a/Models/EventMapper.php b/Models/EventMapper.php index 1fea04b..1169fdc 100644 --- a/Models/EventMapper.php +++ b/Models/EventMapper.php @@ -64,11 +64,11 @@ final class EventMapper extends DataMapperAbstract 'dst' => 'eventmanagement_task_relation_dst', 'src' => 'eventmanagement_task_relation_src', ], - 'media' => [ // todo: maybe make this a has one and then link to collection instead of single media files! - 'mapper' => MediaMapper::class, - 'table' => 'eventmanagement_event_media', - 'dst' => 'eventmanagement_event_media_src', - 'src' => 'eventmanagement_event_media_dst', + 'media' => [ + 'mapper' => MediaMapper::class, + 'table' => 'eventmanagement_event_media', + 'dst' => 'eventmanagement_event_media_src', + 'src' => 'eventmanagement_event_media_dst', ], ];