bug fixes
Some checks failed
Image optimization / general_image_workflow (push) Has been cancelled
CI / general_module_workflow_php (push) Has been cancelled
CI / general_module_workflow_js (push) Has been cancelled

This commit is contained in:
Dennis Eichhorn 2024-10-11 19:17:40 +00:00
parent 4efed0e5e5
commit ccd965f537
7 changed files with 29 additions and 15 deletions

View File

@ -139,7 +139,7 @@ final class Installer extends InstallerAbstract
$request->header->account = 1; $request->header->account = 1;
$request->setData('name', $data['name'] ?? ''); $request->setData('name', $data['name'] ?? '');
$request->setData('title', $data['name'] ?? ''); $request->setData('content', $data['name'] ?? '');
$module->apiEditorDocTypeCreate($request, $response); $module->apiEditorDocTypeCreate($request, $response);
@ -163,9 +163,9 @@ final class Installer extends InstallerAbstract
$request = new HttpRequest(); $request = new HttpRequest();
$request->header->account = 1; $request->header->account = 1;
$request->setData('title', $l11n); $request->setData('content', $l11n);
$request->setData('lang', $lang); $request->setData('lang', $lang);
$request->setData('type', $id); $request->setData('ref', $id);
$module->apiEditorDocTypeL11nCreate($request, $response); $module->apiEditorDocTypeL11nCreate($request, $response);
} }

View File

@ -364,11 +364,11 @@ final class ApiController extends Controller
fileNames: $request->getDataList('filenames'), fileNames: $request->getDataList('filenames'),
files: $request->files, files: $request->files,
account: $request->header->account, account: $request->header->account,
basePath: __DIR__ . '/../../../Modules/Media/Files/Modules/Editor/' . ($request->getData('doc') ?? '0'), basePath: __DIR__ . '/../../../Modules/Media/Files/Modules/Editor/' . ($request->getData('ref') ?? '0'),
virtualPath: '/Modules/Editor/' . ($request->getData('doc') ?? '0'), virtualPath: '/Modules/Editor/' . ($request->getData('doc') ?? '0'),
pathSettings: PathSettings::FILE_PATH, pathSettings: PathSettings::FILE_PATH,
tag: $request->getDataInt('tag'), tag: $request->getDataInt('tag'),
rel: (int) $request->getDataInt('doc'), rel: (int) $request->getDataInt('ref'),
mapper: EditorDocMapper::class, mapper: EditorDocMapper::class,
field: 'files' field: 'files'
); );
@ -394,7 +394,7 @@ final class ApiController extends Controller
private function validateEditorFileCreate(RequestAbstract $request) : array private function validateEditorFileCreate(RequestAbstract $request) : array
{ {
$val = []; $val = [];
if (($val['doc'] = !$request->hasData('doc'))) { if (($val['ref'] = !$request->hasData('ref'))) {
return $val; return $val;
} }

View File

@ -74,7 +74,7 @@ final class ApiDocTypeController extends Controller
{ {
$contractType = new BaseStringL11nType(); $contractType = new BaseStringL11nType();
$contractType->setL11n( $contractType->setL11n(
$request->getDataString('title') ?? '', $request->getDataString('content') ?? '',
ISO639x1Enum::tryFromValue($request->getDataString('language')) ?? ISO639x1Enum::_EN ISO639x1Enum::tryFromValue($request->getDataString('language')) ?? ISO639x1Enum::_EN
); );
$contractType->title = $request->getDataString('name') ?? ''; $contractType->title = $request->getDataString('name') ?? '';
@ -94,7 +94,7 @@ final class ApiDocTypeController extends Controller
private function validateEditorDocTypeCreate(RequestAbstract $request) : array private function validateEditorDocTypeCreate(RequestAbstract $request) : array
{ {
$val = []; $val = [];
if (($val['title'] = !$request->hasData('title')) if (($val['content'] = !$request->hasData('content'))
) { ) {
return $val; return $val;
} }
@ -141,9 +141,9 @@ final class ApiDocTypeController extends Controller
private function createEditorDocTypeL11nFromRequest(RequestAbstract $request) : BaseStringL11n private function createEditorDocTypeL11nFromRequest(RequestAbstract $request) : BaseStringL11n
{ {
$contractTypeL11n = new BaseStringL11n(); $contractTypeL11n = new BaseStringL11n();
$contractTypeL11n->ref = $request->getDataInt('type') ?? 0; $contractTypeL11n->ref = $request->getDataInt('ref') ?? 0;
$contractTypeL11n->language = ISO639x1Enum::tryFromValue($request->getDataString('language')) ?? $request->header->l11n->language; $contractTypeL11n->language = ISO639x1Enum::tryFromValue($request->getDataString('language')) ?? $request->header->l11n->language;
$contractTypeL11n->content = $request->getDataString('title') ?? ''; $contractTypeL11n->content = $request->getDataString('content') ?? '';
return $contractTypeL11n; return $contractTypeL11n;
} }
@ -160,8 +160,8 @@ final class ApiDocTypeController extends Controller
private function validateEditorDocTypeL11nCreate(RequestAbstract $request) : array private function validateEditorDocTypeL11nCreate(RequestAbstract $request) : array
{ {
$val = []; $val = [];
if (($val['title'] = !$request->hasData('title')) if (($val['content'] = !$request->hasData('content'))
|| ($val['type'] = !$request->hasData('type')) || ($val['ref'] = !$request->hasData('ref'))
) { ) {
return $val; return $val;
} }

View File

@ -62,6 +62,10 @@ class BaseView extends View
*/ */
public array $docs = []; public array $docs = [];
public string $ref = '';
public string $apiUri = '';
/** /**
* {@inheritdoc} * {@inheritdoc}
*/ */
@ -80,6 +84,8 @@ class BaseView extends View
$this->form = $data[0]; $this->form = $data[0];
$this->name = $data[1] ?? 'UNDEFINED'; $this->name = $data[1] ?? 'UNDEFINED';
$this->docs = $data[2] ?? $this->docs; $this->docs = $data[2] ?? $this->docs;
$this->apiUri = $data[3] ?? '';
$this->ref = $data[4] ?? '';
return parent::render(); return parent::render();
} }

View File

@ -19,7 +19,7 @@ use phpOMS\Uri\UriFactory;
<div class="col-xs-12 col-md-6"> <div class="col-xs-12 col-md-6">
<section class="portlet"> <section class="portlet">
<div class="portlet-head"><?= $this->getHtml('Note', 'Editor', 'Backend'); ?></div> <div class="portlet-head"><?= $this->getHtml('Note', 'Editor', 'Backend'); ?></div>
<form id="<?= $this->form; ?>-create"> <form id="<?= $this->form; ?>-create" action="<?= UriFactory::build($this->apiUri); ?>" method="put">
<div class="portlet-body"> <div class="portlet-body">
<div class="form-group"> <div class="form-group">
<label for="iNoteTitle"><?= $this->getHtml('Title', 'Editor', 'Backend'); ?></label> <label for="iNoteTitle"><?= $this->getHtml('Title', 'Editor', 'Backend'); ?></label>
@ -31,6 +31,10 @@ use phpOMS\Uri\UriFactory;
<pre id="iNoteContent" class="textarea contenteditable" name="description" contenteditable="true"><?= $this->printHtml(''); ?></pre> <pre id="iNoteContent" class="textarea contenteditable" name="description" contenteditable="true"><?= $this->printHtml(''); ?></pre>
</div> </div>
</div> </div>
<div class="portlet-foot">
<input type="hidden" name="ref" form="<?= $this->form; ?>" value="<?= $this->ref; ?>">
<input id="iSubmit" name="submit" type="submit" value="<?= $this->getHtml('Create', '0', '0'); ?>">
</div>
</form> </form>
</section> </section>

View File

@ -57,6 +57,7 @@ echo $this->data['nav']->render(); ?>
</section> </section>
</div> </div>
<!--
<div class="col-xs-12 col-md-4"> <div class="col-xs-12 col-md-4">
<section class="portlet"> <section class="portlet">
<div class="portlet-head"><?= $this->getHtml('Tags', 'Tag'); ?></div> <div class="portlet-head"><?= $this->getHtml('Tags', 'Tag'); ?></div>
@ -65,6 +66,8 @@ echo $this->data['nav']->render(); ?>
</div> </div>
</section> </section>
@todo Implement editor permissions
<section class="portlet"> <section class="portlet">
<div class="portlet-body"> <div class="portlet-body">
<form> <form>
@ -80,4 +83,5 @@ echo $this->data['nav']->render(); ?>
</div> </div>
</section> </section>
</div> </div>
-->
</div> </div>

View File

@ -133,7 +133,7 @@ final class ApiControllerTest extends \PHPUnit\Framework\TestCase
$request = new HttpRequest(); $request = new HttpRequest();
$request->header->account = 1; $request->header->account = 1;
$request->setData('doc', '1'); $request->setData('ref', '1');
$request->setData('name', 'NewUpload'); $request->setData('name', 'NewUpload');
if (!\is_file(__DIR__ . '/test_tmp.md')) { if (!\is_file(__DIR__ . '/test_tmp.md')) {
@ -163,7 +163,7 @@ final class ApiControllerTest extends \PHPUnit\Framework\TestCase
$request = new HttpRequest(); $request = new HttpRequest();
$request->header->account = 1; $request->header->account = 1;
$request->setData('doc', '1'); $request->setData('ref', '1');
$request->setData('name', 'MissingFile'); $request->setData('name', 'MissingFile');
$this->module->apiFileCreate($request, $response); $this->module->apiFileCreate($request, $response);