Jingga/oms-Editor
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Editor.git synced 2026-02-10 07:28:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

static code analysis fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2022-04-05 20:04:47 +02:00
parent 81e228b208
commit 70f7f06f72
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Controller/ApiController.php
View File

@ -234,8 +234,8 @@ final class ApiController extends Controller
$doc = $this->createDocFromRequest($request); $doc = $this->createDocFromRequest($request);
$this->createModel($request->header->account, $doc, EditorDocMapper::class, 'doc', $request->getOrigin()); $this->createModel($request->header->account, $doc, EditorDocMapper::class, 'doc', $request->getOrigin());
if (!empty($request->getFiles() ?? []) if (!empty($request->getFiles())
|| !empty($request->getDataJson('media') ?? []) || !empty($request->getDataJson('media'))
) { ) {
$this->createDocMedia($doc, $request); $this->createDocMedia($doc, $request);
} }
@ -263,7 +263,7 @@ final class ApiController extends Controller
$path = $this->createEditorDir($doc); $path = $this->createEditorDir($doc);
$account = AccountMapper::get()->where('id', $request->header->account)->execute(); $account = AccountMapper::get()->where('id', $request->header->account)->execute();
if (!empty($uploadedFiles = $request->getFiles() ?? [])) { if (!empty($uploadedFiles = $request->getFiles())) {
$uploaded = $this->app->moduleManager->get('Media')->uploadFiles( $uploaded = $this->app->moduleManager->get('Media')->uploadFiles(
[], [],
[], [],
@ -299,7 +299,7 @@ final class ApiController extends Controller
} }
} }
if (!empty($mediaFiles = $request->getDataJson('media') ?? [])) { if (!empty($mediaFiles = $request->getDataJson('media'))) {
$collection = null; $collection = null;
foreach ($mediaFiles as $media) { foreach ($mediaFiles as $media) {
@ -516,7 +516,7 @@ final class ApiController extends Controller
return; return;
} }
$uploadedFiles = $request->getFiles() ?? []; $uploadedFiles = $request->getFiles();
if (empty($uploadedFiles)) { if (empty($uploadedFiles)) {
$this->fillJsonResponse($request, $response, NotificationLevel::ERROR, 'Editor', 'Invalid file', $uploadedFiles); $this->fillJsonResponse($request, $response, NotificationLevel::ERROR, 'Editor', 'Invalid file', $uploadedFiles);
@ -526,8 +526,8 @@ final class ApiController extends Controller
} }
$uploaded = $this->app->moduleManager->get('Media')->uploadFiles( $uploaded = $this->app->moduleManager->get('Media')->uploadFiles(
$request->getDataList('names') ?? [], $request->getDataList('names'),
$request->getDataList('filenames') ?? [], $request->getDataList('filenames'),
$uploadedFiles, $uploadedFiles,
$request->header->account, $request->header->account,
__DIR__ . '/../../../Modules/Media/Files/Modules/Editor/' . ($request->getData('doc') ?? '0'), __DIR__ . '/../../../Modules/Media/Files/Modules/Editor/' . ($request->getData('doc') ?? '0'),

2
Models/EditorDocMapper.php
View File

@ -66,7 +66,7 @@ final class EditorDocMapper extends DataMapperFactory
/** /**
* Belongs to. * Belongs to.
* *
* @var array<string, array{mapper:string, external:string}> * @var array<string, array{mapper:string, external:string, by?:string, column?:string, conditional?:bool}>
* @since 1.0.0 * @since 1.0.0
*/ */
public const OWNS_ONE = [ public const OWNS_ONE = [

2
composer.json
View File

@ -12,7 +12,7 @@
"friendsofphp/php-cs-fixer": ">=3.2", "friendsofphp/php-cs-fixer": ">=3.2",
"squizlabs/php_codesniffer": ">=3.6", "squizlabs/php_codesniffer": ">=3.6",
"phpmd/phpmd": ">=2.9", "phpmd/phpmd": ">=2.9",
"phpstan/phpstan": ">=0.12.58", "phpstan/phpstan": ">=1.5.4",
"phan/phan": ">=3.2.6" "phan/phan": ">=3.2.6"
}, },
"minimum-stability": "dev", "minimum-stability": "dev",