static code analysis fixes

This commit is contained in:
Dennis Eichhorn 2022-04-05 20:04:47 +02:00
parent 81e228b208
commit 70f7f06f72
3 changed files with 9 additions and 9 deletions

View File

@ -234,8 +234,8 @@ final class ApiController extends Controller
$doc = $this->createDocFromRequest($request);
$this->createModel($request->header->account, $doc, EditorDocMapper::class, 'doc', $request->getOrigin());
if (!empty($request->getFiles() ?? [])
|| !empty($request->getDataJson('media') ?? [])
if (!empty($request->getFiles())
|| !empty($request->getDataJson('media'))
) {
$this->createDocMedia($doc, $request);
}
@ -263,7 +263,7 @@ final class ApiController extends Controller
$path = $this->createEditorDir($doc);
$account = AccountMapper::get()->where('id', $request->header->account)->execute();
if (!empty($uploadedFiles = $request->getFiles() ?? [])) {
if (!empty($uploadedFiles = $request->getFiles())) {
$uploaded = $this->app->moduleManager->get('Media')->uploadFiles(
[],
[],
@ -299,7 +299,7 @@ final class ApiController extends Controller
}
}
if (!empty($mediaFiles = $request->getDataJson('media') ?? [])) {
if (!empty($mediaFiles = $request->getDataJson('media'))) {
$collection = null;
foreach ($mediaFiles as $media) {
@ -516,7 +516,7 @@ final class ApiController extends Controller
return;
}
$uploadedFiles = $request->getFiles() ?? [];
$uploadedFiles = $request->getFiles();
if (empty($uploadedFiles)) {
$this->fillJsonResponse($request, $response, NotificationLevel::ERROR, 'Editor', 'Invalid file', $uploadedFiles);
@ -526,8 +526,8 @@ final class ApiController extends Controller
}
$uploaded = $this->app->moduleManager->get('Media')->uploadFiles(
$request->getDataList('names') ?? [],
$request->getDataList('filenames') ?? [],
$request->getDataList('names'),
$request->getDataList('filenames'),
$uploadedFiles,
$request->header->account,
__DIR__ . '/../../../Modules/Media/Files/Modules/Editor/' . ($request->getData('doc') ?? '0'),

View File

@ -66,7 +66,7 @@ final class EditorDocMapper extends DataMapperFactory
/**
* Belongs to.
*
* @var array<string, array{mapper:string, external:string}>
* @var array<string, array{mapper:string, external:string, by?:string, column?:string, conditional?:bool}>
* @since 1.0.0
*/
public const OWNS_ONE = [

View File

@ -12,7 +12,7 @@
"friendsofphp/php-cs-fixer": ">=3.2",
"squizlabs/php_codesniffer": ">=3.6",
"phpmd/phpmd": ">=2.9",
"phpstan/phpstan": ">=0.12.58",
"phpstan/phpstan": ">=1.5.4",
"phan/phan": ">=3.2.6"
},
"minimum-stability": "dev",