Jingga/oms-Dashboard
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Dashboard.git synced 2026-02-12 00:18:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

remove some getter/setter

Browse Source
This commit is contained in:
Dennis Eichhorn 2020-11-24 17:31:19 +01:00
parent b24e25573c
commit dc644a7891
3 changed files with 10 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Controller/ApiController.php
View File

@ -80,14 +80,14 @@ final class ApiController extends Controller
public function apiBoardCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void public function apiBoardCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
{ {
if (!empty($val = $this->validateBoardCreate($request))) { if (!empty($val = $this->validateBoardCreate($request))) {
$response->set($request->getUri()->__toString(), new FormValidation($val)); $response->set($request->uri->__toString(), new FormValidation($val));
$response->getHeader()->setStatusCode(RequestStatusCode::R_400); $response->header->status = RequestStatusCode::R_400;
return; return;
} }
$board = $this->createBoardFromRequest($request); $board = $this->createBoardFromRequest($request);
$this->createModel($request->getHeader()->getAccount(), $board, DashboardBoardMapper::class, 'board', $request->getOrigin()); $this->createModel($request->header->account, $board, DashboardBoardMapper::class, 'board', $request->getOrigin());
$this->fillJsonResponse($request, $response, NotificationLevel::OK, 'Board', 'Board successfully created.', $board); $this->fillJsonResponse($request, $response, NotificationLevel::OK, 'Board', 'Board successfully created.', $board);
} }
@ -103,8 +103,8 @@ final class ApiController extends Controller
private function createBoardFromRequest(RequestAbstract $request) : DashboardBoard private function createBoardFromRequest(RequestAbstract $request) : DashboardBoard
{ {
$board = new DashboardBoard(); $board = new DashboardBoard();
$board->setTitle((string) ($request->getData('title') ?? '')); $board->title = (string) ($request->getData('title') ?? '');
$board->setAccount($request->getHeader()->getAccount()); $board->setAccount($request->header->account);
$board->setStatus(DashboardBoardStatus::ACTIVE); $board->setStatus(DashboardBoardStatus::ACTIVE);
return $board; return $board;
@ -147,14 +147,14 @@ final class ApiController extends Controller
public function apiComponentCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void public function apiComponentCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
{ {
if (!empty($val = $this->validateComponentCreate($request))) { if (!empty($val = $this->validateComponentCreate($request))) {
$response->set($request->getUri()->__toString(), new FormValidation($val)); $response->set($request->uri->__toString(), new FormValidation($val));
$response->getHeader()->setStatusCode(RequestStatusCode::R_400); $response->header->status = RequestStatusCode::R_400;
return; return;
} }
$component = $this->createComponentFromRequest($request); $component = $this->createComponentFromRequest($request);
$this->createModel($request->getHeader()->getAccount(), $component, DashboardComponentMapper::class, 'component', $request->getOrigin()); $this->createModel($request->header->account, $component, DashboardComponentMapper::class, 'component', $request->getOrigin());
$this->fillJsonResponse($request, $response, NotificationLevel::OK, 'Component', 'Component successfully created.', $component); $this->fillJsonResponse($request, $response, NotificationLevel::OK, 'Component', 'Component successfully created.', $component);
} }

2
Controller/BackendController.php
View File

@ -62,7 +62,7 @@ final class BackendController extends Controller
$view->setTemplate('/Modules/Dashboard/Theme/Backend/dashboard'); $view->setTemplate('/Modules/Dashboard/Theme/Backend/dashboard');
$view->addData('nav', $this->app->moduleManager->get('Navigation')->createNavigationMid(1000301001, $request, $response)); $view->addData('nav', $this->app->moduleManager->get('Navigation')->createNavigationMid(1000301001, $request, $response));
$board = DashboardBoardMapper::getFor($request->getHeader()->getAccount(), 'account'); $board = DashboardBoardMapper::getFor($request->header->account, 'account');
if ($board instanceof NullDashboardBoard) { if ($board instanceof NullDashboardBoard) {
$board = DashboardBoardMapper::get(1); $board = DashboardBoardMapper::get(1);

28
Models/DashboardBoard.php
View File

@ -40,7 +40,7 @@ class DashboardBoard implements \JsonSerializable
* @var string * @var string
* @since 1.0.0 * @since 1.0.0
*/ */
protected string $title = ''; public string $title = '';
/** /**
* Account. * Account.
@ -104,32 +104,6 @@ class DashboardBoard implements \JsonSerializable
$this->account = $id; $this->account = $id;
} }
/**
* Get title
*
* @return string
*
* @since 1.0.0
*/
public function getTitle() : string
{
return $this->title;
}
/**
* Set title
*
* @param string $title Title
*
* @return void
*
* @since 1.0.0
*/
public function setTitle(string $title) : void
{
$this->title = $title;
}
/** /**
* Get status * Get status
* *