impl. tests and fix validation status code

This commit is contained in:
Dennis Eichhorn 2020-10-06 21:51:40 +02:00
parent 64db17ce88
commit b971537a3f

View File

@ -1,4 +1,5 @@
<?php <?php
/** /**
* Orange Management * Orange Management
* *
@ -10,6 +11,7 @@
* @version 1.0.0 * @version 1.0.0
* @link https://orange-management.org * @link https://orange-management.org
*/ */
declare(strict_types=1); declare(strict_types=1);
namespace Modules\Dashboard\Controller; namespace Modules\Dashboard\Controller;
@ -23,6 +25,7 @@ use phpOMS\Message\NotificationLevel;
use phpOMS\Message\RequestAbstract; use phpOMS\Message\RequestAbstract;
use phpOMS\Message\ResponseAbstract; use phpOMS\Message\ResponseAbstract;
use phpOMS\Model\Message\FormValidation; use phpOMS\Model\Message\FormValidation;
use phpOMS\Message\Http\RequestStatusCode;
/** /**
* Api controller for the dashboard module. * Api controller for the dashboard module.
@ -54,8 +57,7 @@ final class ApiController extends Controller
private function validateBoardCreate(RequestAbstract $request): array private function validateBoardCreate(RequestAbstract $request): array
{ {
$val = []; $val = [];
if (($val['title'] = empty($request->getData('title'))) if (($val['title'] = empty($request->getData('title')))) {
) {
return $val; return $val;
} }
@ -79,6 +81,7 @@ final class ApiController extends Controller
{ {
if (!empty($val = $this->validateBoardCreate($request))) { if (!empty($val = $this->validateBoardCreate($request))) {
$response->set($request->getUri()->__toString(), new FormValidation($val)); $response->set($request->getUri()->__toString(), new FormValidation($val));
$response->getHeader()->setStatusCode(RequestStatusCode::R_400);
return; return;
} }
@ -145,6 +148,7 @@ final class ApiController extends Controller
{ {
if (!empty($val = $this->validateComponentCreate($request))) { if (!empty($val = $this->validateComponentCreate($request))) {
$response->set($request->getUri()->__toString(), new FormValidation($val)); $response->set($request->getUri()->__toString(), new FormValidation($val));
$response->getHeader()->setStatusCode(RequestStatusCode::R_400);
return; return;
} }