From 4ee7ecf7336f7b6ee726883e31183a6cd5fdfeca Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Tue, 30 Jul 2019 20:23:16 +0200 Subject: [PATCH] cleanup, media fixes, news fixes --- Controller/BackendController.php | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/Controller/BackendController.php b/Controller/BackendController.php index 9b08cc6..45010a1 100644 --- a/Controller/BackendController.php +++ b/Controller/BackendController.php @@ -18,8 +18,8 @@ use Modules\Dashboard\Models\DashboardBoardMapper; use Modules\Dashboard\Models\NullDashboardBoard; use phpOMS\Contract\RenderableInterface; use phpOMS\Message\RequestAbstract; - use phpOMS\Message\ResponseAbstract; +use phpOMS\Module\NullModule; use phpOMS\Views\View; /** @@ -58,9 +58,16 @@ final class BackendController extends Controller $boardComponents = $board->getComponents(); foreach ($boardComponents as $component) { - $panels[] = $this->app->moduleManager - ->get($component->getModule()) - ->viewDashboard($request, $response, $data); + $module = $this->app->moduleManager->get($component->getModule()); + + // todo: check if this should be done with instanceof DashboardView -> instanceof DashboardView + if ($module instanceof NullModule + || !\method_exists($module, 'viewDashboard') + ) { + continue; + } + + $panels[] = $module->viewDashboard($request, $response, $data); } $view->addData('panels', $panels);