Jingga/oms-ContractManagement
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-ContractManagement.git synced 2026-01-23 07:18:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

test fixes and added more tests

Browse Source
This commit is contained in:
Dennis Eichhorn 2021-10-02 20:49:17 +02:00
parent 4143eff4ec
commit bea84a4b79
3 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Admin/Install/db.json
View File

@ -8,11 +8,6 @@
"null": false,
"primary": true,
"autoincrement": true
},
"contractmgmt_type_name": {
"name": "contractmgmt_type_name",
"type": "VARCHAR(255)",
"null": false
}
}
},

6
Controller/ApiController.php
View File

@ -203,8 +203,7 @@ final class ApiController extends Controller
*/
private function createContractTypeFromRequest(RequestAbstract $request) : ContractType
{
$contractType = new ContractType();
$contractType->name = (string) ($request->getData('name') ?? '');
$contractType = new ContractType();
return $contractType;
}
@ -221,8 +220,7 @@ final class ApiController extends Controller
private function validateContractTypeCreate(RequestAbstract $request) : array
{
$val = [];
if (($val['name'] = empty($request->getData('name')))
|| ($val['title'] = empty($request->getData('title')))
if (($val['title'] = empty($request->getData('title')))
) {
return $val;
}

1
Models/ContractTypeMapper.php
View File

@ -34,7 +34,6 @@ final class ContractTypeMapper extends DataMapperAbstract
*/
protected static array $columns = [
'contractmgmt_type_id' => ['name' => 'contractmgmt_type_id', 'type' => 'int', 'internal' => 'id'],
'contractmgmt_type_name' => ['name' => 'contractmgmt_type_name', 'type' => 'string', 'internal' => 'name', 'autocomplete' => true],
];
/**